[dpdk-dev,v2,3/3] net/i40e: update destroy tunnel filter function
diff mbox

Message ID 1490287113-8895-4-git-send-email-bernard.iremonger@intel.com
State Superseded, archived
Delegated to: Ferruh Yigit
Headers show

Checks

Context Check Description
ci/Intel-compilation fail apply patch file failure
ci/checkpatch warning coding style issues

Commit Message

Bernard Iremonger March 23, 2017, 4:38 p.m. UTC
set big_buffer to 1 for QinQ filter in
i40e_flow_destroy_tunnel_filter function.

Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
---
 drivers/net/i40e/i40e_flow.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Lu, Wenzhuo March 28, 2017, 8:54 a.m. UTC | #1
Hi Bernard,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bernard Iremonger
> Sent: Friday, March 24, 2017 12:39 AM
> To: dev@dpdk.org; Xing, Beilei; Wu, Jingjing
> Cc: Zhang, Helin; Iremonger, Bernard
> Subject: [dpdk-dev] [PATCH v2 3/3] net/i40e: update destroy tunnel filter
> function
> 
> set big_buffer to 1 for QinQ filter in
> i40e_flow_destroy_tunnel_filter function.
> 
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Besides the commit log it too detail to repeat the code.
Bernard Iremonger March 28, 2017, 11:13 a.m. UTC | #2
Hi Wenzhuo,

> -----Original Message-----
> From: Lu, Wenzhuo
> Sent: Tuesday, March 28, 2017 9:55 AM
> To: Iremonger, Bernard <bernard.iremonger@intel.com>; dev@dpdk.org;
> Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> Cc: Zhang, Helin <helin.zhang@intel.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v2 3/3] net/i40e: update destroy tunnel filter
> function
> 
> Hi Bernard,
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bernard
> Iremonger
> > Sent: Friday, March 24, 2017 12:39 AM
> > To: dev@dpdk.org; Xing, Beilei; Wu, Jingjing
> > Cc: Zhang, Helin; Iremonger, Bernard
> > Subject: [dpdk-dev] [PATCH v2 3/3] net/i40e: update destroy tunnel
> > filter function
> >
> > set big_buffer to 1 for QinQ filter in i40e_flow_destroy_tunnel_filter
> > function.
> >
> > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com> Besides the commit log it
> too detail to repeat the code.

I will revise the commit log.

Regards,

Bernard.

Patch
diff mbox

diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
index e53ab22..b2f997a 100644
--- a/drivers/net/i40e/i40e_flow.c
+++ b/drivers/net/i40e/i40e_flow.c
@@ -2146,7 +2146,9 @@  i40e_flow_destroy_tunnel_filter(struct i40e_pf *pf,
 	if ((filter->input.flags & I40E_AQC_ADD_CLOUD_FILTER_TEID_MPLSoUDP) ==
 	    I40E_AQC_ADD_CLOUD_FILTER_TEID_MPLSoUDP ||
 	    (filter->input.flags & I40E_AQC_ADD_CLOUD_FILTER_TEID_MPLSoGRE) ==
-	    I40E_AQC_ADD_CLOUD_FILTER_TEID_MPLSoGRE)
+	    I40E_AQC_ADD_CLOUD_FILTER_TEID_MPLSoGRE ||
+	    (filter->input.flags & I40E_AQC_ADD_CLOUD_FILTER_CUSTOM_QINQ) ==
+	    I40E_AQC_ADD_CLOUD_FILTER_CUSTOM_QINQ)
 		big_buffer = 1;
 
 	if (big_buffer)