[dpdk-dev,3/6] bond: fix naming inconsistency in tx_burst_round_robin
diff mbox

Message ID 1408456313-28812-4-git-send-email-declan.doherty@intel.com
State Superseded, archived
Headers show

Commit Message

Doherty, Declan Aug. 19, 2014, 1:51 p.m. UTC
Renaming struct bond_dev_pritvate *dev_private to internals to match convention used in other pmds

Signed-off-by: Declan Doherty <declan.doherty@intel.com>
---
 lib/librte_pmd_bond/rte_eth_bond_pmd.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

Comments

Sanford, Robert Aug. 20, 2014, 8:25 p.m. UTC | #1
Reviewed-by: Robert Sanford <rsanford@akamai.com>


>Renaming struct bond_dev_pritvate *dev_private to internals to match
>convention used in other pmds
>
>Signed-off-by: Declan Doherty <declan.doherty@intel.com>
>---
> lib/librte_pmd_bond/rte_eth_bond_pmd.c |   10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/lib/librte_pmd_bond/rte_eth_bond_pmd.c
>b/lib/librte_pmd_bond/rte_eth_bond_pmd.c
>index 683b146..70123fc 100644
>--- a/lib/librte_pmd_bond/rte_eth_bond_pmd.c
>+++ b/lib/librte_pmd_bond/rte_eth_bond_pmd.c
>@@ -92,7 +92,7 @@ static uint16_t
> bond_ethdev_tx_burst_round_robin(void *queue, struct rte_mbuf **bufs,
> 		uint16_t nb_pkts)
> {
>-	struct bond_dev_private *dev_private;
>+	struct bond_dev_private *internals;
> 	struct bond_tx_queue *bd_tx_q;
> 
> 	struct rte_mbuf *slave_bufs[RTE_MAX_ETHPORTS][nb_pkts];
>@@ -107,13 +107,13 @@ bond_ethdev_tx_burst_round_robin(void *queue,
>struct rte_mbuf **bufs,
> 	int i, cs_idx = 0;
> 
> 	bd_tx_q = (struct bond_tx_queue *)queue;
>-	dev_private = bd_tx_q->dev_private;
>+	internals = bd_tx_q->dev_private;
> 
> 	/* Copy slave list to protect against slave up/down changes during tx
> 	 * bursting */
>-	num_of_slaves = dev_private->active_slave_count;
>-	memcpy(slaves, dev_private->active_slaves,
>-			sizeof(dev_private->active_slaves[0]) * num_of_slaves);
>+	num_of_slaves = internals->active_slave_count;
>+	memcpy(slaves, internals->active_slaves,
>+			sizeof(internals->active_slaves[0]) * num_of_slaves);
> 
> 	if (num_of_slaves < 1)
> 		return num_tx_total;
>-- 
>1.7.0.7
>

Patch
diff mbox

diff --git a/lib/librte_pmd_bond/rte_eth_bond_pmd.c b/lib/librte_pmd_bond/rte_eth_bond_pmd.c
index 683b146..70123fc 100644
--- a/lib/librte_pmd_bond/rte_eth_bond_pmd.c
+++ b/lib/librte_pmd_bond/rte_eth_bond_pmd.c
@@ -92,7 +92,7 @@  static uint16_t
 bond_ethdev_tx_burst_round_robin(void *queue, struct rte_mbuf **bufs,
 		uint16_t nb_pkts)
 {
-	struct bond_dev_private *dev_private;
+	struct bond_dev_private *internals;
 	struct bond_tx_queue *bd_tx_q;
 
 	struct rte_mbuf *slave_bufs[RTE_MAX_ETHPORTS][nb_pkts];
@@ -107,13 +107,13 @@  bond_ethdev_tx_burst_round_robin(void *queue, struct rte_mbuf **bufs,
 	int i, cs_idx = 0;
 
 	bd_tx_q = (struct bond_tx_queue *)queue;
-	dev_private = bd_tx_q->dev_private;
+	internals = bd_tx_q->dev_private;
 
 	/* Copy slave list to protect against slave up/down changes during tx
 	 * bursting */
-	num_of_slaves = dev_private->active_slave_count;
-	memcpy(slaves, dev_private->active_slaves,
-			sizeof(dev_private->active_slaves[0]) * num_of_slaves);
+	num_of_slaves = internals->active_slave_count;
+	memcpy(slaves, internals->active_slaves,
+			sizeof(internals->active_slaves[0]) * num_of_slaves);
 
 	if (num_of_slaves < 1)
 		return num_tx_total;