[dpdk-dev] net/mlx5: fix default set for multicast traffic

Message ID 2c3d48cf2736dcc6824e39c911666521befdd918.1477295827.git.rasland@mellanox.com
State Changes Requested, archived
Delegated to: Bruce Richardson
Headers show

Commit Message

Raslan Darawsheh Oct. 24, 2016, 7:59 a.m.
Remove non-IPv6 multicast traffic with destination MAC 33:33:* from the
default set when not in promiscuous or allmulticast modes.

Fixes: 0497ddaac511 ("mlx5: add special flows for broadcast and IPv6 multicast")

Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
---
 drivers/net/mlx5/mlx5_rxmode.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Adrien Mazarguil Oct. 28, 2016, 12:07 p.m. | #1
On Mon, Oct 24, 2016 at 10:59:14AM +0300, Raslan Darawsheh wrote:
> Remove non-IPv6 multicast traffic with destination MAC 33:33:* from the
> default set when not in promiscuous or allmulticast modes.
> 
> Fixes: 0497ddaac511 ("mlx5: add special flows for broadcast and IPv6 multicast")
> 
> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
> ---
>  drivers/net/mlx5/mlx5_rxmode.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_rxmode.c b/drivers/net/mlx5/mlx5_rxmode.c
> index 173e6e8..4ffe703 100644
> --- a/drivers/net/mlx5/mlx5_rxmode.c
> +++ b/drivers/net/mlx5/mlx5_rxmode.c
> @@ -104,7 +104,6 @@ static const struct special_flow_init special_flow_init[] = {
>  		.hash_types =
>  			1 << HASH_RXQ_UDPV6 |
>  			1 << HASH_RXQ_IPV6 |
> -			1 << HASH_RXQ_ETH |
>  			0,
>  		.per_vlan = 1,
>  	},
> -- 
> 1.9.1

(NACK)

While technically correct, looks like this patch sometimes break IPv6
multicast traffic as well, let's drop it until we figure out the reason.

Patch

diff --git a/drivers/net/mlx5/mlx5_rxmode.c b/drivers/net/mlx5/mlx5_rxmode.c
index 173e6e8..4ffe703 100644
--- a/drivers/net/mlx5/mlx5_rxmode.c
+++ b/drivers/net/mlx5/mlx5_rxmode.c
@@ -104,7 +104,6 @@  static const struct special_flow_init special_flow_init[] = {
 		.hash_types =
 			1 << HASH_RXQ_UDPV6 |
 			1 << HASH_RXQ_IPV6 |
-			1 << HASH_RXQ_ETH |
 			0,
 		.per_vlan = 1,
 	},