From patchwork Tue Oct 18 05:17:08 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "John Daley (johndale)" X-Patchwork-Id: 16668 X-Patchwork-Delegate: bruce.richardson@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 4486F592F; Tue, 18 Oct 2016 07:17:12 +0200 (CEST) Received: from rcdn-iport-3.cisco.com (rcdn-iport-3.cisco.com [173.37.86.74]) by dpdk.org (Postfix) with ESMTP id DEAD32B94 for ; Tue, 18 Oct 2016 07:17:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=963; q=dns/txt; s=iport; t=1476767831; x=1477977431; h=from:to:cc:subject:date:message-id; bh=ZGV9JXt1swyHjNoIsRhrUfK3NjKe3mXd3mVVQ/+d+08=; b=OZc2qy/pltQq5h09cOBbC+F8Z2d3NHXbun6q5mIu/yepv1nVIMDIq3O3 mO/31lKiZtPIDZsRE00Cv3MIucDWuM70By8aprSqqpjJoWQM5vE3PTZQA j6YTPa3mYjxB2MIy58/pcsgNfOvWNVxm5JITIbTMt2z16FJh9L9W9WRUt 0=; X-IronPort-AV: E=Sophos;i="5.31,508,1473120000"; d="scan'208";a="163120407" Received: from alln-core-9.cisco.com ([173.36.13.129]) by rcdn-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 18 Oct 2016 05:17:10 +0000 Received: from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48]) by alln-core-9.cisco.com (8.14.5/8.14.5) with ESMTP id u9I5H9nZ031948; Tue, 18 Oct 2016 05:17:10 GMT Received: by cisco.com (Postfix, from userid 392789) id C33733FAAE5F; Mon, 17 Oct 2016 22:17:09 -0700 (PDT) From: John Daley To: bruce.richardson@intel.com Cc: dev@dpdk.org, John Daley Date: Mon, 17 Oct 2016 22:17:08 -0700 Message-Id: <20161018051708.25218-1-johndale@cisco.com> X-Mailer: git-send-email 2.10.0 Subject: [dpdk-dev] [PATCH] net/enic: fix fdir UDP v4 source port mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This fixes issue found by Coverity where a typo caused the flow director UDP IPv4 source port mask to be assigned the destination port mask supplied by the caller. Coverity issue: 137860 Fixes: dfbd6a9cb504 ("net/enic: extend flow director support for 1300 series") Signed-off-by: John Daley --- drivers/net/enic/enic_clsf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/enic/enic_clsf.c b/drivers/net/enic/enic_clsf.c index d2413d7..53a7977 100644 --- a/drivers/net/enic/enic_clsf.c +++ b/drivers/net/enic/enic_clsf.c @@ -155,7 +155,7 @@ copy_fltr_v2(struct filter_v2 *fltr, struct rte_eth_fdir_input *input, udp_val.src_port = input->flow.udp4_flow.src_port; } if (input->flow.udp4_flow.dst_port) { - udp_mask.src_port = masks->dst_port_mask; + udp_mask.dst_port = masks->dst_port_mask; udp_val.dst_port = input->flow.udp4_flow.dst_port; }