[dpdk-dev] net/virtio: add missing driver name

Message ID 1475845393-25670-1-git-send-email-david.marchand@6wind.com
State Accepted, archived
Delegated to: Yuanhan Liu
Headers show

Commit Message

David Marchand Oct. 7, 2016, 1:03 p.m.
The driver name has been lost with the eal rework.
Restore it.

Fixes: c830cb295411 ("drivers: use PCI registration macro")

Signed-off-by: David Marchand <david.marchand@6wind.com>
---
 drivers/net/virtio/virtio_ethdev.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Shreyansh Jain Oct. 7, 2016, 1:27 p.m. | #1
On Friday 07 October 2016 06:33 PM, David Marchand wrote:
> The driver name has been lost with the eal rework.
> Restore it.
>
> Fixes: c830cb295411 ("drivers: use PCI registration macro")
>
> Signed-off-by: David Marchand <david.marchand@6wind.com>
> ---
>  drivers/net/virtio/virtio_ethdev.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
> index b4dfc0a..809ebf7 100644
> --- a/drivers/net/virtio/virtio_ethdev.c
> +++ b/drivers/net/virtio/virtio_ethdev.c
> @@ -1304,6 +1304,9 @@ eth_virtio_dev_uninit(struct rte_eth_dev *eth_dev)
>
>  static struct eth_driver rte_virtio_pmd = {
>  	.pci_drv = {
> +		.driver = {
> +			.name = "net_virtio",
> +		},
>  		.id_table = pci_id_virtio_map,
>  		.drv_flags = RTE_PCI_DRV_DETACHABLE,
>  		.probe = rte_eth_dev_pci_probe,
>

Indeed. For MLX4/5 and Virtio, DRIVER_REGISTER_* is not being used which 
takes this 'name'. In this case, it was missed.

Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>
Yuanhan Liu Oct. 9, 2016, 6:42 a.m. | #2
On Fri, Oct 07, 2016 at 06:57:41PM +0530, Shreyansh Jain wrote:
> On Friday 07 October 2016 06:33 PM, David Marchand wrote:
> >The driver name has been lost with the eal rework.
> >Restore it.
> >
> >Fixes: c830cb295411 ("drivers: use PCI registration macro")
> >
> >Signed-off-by: David Marchand <david.marchand@6wind.com>
> >---
> > drivers/net/virtio/virtio_ethdev.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> >diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
> >index b4dfc0a..809ebf7 100644
> >--- a/drivers/net/virtio/virtio_ethdev.c
> >+++ b/drivers/net/virtio/virtio_ethdev.c
> >@@ -1304,6 +1304,9 @@ eth_virtio_dev_uninit(struct rte_eth_dev *eth_dev)
> >
> > static struct eth_driver rte_virtio_pmd = {
> > 	.pci_drv = {
> >+		.driver = {
> >+			.name = "net_virtio",
> >+		},
> > 		.id_table = pci_id_virtio_map,
> > 		.drv_flags = RTE_PCI_DRV_DETACHABLE,
> > 		.probe = rte_eth_dev_pci_probe,
> >
> 
> Indeed. For MLX4/5 and Virtio, DRIVER_REGISTER_* is not being used which
> takes this 'name'. In this case, it was missed.
> 
> Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>

Applied to dpdk-next-virtio.

Thanks.

	--yliu

Patch

diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index b4dfc0a..809ebf7 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -1304,6 +1304,9 @@  eth_virtio_dev_uninit(struct rte_eth_dev *eth_dev)
 
 static struct eth_driver rte_virtio_pmd = {
 	.pci_drv = {
+		.driver = {
+			.name = "net_virtio",
+		},
 		.id_table = pci_id_virtio_map,
 		.drv_flags = RTE_PCI_DRV_DETACHABLE,
 		.probe = rte_eth_dev_pci_probe,