[dpdk-dev] app/test: remove unnecessary conditional

Message ID 1474928000-35269-1-git-send-email-pablo.de.lara.guarch@intel.com
State Accepted, archived
Delegated to: Pablo de Lara Guarch
Headers show

Commit Message

De Lara Guarch, Pablo Sept. 26, 2016, 10:13 p.m.
Regardless the result of the conditional, the true and false
statements were the same, so the conditional can be removed.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 app/test/test_cryptodev.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Trahe, Fiona Sept. 27, 2016, 10:07 a.m. | #1
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Monday, September 26, 2016 11:13 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [dpdk-dev] [PATCH] app/test: remove unnecessary conditional
> 
> Regardless the result of the conditional, the true and false statements were
> the same, so the conditional can be removed.
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: <fiona.trahe@intel.com>
De Lara Guarch, Pablo Sept. 28, 2016, 12:13 a.m. | #2
> -----Original Message-----
> From: Trahe, Fiona
> Sent: Tuesday, September 27, 2016 3:07 AM
> To: De Lara Guarch, Pablo; dev@dpdk.org
> Cc: De Lara Guarch, Pablo; Trahe, Fiona
> Subject: RE: [dpdk-dev] [PATCH] app/test: remove unnecessary conditional
> 
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> > Sent: Monday, September 26, 2016 11:13 PM
> > To: dev@dpdk.org
> > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> > Subject: [dpdk-dev] [PATCH] app/test: remove unnecessary conditional
> >
> > Regardless the result of the conditional, the true and false statements were
> > the same, so the conditional can be removed.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> Acked-by: <fiona.trahe@intel.com>

Applied to dpdk-next-crypto.

Pablo

Patch

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index d744b37..514689d 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -341,10 +341,7 @@  ut_setup(void)
 	/* Reconfigure device to default parameters */
 	ts_params->conf.nb_queue_pairs = DEFAULT_NUM_QPS_PER_QAT_DEVICE;
 	ts_params->conf.socket_id = SOCKET_ID_ANY;
-	ts_params->conf.session_mp.nb_objs =
-			(gbl_cryptodev_type == RTE_CRYPTODEV_QAT_SYM_PMD) ?
-					DEFAULT_NUM_OPS_INFLIGHT :
-					DEFAULT_NUM_OPS_INFLIGHT;
+	ts_params->conf.session_mp.nb_objs = DEFAULT_NUM_OPS_INFLIGHT;
 
 	TEST_ASSERT_SUCCESS(rte_cryptodev_configure(ts_params->valid_devs[0],
 			&ts_params->conf),