From patchwork Wed Sep 21 20:54:27 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Karmarkar Suyash X-Patchwork-Id: 16008 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id D54475686; Wed, 21 Sep 2016 22:54:52 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0059.outbound.protection.outlook.com [104.47.36.59]) by dpdk.org (Postfix) with ESMTP id B77CA5680 for ; Wed, 21 Sep 2016 22:54:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SonusNetworks.onmicrosoft.com; s=selector1-sonusnet-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=uoHTBkurTzZySp+xysto3SI+/GaWRXYPkW8kjf0X/+U=; b=fA1brL0+pH3kFikZX1XLYuolC2jWaA2GlogDeYk1N+dn5GM2IDzLgMgN8rVYtCHJF+vxwJzYcMNOiaKRq2BjChyGG4yRE9xiw/XtfQKB+ku3baFNGRO0IIjMgN+/9erhVLMLIJsqZz82n9FrDx6tgFreEpluS9nz0TBITwmXMb4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=skarmarkar@sonusnet.com; Received: from SKARMARKAR-LMA.sonusnet.com (208.45.178.4) by CY1PR03MB1438.namprd03.prod.outlook.com (10.163.17.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.629.8; Wed, 21 Sep 2016 20:54:49 +0000 From: Karmarkar Suyash To: , , , CC: Karmarkar Suyash Date: Wed, 21 Sep 2016 16:54:27 -0400 Message-ID: <20160921205427.14116-1-skarmarkar@sonusnet.com> X-Mailer: git-send-email 2.9.3.windows.1 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [208.45.178.4] X-ClientProxiedBy: BN3PR0401CA0041.namprd04.prod.outlook.com (10.162.159.179) To CY1PR03MB1438.namprd03.prod.outlook.com (10.163.17.148) X-MS-Office365-Filtering-Correlation-Id: e3beafc2-e613-4585-98ee-08d3e2618723 X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB1438; 2:+ixB4mmjQdHNCnQvHssw6Eydv2jF3KPX8BGyxle+etCBQHaaRjOKJVw1/gayi4jFxuWS5gSsQFM4QE+NQalI4v87iTkYm2FuQTFXPGETWcfZHK7FdrttbghJekH/X9oyZkLbQiZo5SalXymzKdWWXbLrANJ+ae2/WWsmlLuZSH4zxz3FuECDiTtW3yqCWteA; 3:oUarp3cNZMVCjUAuaClIPmbKFz5oF9B1yW6IqATXxnDdlWeZFbaxczB18CKeYB4PDm0LrFBjVuLVUFoEWx6R2QOJZF0fG+wl/PMUJX/08mOb5+pX+6wb2waoq1lwGzTJ; 25:YJbbCdbqll8d8fzzeZm7XHloWtNbSqRRYKDdxYcyRXkywlszYuv+KiPGoYYUQepwpfWVbIEu1tUd5Rh7jkIPe50W8FvQEr7HNdqz6/zZn+9x+nrNcsrX0wjCYnjJpKxAmqAW55SZX+JbXFAd3hUApUZtWu41liS6RHW5+OV9bdV/PGiXypsnBf1KD+zgEZXcK6wBr83IuiKLR/puqHFaEguZH/8l8FSAdhR0LYwF4iQ26K6KJTsFmGmgYz+9AtgTxEYAjKFAB/2C7XW8JLhvu9sV4DFbqRK4ysy2U2q8zAQKa26JkBaLYbkNh9ALgfBTXHol5sAWG02W1PGrPwfCLXafov3tApVUo0dOf9PdKIaYkCkpCB1cCu9RpiE2ESIMP2wXeXr8yiwgQpKjFL8PJ1FfMc2Xninrehlx9V5XLfs= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1438; X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB1438; 31:05WZrIaWRGuP5/+q7sLvQrm7z0wcdOb5rgzTg9C/ToJP2SSUEHa04jDCETshAWbp2ZD6eBpw3Q1j2ISpw/wliEfpe7pE9L3ZOCIEXa9pYz+k6DE0kMDQdoIflz0FVUolYtPYdR6FjwI5LHYN3zgZ7Bg0jLR83zwghfk8Ha9xR6CvF+XIMp1H5zxZSvdK7i2ZzH8HSNUuuKnMDzisZFo4D7K0dw61PU9t8jgeY9CR/Y0=; 20:PZP44yzea8c/otfuhj/h4ku/C4/nWbyo60HWMCZIpqvevgRHPpXVczUWrCzOLXYDx8Q8EgehsG9NDheR95p53ZxuPKErTrZlb2IwPYwKMbNb3P4v8aVlCuQCRX2midaHzJloKeH5BjvmhQnd6aImy1IROhJGqZbFbYIBIQhlRSbgZHs+wyEvq6Gm3ltbbSNY0b/fzHSd3duAkejQlQSplytdzcYmSz7fNxioyC8zkxhbcCZAzkCBeOe0eLkNEBhr6sK6Q2frHv+5qJvvior7LwBfr/NktGyBWSNB+a/FDOmiEPCqRqecsg6zwMyaU4IkMvSnKK4owovYdMkYT3EfvZXDkl3eYo6Ox/p6qX2nExHvlRuMtiQXbgO6ABUhPPolBtXcRSfMCYoENHYN8YHeUUOPibc8xXhADdmTzRAoulMLbAw8nb6anFSUWLKqHR+gEpoTlzicsmL4J34SMVJdRp1EJj02z4SG2yCWVKwrnCJL+bUJe/BihZvUnWmgZqVW X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001); SRVR:CY1PR03MB1438; BCL:0; PCL:0; RULEID:; SRVR:CY1PR03MB1438; X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB1438; 4:wBNe1WBORsbOLl5NH9yXun0It8qXd/H2NdDNeoB8PADalPSmAZMvmNlX1I/GYnOacKojNiDpMPqjRD/rtfKFSiKJu5XT+2cuNisQt1ndNga7yX8fwXRBq8qo0WgJ1uKGHkHOzRWJz654i+Zkv+z8SJMJcnX198sqzf2e1TRrC7QLLn7xzBXcvKBlySLZyxv6LNPXGFZOuweX6yr/e7VUPXYkWB/5NNp4jGQuzxTVL8JgYZYAHV2OkhLhW9XRdVqsSewyc9bymm00BhZPAAu0oYDABuQH06cxgTKyqYuWZaRU0Vj+FRSYmUvS5f8RqQJ++sawMUH65WltrbZJ4nfA503zIRKDtkhlot5j42rsKdvzH//TGiZtLnxwqK6Y7qrXdY8YVWYa1+WG3sAXMh/Qkw== X-Forefront-PRVS: 007271867D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(7916002)(199003)(189002)(189998001)(19580405001)(7736002)(5001770100001)(33646002)(19580395003)(7846002)(53416004)(50466002)(36756003)(5003940100001)(48376002)(586003)(3846002)(97736004)(101416001)(2950100001)(6116002)(107886002)(2906002)(1076002)(68736007)(2201001)(50226002)(106356001)(66066001)(4326007)(86362001)(92566002)(69596002)(8676002)(76176999)(50986999)(42186005)(229853001)(77096005)(5660300001)(81156014)(4001430100002)(81166006)(305945005)(47776003)(105586002)(2101003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR03MB1438; H:SKARMARKAR-LMA.sonusnet.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: sonusnet.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR03MB1438; 23:8SqQNe2qDTLy8zOB+jgGsuw/bC+0M3plZ+ztheNGf?= =?us-ascii?Q?on83zrKd1h3tr4p9vJFf9JnvOZ4cJcozrVXYu7n603lVXF4nM0S1MZkw8/2u?= =?us-ascii?Q?vHZ76BggOSePINHgUow9iV96w/JKFEbQUelMlSyR9Ul1mjyF3NtXzCaxyK2i?= =?us-ascii?Q?ZI65BRuSNJeYbsWq+wXcDwkgd6k6YNXXL0b3dwVXDUraQRFuIKHHOz8n6auP?= =?us-ascii?Q?ON0r81A/g9hPMJVL7JrSkoJhswjYIW2Bv2W2cmvqE8x7eRAiebLBYYaS0/Iy?= =?us-ascii?Q?w7sUJ6Q2jhgenXQdEcffUaPUjmtdwr4BBW9uzRS3Blkxb3JpZKeMyDXapaWa?= =?us-ascii?Q?ks/guhYou8VBnsBTfsnm+cn97L5OZn1lUyaVep2YHaDPjPzQ1yFJlOEirQFq?= =?us-ascii?Q?KUDqS1Q91+i8OGqKZ2Bgl3LVP1C4+tily9eqzzjoGiEEGLxQYU1gTzqcy6yw?= =?us-ascii?Q?+K/4gCTfdy/16aIxQGADdtZc//44SD3N79uGAIB0j39gHi44i9+1BkWbC+qP?= =?us-ascii?Q?gMxk/6aokjPbQ5GCexEeuHLxHPR1PuWpnTP/KJ0WATGSCiQVVWKb3KN80OqN?= =?us-ascii?Q?4+e3MLbUYrMo2ktEH9j3OByMMYaU4oXBFbxIdWjBd7i0ZN5OYPBATA9FeUYk?= =?us-ascii?Q?VaWsodR9l/HIzh48hHqDAgjMKaKGSiu/uCWNr+duPInUYOZEdSRkpbPW/iOA?= =?us-ascii?Q?gU6ESBsA2tkQaTkjbZO/50xTxy/PLPVVkxVxaLKI9+su73YegVSPgIa8UGHO?= =?us-ascii?Q?GwI1COOWuie2Ms6ZSaPXq1X8RsWr5QjfbiXm/zQXT/GllHPYYRtSYqnCtG+M?= =?us-ascii?Q?yTn8Cnr8S5eKGRW0r0xqj0cUN8dWF+6Pcmlu9oBTjEgdk2cVJ08+3fHcsVnf?= =?us-ascii?Q?6o4VfRflDUcY8aAcVHJBeoj1j5AWYznbDex2yWnV61VppFkuk3scnBQLuYTK?= =?us-ascii?Q?u+Tu7Bq5Lbena1le0sYejSO9Nt3C9sEzhXV5yw9FvNp7V6rdeYVvTU5BRYkk?= =?us-ascii?Q?D4H6ehjB+Db+YRfWnOaUQ1ncIYj05e8uT8x0xrA2tYbV1tOSD9YNJCvOESc7?= =?us-ascii?Q?VdihR/FZQpf9EOVZPdeacaHITYp9N3/ja0jIwGU0lLRI+CkB+CghG8fp51mV?= =?us-ascii?Q?RMKRzC4x21HazaSQvgqqnAg17JAbxVGIgX4MbgfRg9c3FRYKDjj78/6tarDl?= =?us-ascii?Q?MKUcY5Pk4TUU+/zCmyTbErQ5Q2gJfhb8AQl?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB1438; 6:Gw2crt8G/+zj5reU9MBO9ofUjEAl5QmNRpJkKbaUNvvecRmDh/63isrB7rqV+7gJS9ExCI7VkaNLnvd+wqiChRP0zMuNvWxDCEmEWZ5Cd2eiJQ+dTcEJ1UpEzEgy75GUD6P4LpEP8WPP3rVB4N8ia55QedJBLqvldAyVTeyV1XWsuXT35v3px6Y8CLOxb5qsypUPmn1I1fbU15SBE8DzC7OgbauFN/5jx9ZYgvNr6BCHtcm8plbWVd4Gd9YO2H+vv69V6tqYfVxJqcqlxKETS6ws4HtOwBTgr54m7AH0hHA=; 5:1jD87qxPYppa7YTTKGAJmo20gw38+ZoWJNSvHgXX+IxIyF+Hrm6fpmjsxJW5SIJ9kv6afPdQ7c4voQH1/1QriPYR5qoeh5LxAzZm/G25sIkwfRm2R1ezgeCc3uekPtJ2/s7vbr4TUcprN+g3ijCzxQ==; 24:ROKd5bUVlod3YS9F5wnF1rLH6bMB43DdsaMYjPumHK3Rrg8TGk6a3ozwsLKMzwgXpDAdZrP5hedfggRvVvorN/f+/7NT+ATKlsoL7sMwUjw=; 7:4Z3PN2smrQwh2ash+SH0fp7mYKlO/8Lx0rv1Y19d4lP3+cSbv/3iozvJH4V5UTS8byGkk3np+ncNx2/AXdUWrwxvfAaqq95PplR86kCVJQdK28ZYsnqOEiN1jDh5qqdE3bS5Bicubp8f3ksqrJZcS2soZ4TZNGS8E+YaLmomBAzgMQB58zeDVTbhgRee8elkDGkcUzf6X+kRMkFXzymD0XNsFvOSBFmPhSeHeELWlKemuTo1hBI1GG5Vlmi8qDflqnAfIAycnPZcQ3D0EZ07oRN+3KZjvfj2JADKriK69ObQ37CZKik1FV7myE9ntUyF SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: sonusnet.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2016 20:54:49.1299 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1438 Subject: [dpdk-dev] [PATCH v2]:rte_timer:timer lag issue correction X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" For Periodic timers ,if the lag gets introduced, the current code added additional delay when the next peridoc timer was initialized by not taking into account the delay added, with this fix the code would start the next occurrence of timer keeping in account the lag added.Corrected the behavior. Fixes: 9b15ba89 ("timer: use a skip list") Karmarkar Suyash (1): Signed-off-by: Karmarkar Suyash lib/librte_timer/rte_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- lib/librte_timer/rte_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c index 43da836..18782fa 100644 --- a/lib/librte_timer/rte_timer.c +++ b/lib/librte_timer/rte_timer.c @@ -613,7 +613,7 @@ void rte_timer_manage(void) status.owner = (int16_t)lcore_id; rte_wmb(); tim->status.u32 = status.u32; - __rte_timer_reset(tim, cur_time + tim->period, + __rte_timer_reset(tim, tim->expire + tim->period, tim->period, lcore_id, tim->f, tim->arg, 1); rte_spinlock_unlock(&priv_timer[lcore_id].list_lock); }