From patchwork Wed Sep 7 03:21:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: souvikdey33 X-Patchwork-Id: 15630 X-Patchwork-Delegate: yuanhan.liu@linux.intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 05C746CC4; Wed, 7 Sep 2016 05:22:35 +0200 (CEST) Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0075.outbound.protection.outlook.com [104.47.33.75]) by dpdk.org (Postfix) with ESMTP id 81F3B6936 for ; Wed, 7 Sep 2016 05:22:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SonusNetworks.onmicrosoft.com; s=selector1-sonusnet-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=PRatDdE3Yh+OvnPPXCZ8K/PckcNxrbiJDBysfNZO5to=; b=efVF1zId2IMgSmNBa3VvRlV2TYL/vXwT1LkoHaK1XHFmsAQouhlDGSOjDjaDOkxykfHe/VefzUV2FIcNGMijjVFItwQmw4wWbZiIj9lZdmbJTgFnR1xOMvU07z6KY7tbNRzjenu5tAMsUHILOYIC3GsRdz8lZYjDWfGCphu5AyY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=sodey@sonusnet.com; Received: from SODEY-LMA.sonusnet.com (66.30.138.194) by BY1PR03MB1497.namprd03.prod.outlook.com (10.162.210.143) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.587.9; Wed, 7 Sep 2016 03:22:29 +0000 From: souvikdey33 To: , CC: souvikdey33 Date: Tue, 6 Sep 2016 23:21:56 -0400 Message-ID: <20160907032156.34492-1-sodey@sonusnet.com> X-Mailer: git-send-email 2.9.3.windows.1 MIME-Version: 1.0 X-Originating-IP: [66.30.138.194] X-ClientProxiedBy: BN3PR0401CA0006.namprd04.prod.outlook.com (10.162.159.144) To BY1PR03MB1497.namprd03.prod.outlook.com (10.162.210.143) X-MS-Office365-Filtering-Correlation-Id: 2291c609-56ec-41f6-a2d7-08d3d6ce3377 X-Microsoft-Exchange-Diagnostics: 1; BY1PR03MB1497; 2:vFqkQd1Jz7uFJF/HnMwtSwQJhc+knsQgpl+rKJTuFhHIyMTb5GBHUti2HLIEzLuuf608tOpO3APcsEkXwr88VjjWqttL5GyhdjzJVa/Xj6YGm/qRqIu5/FbpouR9RsNar1R9rP62oc+GvsqGfiBHHcYRqnah3b9teHumt5ZV8BphjttZnj2dpSX2bRuHJoyW; 3:4dCSWsQwPBbgXqsHAaIi9xNzheBuZgIRewsJsfnVREcbEmPWtMZoxOr5juJth3svNArR0g8DptT2VqfRHO89vHMFskZALP5jRClcSHEeDn7/kats5qmMf0xGksedM0Zv X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1497; X-Microsoft-Exchange-Diagnostics: 1; BY1PR03MB1497; 25:46ojSunvmDVVt6ONZQJqoqlkPj22JuKlT9VLPAc/D0VhuDcBtIV7YXmjNl+jBdOm5/essWrHgjmVdGvAMScG3ZibeqXkvg8WmMrDzTZiTF3960eqJNrWrtpVqg3caz8xhX2BwnrLYiNRHMuT/0niTHeeu6wA3UJcqbthoNLG+mHZSMlu8guJv491AwwOBN/Tlb4kT+GbgxA/shs6y7fmH2nRK9yfSAi46ZSZKIYPK+nK11UgwgDa041tsjHyeRIm55WiSNjXYSBPwvCD/wQIl+rRDZGewPaOQHeHFWqkPwLJXlLhqHOxZuE65+Xe4itdh5P8ph4uaRmfvH18IHcK7J6wl0El0dP8WZhkRptgaOqw501u6JrgDXGoJ1ji3vi5XIEzlpM1agLaPVqYq6eUo1XR7kSMvMFzx9OI+VIPdEMKJEFAFrzvSdlP5vby4FIJNvG/qb2rmnoms4IAP6nJjX/1TM0WmWJKFoz9JuqxDqRJYGX8ciZ22a9WM1/mRkRqoTUPQhetyBYlrVz+aaS99i3kjc6MTQ9d3SLQAsqiY6MpBNbuthzVFLF4eKu/v+NDQrunqU8h5tnEbRtDH2ZCqK1bXSv5EO0V840wTQ38sk8CCfYC79JUkD592ln1iW7JS1OFD0rtMNDJgYLuT5Jr0NIZaAmyR/tmOZVJH78phcUVzfho/huvA2L66vZDErho; 31:z1M53DResvaWXagqhWSft9K56Mglc8XyEhsnD2k9s3/GCwi0kolIYKLE0/GsAnOYmq4MagZURlH9FZlcip/X/RFKDxwGni0C3CbmDyaMMK+vVTWSgSmqtXuNnn59ywRf+aCsrtE6IJ5OZEGyyAhgMATXeFAFqX1w4IP/uDd6uAEZdXFF9ALp9gWPcMt+ZESWpwUpU72EFrWezZ4woYE4qEnFqHvKiI6rdJV23A9rkBg= X-Microsoft-Exchange-Diagnostics: 1; BY1PR03MB1497; 20:icbxiwtvxRf3FmHuMeFIjA9RAoqGwPoeJMR6uEnJNwbJ0pAxXfq0EsVVJj1PaCjTuPAGfxvqI15MMgjEPuafSjRbofFXAd7kXN/odJnE8/GB45qldS/tG/vR/2kHDrRm2tkzVkKCS2rpn92nl5RZueX+01mmL40cddUY+lGC2GH0mEEC5jPBGVHxgWV2rlOCZltPqTRfoJID7Wqv4c54YrBC2qhssag64fEjMwzBSVY8+MaTU7XyrK/ya+NbNCIbX7iWik0TexKARerasoxju4v08XTQWYFgqC0O514kl/nZ2yNsOq4JRTGnSqMJuWy3aiTtnYmZpJt1AW6jph4vZ4XyasXvjlrRhWQgS7Gq6QN4XS+o23BO4Yh8jN/FWljuwG6CZ8sNP4VXstwaI9jAS5xz7Fr8LtbyQPE3BDoYXlIcRXcLNm6Pq9cDede0iy5D6viwf3p9chM4zDSNU0f4h6LUKYWLD7pEHJxy42Dn0fZEmMn80XY7vRqq5kUscjVX; 4:FOm0tuRawuMMLiMjAzLz6GWNDjGgLWz5CB+A7dDfjrGJrbWPedIxBRjsbPzg5yxwOaYmhJ0xzfPMxW/zhMPH+MtoUIGXQYiS4ib2yWl8441kWKDDOE4P7jyr1+2fMNscLYx8QwVcWy+cstGe0S1YAZjmEPcrmoOpGqlGyXKPamH84gXlTUv0PcLv5Ml5lpA0yQhwz4+TWPj5dGR95ZpW0rbZTeJxKFgD2jZVsPUkB1BEzjFnM0LAUj1zoM0ZMiUreiTZBOoEUf2NXt8008tRZGLjJjXKgouGaqRuUUXAOIpa0AepB8s+j8FUJfZ18ja+Rry1fFzjvzEooXh++njk0qD8eeYAjiAjxuAETHHrNSqwL586qFI+BJySez4BcysyMjZb0xVGsAtPadVHeAo+cB84zOYlj0ACPF1UTI0J82KQOyMl/7pvqEfI79xwgNc6 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(158342451672863); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046); SRVR:BY1PR03MB1497; BCL:0; PCL:0; RULEID:; SRVR:BY1PR03MB1497; X-Forefront-PRVS: 0058ABBBC7 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(7916002)(199003)(189002)(19580395003)(1076002)(66066001)(3846002)(5001770100001)(229853001)(36756003)(2906002)(97736004)(33646002)(19580405001)(48376002)(586003)(106356001)(47776003)(8676002)(4001430100002)(81156014)(86152002)(101416001)(81166006)(6116002)(69596002)(50466002)(105586002)(68736007)(92566002)(4326007)(107886002)(77096005)(189998001)(305945005)(5003940100001)(53416004)(86362001)(7846002)(7736002)(42186005)(5660300001)(50986999)(50226002)(43062003); DIR:OUT; SFP:1101; SCL:1; SRVR:BY1PR03MB1497; H:SODEY-LMA.sonusnet.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: sonusnet.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY1PR03MB1497; 23:YlFCpryDVXcrxsfA0ovkFKLbTG1w86HuYUNkSdovx?= =?us-ascii?Q?IA5ozcCF2Ms0JlD9AcMKBDvouKNvMFZhsPD0xMYGz8vW92ut/m/Q05Kjv7oA?= =?us-ascii?Q?c/K0doO1ZZE9kr5lARXcK3oJ50JN8moLW0uSOBAwAA0Q8Ida8aSo6GWZJH5q?= =?us-ascii?Q?oOtoEznjUjclV3+2Ikczf6X7UCL7UCcXTYRx8sJmYiiC3upWeQPh/lsbzz6T?= =?us-ascii?Q?O1Lxdk4ikGgqZ2DI0WmAfWf9A9JlO2Vfrmm6UR8FRRMCzwGzV7aAu4Djn8y3?= =?us-ascii?Q?FGXzQeOfUnoBI1HERFJVIP1jFztSJ1Phrke571PfPhQKge1ngsnToCquPgjQ?= =?us-ascii?Q?tPz/kCraPqOijRoOQXc1LqtX9UtA1lTzGvvP+IgUQUSPcTrAjPtTXVzcFmqG?= =?us-ascii?Q?8V8WNK0//yY8lZqGOgDly+Eos22b2xANKVQkjszB3iSy0UvoiF0w1JUTARD6?= =?us-ascii?Q?LKJpKqVEx69AleW8SzR8/Rr4g1lcU2ReFTOWZ1j1P1yPU4xq9hOMTS7A34J+?= =?us-ascii?Q?6fmanO6ZjesEus6yH8PPM7FaI9kb1Swj7zh55tckdAPIC4a7kluNH2SfQpb4?= =?us-ascii?Q?+VvthbbUbquT5qBQtW9COC/5094aFs2WUtGF+yYCd8E9OftbiU0M16mCR6Sl?= =?us-ascii?Q?sK2ycc75TkjIGWo+n8Z/g84Ku/GRl6ZYvBkqLjdvc8MU3M0wTPTdbEr0BY84?= =?us-ascii?Q?Xn1QXmqu+THIxfCXQmdPAjEpcHe0PkyMq2APyrTNcdSQkhxxafwnUsr1lhrr?= =?us-ascii?Q?af1Siox1f9LpoQzsjGt+7iiEaMYPkvpar+QCRl5h9FF9HU5XsxTcNoMvjUDQ?= =?us-ascii?Q?Zv+xJ0xiqsd2tXMhsAh54MLOSWMRAYNedInQuM2GDKF71tOJ7l9nE+ihkIoe?= =?us-ascii?Q?sLC22tLZQsRb9s0emrZGPIWR/jVpiY9CbA+ZrqE1ztTLs/Ul5EtrHCjBI75E?= =?us-ascii?Q?PwM7vviWZRRSQNgvNUELh2gJ9yf+r8NUAIKpXCHQwfst2FYJm3psrCcaawfa?= =?us-ascii?Q?oDjW4WGZgP7GYE2AcL5X8WzvX69KiNPwB6LBBbOBpVkGzL9/bJV70k+h//2/?= =?us-ascii?Q?U+CxoXHjzyV0PcJWu3c1MTBgaOiJd9VcSso9wgyu2LnagUgJlDYkHUojtEyA?= =?us-ascii?Q?j0ljTegrtbY70OFjhYbqD5anaoBF1bVWQ/9HePQgudaUTG4VqZ/0A=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY1PR03MB1497; 6:9bEKm5f4MSGyuYVDTYLBIFRE5lUQRbu+ZBgRTKyLtGn6be3JCUHkCWfZcVmo2/lotK9HH7um7kZfkysBOPDK5wMo/JUdWu22AJNBvoyjTF6GAkCPw3BtRICdvMI8364g65UDW1/BwIrO6k/fEaTRcOFyyN0tuL+ROMuJNP6gR36BzzER0ZF0EuRB43hjAZQz5DSOE8Y0oT9beAIcWEvx9teu5O8q3higofVeW4apQatkElHeppEPsmN2mq2iafi007TYh5lkk+tBxHAJHgFq/TFfKECgwOwcIHrdCzc7sG4=; 5:GTmAJlkh2vhtPCUSK7Wk7o6y0Uc4s/aLC/YM33i9EbDHhWSCiZhaQoYajPvePF1SFAA44LTh5INmh99HFtJ1RFwlVoIcuoTRYyXUMBl7ksQ6OlFOaNsg2BUEsCnZMIAkmilfPupfBYQZLy08JwxtFw==; 24:p2WsEN9EafXm+vbsvYBABXia6e02cxA7Ysf6YJV8144qt04lk5XsQK8W3OwdPRbZvgr6nykdfEcy+oPAXLkI4ORYNHl9d8C+PdymDC6WRSc=; 7:9ndofA+KObndX/WMdh+B835cVIVkPGpvDidziq3AcRdJL/lNQH9mg3MbWHiMQ6/C/qOHKqQ8+6QqZNnPAzpv63qq5z8Ck/Toaff40VxcK1BSU3o+KDqtPnaLccA//eWCQY7G0x0+NSXZTQUEdvmmGc4KRywbzh61XqQNDXMbl8TrAraONGYuaZxxYzY0zD+q3sPYDyEo0Pp9JMZhDfPhQrfOPUdZncUCPr7d2QBTbYCgFSoZzqVx6npzuotGAY82 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: sonusnet.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2016 03:22:29.9457 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1497 Subject: [dpdk-dev] [PATCH v3]virtio:add mtu set in virtio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: Souvik Dey Fixes: 1fb8e8896ca8 ("Signed-off-by: Souvik Dey ") Reviewed-by: Stephen Hemminger Virtio interfaces should also support setting of mtu, as in case of cloud it is expected to have the consistent mtu across the infrastructure that the dhcp server sends and not hardcoded to 1500(default). --- Corrected few style errors as reported by sys-stv. drivers/net/virtio/virtio_ethdev.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 07d6449..da16ad4 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -92,6 +92,7 @@ static void virtio_mac_addr_add(struct rte_eth_dev *dev, static void virtio_mac_addr_remove(struct rte_eth_dev *dev, uint32_t index); static void virtio_mac_addr_set(struct rte_eth_dev *dev, struct ether_addr *mac_addr); +static int virtio_mtu_set(struct rte_eth_dev *dev, uint16_t mtu); static int virtio_dev_queue_stats_mapping_set( __rte_unused struct rte_eth_dev *eth_dev, @@ -652,6 +653,16 @@ virtio_dev_allmulticast_disable(struct rte_eth_dev *dev) PMD_INIT_LOG(ERR, "Failed to disable allmulticast"); } +static int +virtio_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) +{ + struct virtio_hw *hw = dev->data->dev_private; + if (mtu < VIRTIO_MIN_RX_BUFSIZE || mtu > VIRTIO_MAX_RX_PKTLEN) { + PMD_INIT_LOG(ERR, "Mtu should be between 64 and 9728\n"); + return -EINVAL; + } + return 0; +} + /* * dev_ops for virtio, bare necessities for basic operation */ @@ -664,6 +675,7 @@ static const struct eth_dev_ops virtio_eth_dev_ops = { .promiscuous_disable = virtio_dev_promiscuous_disable, .allmulticast_enable = virtio_dev_allmulticast_enable, .allmulticast_disable = virtio_dev_allmulticast_disable, + .mtu_set = virtio_mtu_set, .dev_infos_get = virtio_dev_info_get, .stats_get = virtio_dev_stats_get,