| Message ID | 1466067875-165380-1-git-send-email-jasvinder.singh@intel.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Thomas Monjalon |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id E6350C5A4; Thu, 16 Jun 2016 10:57:17 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 95070C57C for <dev@dpdk.org>; Thu, 16 Jun 2016 10:57:16 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 16 Jun 2016 01:57:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,478,1459839600"; d="scan'208";a="988623255" Received: from sie-lab-212-251.ir.intel.com (HELO silpixa00381635.ir.intel.com) ([10.237.212.251]) by fmsmga001.fm.intel.com with ESMTP; 16 Jun 2016 01:57:14 -0700 From: Jasvinder Singh <jasvinder.singh@intel.com> To: dev@dpdk.org Cc: cristian.dumitrescu@intel.com Date: Thu, 16 Jun 2016 10:04:35 +0100 Message-Id: <1466067875-165380-1-git-send-email-jasvinder.singh@intel.com> X-Mailer: git-send-email 2.5.5 Subject: [dpdk-dev] [PATCH] ip_pipeline: fix parsing error in TM port section X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Jasvinder Singh
June 16, 2016, 9:04 a.m. UTC
Replace APP_PARAM_ADD_LINK_FOR_TXQ with APP_PARAM_ADD_LINK_FOR_TM macro
in TM (Traffic Manager) port section parsing function. This macro adds
nic ports entry specified in TM port section of the application
configuration file to the application parameters structure.
Fixes: e5a1cd8a4847 ("examples/ip_pipeline: clean up configuration parser")
Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
examples/ip_pipeline/config_parse.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
2016-06-16 10:04, Jasvinder Singh: > Replace APP_PARAM_ADD_LINK_FOR_TXQ with APP_PARAM_ADD_LINK_FOR_TM macro > in TM (Traffic Manager) port section parsing function. This macro adds > nic ports entry specified in TM port section of the application > configuration file to the application parameters structure. > > Fixes: e5a1cd8a4847 ("examples/ip_pipeline: clean up configuration parser") > > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com> > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com> Already fixed in 81d084dd2aa8 ("examples/ip_pipeline: support KNI") Cristian, you should not ack a patch which do more than announced in the title. This pipeline KNI patch do a lot of things without any explanation for the fixes. 1 explanation = 1 patch
> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, June 21, 2016 9:49 PM > To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com> > Cc: dev@dpdk.org; Singh, Jasvinder <jasvinder.singh@intel.com> > Subject: Re: [dpdk-dev] [PATCH] ip_pipeline: fix parsing error in TM port > section > > 2016-06-16 10:04, Jasvinder Singh: > > Replace APP_PARAM_ADD_LINK_FOR_TXQ with > APP_PARAM_ADD_LINK_FOR_TM macro > > in TM (Traffic Manager) port section parsing function. This macro adds > > nic ports entry specified in TM port section of the application > > configuration file to the application parameters structure. > > > > Fixes: e5a1cd8a4847 ("examples/ip_pipeline: clean up configuration > parser") > > > > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com> > > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com> > > Already fixed in 81d084dd2aa8 ("examples/ip_pipeline: support KNI") > > Cristian, you should not ack a patch which do more than announced in > the title. This pipeline KNI patch do a lot of things without any > explanation for the fixes. > 1 explanation = 1 patch Yeah, there were several small issues to fix and several people spotted them at the same time. I agree we should do a better job at separating different fixes into different patches. Sorry about this.
> -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jasvinder Singh > Sent: Thursday, June 16, 2016 10:05 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com> > Subject: [dpdk-dev] [PATCH] ip_pipeline: fix parsing error in TM port section > > Replace APP_PARAM_ADD_LINK_FOR_TXQ with > APP_PARAM_ADD_LINK_FOR_TM macro in TM (Traffic Manager) port > section parsing function. This macro adds nic ports entry specified in TM port > section of the application configuration file to the application parameters > structure. > > Fixes: e5a1cd8a4847 ("examples/ip_pipeline: clean up configuration parser") > > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com> > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com> > --- > examples/ip_pipeline/config_parse.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/examples/ip_pipeline/config_parse.c > b/examples/ip_pipeline/config_parse.c > index 504018e..5e70d78 100644 Self-NACK ; fix applied by another patch.
diff --git a/examples/ip_pipeline/config_parse.c b/examples/ip_pipeline/config_parse.c index 504018e..5e70d78 100644 --- a/examples/ip_pipeline/config_parse.c +++ b/examples/ip_pipeline/config_parse.c @@ -1816,7 +1816,7 @@ parse_tm(struct app_params *app, param = &app->tm_params[param_idx]; PARSE_CHECK_DUPLICATE_SECTION(param); - APP_PARAM_ADD_LINK_FOR_TXQ(app, section_name); + APP_PARAM_ADD_LINK_FOR_TM(app, section_name); for (i = 0; i < n_entries; i++) { struct rte_cfgfile_entry *ent = &entries[i];