| Message ID | 20200911120906.45995-1-joyce.kong@arm.com (mailing list archive) |
|---|---|
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C1F0A04B5; Fri, 11 Sep 2020 14:09:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 742A11B9B7; Fri, 11 Sep 2020 14:09:18 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by dpdk.org (Postfix) with ESMTP id 3B6141B75C for <dev@dpdk.org>; Fri, 11 Sep 2020 14:09:17 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9ED6D113E; Fri, 11 Sep 2020 05:09:16 -0700 (PDT) Received: from net-arm-thunderx2-03.shanghai.arm.com (net-arm-thunderx2-03.shanghai.arm.com [10.169.210.123]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1FF593F68F; Fri, 11 Sep 2020 05:09:13 -0700 (PDT) From: Joyce Kong <joyce.kong@arm.com> To: maxime.coquelin@redhat.com Cc: jerinj@marvell.com, dev@dpdk.org, nd@arm.com, honnappa.nagarahalli@arm.com, ruifeng.wang@arm.com, phil.yang@arm.com Date: Fri, 11 Sep 2020 20:09:03 +0800 Message-Id: <20200911120906.45995-1-joyce.kong@arm.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [RFC 0/3] Vectorize packed ring RX path with NEON X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series |
Vectorize packed ring RX path with NEON
|
|
Message
Joyce Kong
Sept. 11, 2020, 12:09 p.m. UTC
This patch set introduced vectorized RX path for packed ring with NEON. Joyce Kong (3): net/virtio: move AVX based Rx and Tx code to separate file net/virtio: add vectorized packed ring Rx NEON path net/virtio: add election for packed vector Rx NEON path doc/guides/nics/virtio.rst | 4 +- drivers/net/virtio/meson.build | 2 + drivers/net/virtio/virtio_ethdev.c | 19 +- drivers/net/virtio/virtio_rxtx.c | 7 +- drivers/net/virtio/virtio_rxtx_packed.c | 37 +++ drivers/net/virtio/virtio_rxtx_packed.h | 300 +++++++++++++++++++ drivers/net/virtio/virtio_rxtx_packed_avx.c | 264 +--------------- drivers/net/virtio/virtio_rxtx_packed_neon.c | 202 +++++++++++++ drivers/net/virtio/virtio_user_ethdev.c | 2 + 9 files changed, 566 insertions(+), 271 deletions(-) create mode 100644 drivers/net/virtio/virtio_rxtx_packed.c create mode 100644 drivers/net/virtio/virtio_rxtx_packed.h create mode 100644 drivers/net/virtio/virtio_rxtx_packed_neon.c
Comments
Hi Joyce, On 9/11/20 2:09 PM, Joyce Kong wrote: > This patch set introduced vectorized RX path for packed ring > with NEON. Overall, the series looks good. I will have to trust you on the NEON implementation. Ideally, having a detailed review from someone from ARM would be good. Could you please send a new revision with the build issues reported by Intel CI fixed? http://mails.dpdk.org/archives/test-report/2020-September/152501.html Thanks, Maxime > Joyce Kong (3): > net/virtio: move AVX based Rx and Tx code to separate file > net/virtio: add vectorized packed ring Rx NEON path > net/virtio: add election for packed vector Rx NEON path > > doc/guides/nics/virtio.rst | 4 +- > drivers/net/virtio/meson.build | 2 + > drivers/net/virtio/virtio_ethdev.c | 19 +- > drivers/net/virtio/virtio_rxtx.c | 7 +- > drivers/net/virtio/virtio_rxtx_packed.c | 37 +++ > drivers/net/virtio/virtio_rxtx_packed.h | 300 +++++++++++++++++++ > drivers/net/virtio/virtio_rxtx_packed_avx.c | 264 +--------------- > drivers/net/virtio/virtio_rxtx_packed_neon.c | 202 +++++++++++++ > drivers/net/virtio/virtio_user_ethdev.c | 2 + > 9 files changed, 566 insertions(+), 271 deletions(-) > create mode 100644 drivers/net/virtio/virtio_rxtx_packed.c > create mode 100644 drivers/net/virtio/virtio_rxtx_packed.h > create mode 100644 drivers/net/virtio/virtio_rxtx_packed_neon.c >
Hi Maxime, > -----Original Message----- > From: Maxime Coquelin <maxime.coquelin@redhat.com> > Sent: Monday, October 5, 2020 3:34 PM > To: Joyce Kong <Joyce.Kong@arm.com> > Cc: jerinj@marvell.com; dev@dpdk.org; nd <nd@arm.com>; Honnappa > Nagarahalli <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang > <Ruifeng.Wang@arm.com>; Phil Yang <Phil.Yang@arm.com> > Subject: Re: [RFC 0/3] Vectorize packed ring RX path with NEON > > Hi Joyce, > > On 9/11/20 2:09 PM, Joyce Kong wrote: > > This patch set introduced vectorized RX path for packed ring with > > NEON. > > Overall, the series looks good. I will have to trust you on the NEON > implementation. Ideally, having a detailed review from someone from ARM > would be good. > > Could you please send a new revision with the build issues reported by Intel > CI fixed? > > http://mails.dpdk.org/archives/test-report/2020-September/152501.html > > Thanks, > Maxime > Thanks for your comments, and I will send the new revision soon. > > > Joyce Kong (3): > > net/virtio: move AVX based Rx and Tx code to separate file > > net/virtio: add vectorized packed ring Rx NEON path > > net/virtio: add election for packed vector Rx NEON path > > > > doc/guides/nics/virtio.rst | 4 +- > > drivers/net/virtio/meson.build | 2 + > > drivers/net/virtio/virtio_ethdev.c | 19 +- > > drivers/net/virtio/virtio_rxtx.c | 7 +- > > drivers/net/virtio/virtio_rxtx_packed.c | 37 +++ > > drivers/net/virtio/virtio_rxtx_packed.h | 300 +++++++++++++++++++ > > drivers/net/virtio/virtio_rxtx_packed_avx.c | 264 +--------------- > > drivers/net/virtio/virtio_rxtx_packed_neon.c | 202 +++++++++++++ > > drivers/net/virtio/virtio_user_ethdev.c | 2 + > > 9 files changed, 566 insertions(+), 271 deletions(-) create mode > > 100644 drivers/net/virtio/virtio_rxtx_packed.c > > create mode 100644 drivers/net/virtio/virtio_rxtx_packed.h > > create mode 100644 drivers/net/virtio/virtio_rxtx_packed_neon.c > >
> -----Original Message----- > From: Maxime Coquelin <maxime.coquelin@redhat.com> > Sent: Monday, October 5, 2020 3:34 PM > To: Joyce Kong <Joyce.Kong@arm.com> > Cc: jerinj@marvell.com; dev@dpdk.org; nd <nd@arm.com>; Honnappa > Nagarahalli <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang > <Ruifeng.Wang@arm.com>; Phil Yang <Phil.Yang@arm.com> > Subject: Re: [RFC 0/3] Vectorize packed ring RX path with NEON > > Hi Joyce, > > On 9/11/20 2:09 PM, Joyce Kong wrote: > > This patch set introduced vectorized RX path for packed ring with > > NEON. > > Overall, the series looks good. I will have to trust you on the NEON > implementation. Ideally, having a detailed review from someone from ARM > would be good. This patch doesn’t target 20.11. New version will be sent out but not in short time. You can skip this one for 20.11 release. Thanks. > > Could you please send a new revision with the build issues reported by Intel > CI fixed? > > http://mails.dpdk.org/archives/test-report/2020-September/152501.html > > Thanks, > Maxime > > > > Joyce Kong (3): > > net/virtio: move AVX based Rx and Tx code to separate file > > net/virtio: add vectorized packed ring Rx NEON path > > net/virtio: add election for packed vector Rx NEON path > > > > doc/guides/nics/virtio.rst | 4 +- > > drivers/net/virtio/meson.build | 2 + > > drivers/net/virtio/virtio_ethdev.c | 19 +- > > drivers/net/virtio/virtio_rxtx.c | 7 +- > > drivers/net/virtio/virtio_rxtx_packed.c | 37 +++ > > drivers/net/virtio/virtio_rxtx_packed.h | 300 +++++++++++++++++++ > > drivers/net/virtio/virtio_rxtx_packed_avx.c | 264 +--------------- > > drivers/net/virtio/virtio_rxtx_packed_neon.c | 202 +++++++++++++ > > drivers/net/virtio/virtio_user_ethdev.c | 2 + > > 9 files changed, 566 insertions(+), 271 deletions(-) create mode > > 100644 drivers/net/virtio/virtio_rxtx_packed.c > > create mode 100644 drivers/net/virtio/virtio_rxtx_packed.h > > create mode 100644 drivers/net/virtio/virtio_rxtx_packed_neon.c > >
On 10/15/20 11:01 AM, Ruifeng Wang wrote: > >> -----Original Message----- >> From: Maxime Coquelin <maxime.coquelin@redhat.com> >> Sent: Monday, October 5, 2020 3:34 PM >> To: Joyce Kong <Joyce.Kong@arm.com> >> Cc: jerinj@marvell.com; dev@dpdk.org; nd <nd@arm.com>; Honnappa >> Nagarahalli <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang >> <Ruifeng.Wang@arm.com>; Phil Yang <Phil.Yang@arm.com> >> Subject: Re: [RFC 0/3] Vectorize packed ring RX path with NEON >> >> Hi Joyce, >> >> On 9/11/20 2:09 PM, Joyce Kong wrote: >>> This patch set introduced vectorized RX path for packed ring with >>> NEON. >> >> Overall, the series looks good. I will have to trust you on the NEON >> implementation. Ideally, having a detailed review from someone from ARM >> would be good. > This patch doesn’t target 20.11. New version will be sent out but not in short time. > You can skip this one for 20.11 release. Thanks Ruifeng for the update. I'll mark the series as postponed then. Maxime > Thanks. >> >> Could you please send a new revision with the build issues reported by Intel >> CI fixed? >> >> http://mails.dpdk.org/archives/test-report/2020-September/152501.html >> >> Thanks, >> Maxime >> >> >>> Joyce Kong (3): >>> net/virtio: move AVX based Rx and Tx code to separate file >>> net/virtio: add vectorized packed ring Rx NEON path >>> net/virtio: add election for packed vector Rx NEON path >>> >>> doc/guides/nics/virtio.rst | 4 +- >>> drivers/net/virtio/meson.build | 2 + >>> drivers/net/virtio/virtio_ethdev.c | 19 +- >>> drivers/net/virtio/virtio_rxtx.c | 7 +- >>> drivers/net/virtio/virtio_rxtx_packed.c | 37 +++ >>> drivers/net/virtio/virtio_rxtx_packed.h | 300 +++++++++++++++++++ >>> drivers/net/virtio/virtio_rxtx_packed_avx.c | 264 +--------------- >>> drivers/net/virtio/virtio_rxtx_packed_neon.c | 202 +++++++++++++ >>> drivers/net/virtio/virtio_user_ethdev.c | 2 + >>> 9 files changed, 566 insertions(+), 271 deletions(-) create mode >>> 100644 drivers/net/virtio/virtio_rxtx_packed.c >>> create mode 100644 drivers/net/virtio/virtio_rxtx_packed.h >>> create mode 100644 drivers/net/virtio/virtio_rxtx_packed_neon.c >>> >