mbox series

[v4,0/4] add RegEx class

Message ID 1593675963-13317-1-git-send-email-orika@mellanox.com (mailing list archive)
Headers
Series add RegEx class |

Message

Ori Kam July 2, 2020, 7:45 a.m. UTC
  This patch set adds the RegEx class, which enables RegEx pattern
matching, both on HW/SW PMDs.

Example for applications that will benefit from this class:
* Next Generation Firewalls (NGFW)
* Deep Packet and Flow Inspection (DPI)
* Intrusion Prevention Systems (IPS)
* DDoS Mitigation
* Network Monitoring
* Data Loss Prevention (DLP)
* Smart NICs
* Grammar based content processing
* URL, spam and adware filtering
* Advanced auditing and policing of user/application security policies
* Financial data mining - parsing of streamed financial feeds
* Application recognition.
* Dmemory introspection.
* Natural Language Processing (NLP)
* Sentiment Analysis.
* Big data databse acceleration.
* Computational storage. 

This patch set is based on RFC[1]

This class should be merged only after there is at least
one PMD that implements it. Also the test application will
be added when the first PMD is added.



[1] https://patches.dpdk.org/patch/66501/

v4:
* fix issue in patch 4 "implement regex rte level functions"

v3:
* adress ML comments.

v2:
* address ML comments.


Jerin Jacob (1):
  regexdev: introduce regexdev subsystem

Ori Kam (3):
  regexdev: add regex core h file
  regexdev: add regexdev core functions
  regexdev: implement regex rte level functions

 config/common_base                           |    8 +
 config/meson.build                           |    1 +
 doc/api/doxy-api-index.md                    |    1 +
 doc/api/doxy-api.conf.in                     |    1 +
 doc/guides/prog_guide/index.rst              |    1 +
 doc/guides/prog_guide/regexdev_lib.rst       |  177 +++
 lib/Makefile                                 |    2 +
 lib/librte_regexdev/Makefile                 |   33 +
 lib/librte_regexdev/meson.build              |   10 +
 lib/librte_regexdev/rte_regexdev.c           |  568 ++++++++++
 lib/librte_regexdev/rte_regexdev.h           | 1534 ++++++++++++++++++++++++++
 lib/librte_regexdev/rte_regexdev_core.h      |  184 +++
 lib/librte_regexdev/rte_regexdev_driver.h    |   59 +
 lib/librte_regexdev/rte_regexdev_version.map |   26 +
 lib/meson.build                              |    2 +-
 meson_options.txt                            |    2 +
 16 files changed, 2608 insertions(+), 1 deletion(-)
 create mode 100644 doc/guides/prog_guide/regexdev_lib.rst
 create mode 100644 lib/librte_regexdev/Makefile
 create mode 100644 lib/librte_regexdev/meson.build
 create mode 100644 lib/librte_regexdev/rte_regexdev.c
 create mode 100644 lib/librte_regexdev/rte_regexdev.h
 create mode 100644 lib/librte_regexdev/rte_regexdev_core.h
 create mode 100644 lib/librte_regexdev/rte_regexdev_driver.h
 create mode 100644 lib/librte_regexdev/rte_regexdev_version.map
  

Comments

Thomas Monjalon July 5, 2020, 9:21 p.m. UTC | #1
02/07/2020 09:45, Ori Kam:
>  config/common_base                           |    8 +
>  config/meson.build                           |    1 +
>  doc/api/doxy-api-index.md                    |    1 +
>  doc/api/doxy-api.conf.in                     |    1 +
>  doc/guides/prog_guide/index.rst              |    1 +
>  doc/guides/prog_guide/regexdev_lib.rst       |  177 +++
>  lib/Makefile                                 |    2 +
>  lib/librte_regexdev/Makefile                 |   33 +
>  lib/librte_regexdev/meson.build              |   10 +
>  lib/librte_regexdev/rte_regexdev.c           |  568 ++++++++++
>  lib/librte_regexdev/rte_regexdev.h           | 1534 ++++++++++++++++++++++++++
>  lib/librte_regexdev/rte_regexdev_core.h      |  184 +++
>  lib/librte_regexdev/rte_regexdev_driver.h    |   59 +
>  lib/librte_regexdev/rte_regexdev_version.map |   26 +
>  lib/meson.build                              |    2 +-
>  meson_options.txt                            |    2 +

When adding a new library, a lot of files have to be modified:
	- maintainers
	- doxygen index and config
	- doc guide
	- compilation files
	- new test application
	- new example application

The update of MAINTAINERS is missing.
The applications are missing but I think they can be added later.
  
Ori Kam July 6, 2020, 7:03 a.m. UTC | #2
Hi Thomas

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Subject: Re: [dpdk-dev] [PATCH v4 0/4] add RegEx class
> 
> 02/07/2020 09:45, Ori Kam:
> >  config/common_base                           |    8 +
> >  config/meson.build                           |    1 +
> >  doc/api/doxy-api-index.md                    |    1 +
> >  doc/api/doxy-api.conf.in                     |    1 +
> >  doc/guides/prog_guide/index.rst              |    1 +
> >  doc/guides/prog_guide/regexdev_lib.rst       |  177 +++
> >  lib/Makefile                                 |    2 +
> >  lib/librte_regexdev/Makefile                 |   33 +
> >  lib/librte_regexdev/meson.build              |   10 +
> >  lib/librte_regexdev/rte_regexdev.c           |  568 ++++++++++
> >  lib/librte_regexdev/rte_regexdev.h           | 1534
> ++++++++++++++++++++++++++
> >  lib/librte_regexdev/rte_regexdev_core.h      |  184 +++
> >  lib/librte_regexdev/rte_regexdev_driver.h    |   59 +
> >  lib/librte_regexdev/rte_regexdev_version.map |   26 +
> >  lib/meson.build                              |    2 +-
> >  meson_options.txt                            |    2 +
> 
> When adding a new library, a lot of files have to be modified:
> 	- maintainers
> 	- doxygen index and config
> 	- doc guide
> 	- compilation files
> 	- new test application
> 	- new example application
> 
> The update of MAINTAINERS is missing.
> The applications are missing but I think they can be added later.

Will update MAINTAINERS.
> 
Best,
Ori