mbox series

[v4,0/4] add travis ci support for ppc64le

Message ID 20200402171241.13258-1-dwilder@us.ibm.com (mailing list archive)
Headers
Series add travis ci support for ppc64le |

Message

David Wilder April 2, 2020, 5:12 p.m. UTC 
  This patch series adds Travis gcc compilation jobs and unit testing
for ppc64le.  Limitations for ppc64le are similar to arm64 (see commit
31bb45bcfd).

1. Only gcc builds are supported on ppc64le.
2. Hugepages are not available in the ppc64le Travis environment.
3. Memory requirements are larger for ppc64le due to a higher
   RTE_MAX_LCORE value.

V2: Insures iova-mode is VA when --no-huge is selected.
    Removed setting of --iova-mode=VA in test-null.sh.
V3: Refactor ppc64le changes on top of David Marchand's
    Patch series: "Reorganise Travis jobs"
    http://mails.dpdk.org/archives/dev/2020-February/158231.html
V4: Adding unit testing.
    Updated eal/linux: patch to force PA mode when --huge-page is used.
    This should be a more straightforward solution than my V3 patch.

A Travis build with theses patches can be found here:
https://travis-ci.org/github/djlwilder/dpdk/builds/670214578
David Wilder (4):
  eal/linux: force iova-mode va with no-huge option
  devtools: allow test-null.sh to run on ppc64le
  ci: add travis ci support for native ppc64le
  ci: enable unit test for ppc64le

 .travis.yml                | 23 +++++++++++++++++++++++
 devtools/test-null.sh      |  2 +-
 lib/librte_eal/linux/eal.c | 24 ++++++++++++------------
 3 files changed, 36 insertions(+), 13 deletions(-)

Comments

David Marchand March 25, 2021, 3:06 p.m. UTC | #1 
On Thu, Apr 2, 2020 at 7:13 PM David Wilder <dwilder@us.ibm.com> wrote:
>
> This patch series adds Travis gcc compilation jobs and unit testing
> for ppc64le.  Limitations for ppc64le are similar to arm64 (see commit
> 31bb45bcfd).
>
> 1. Only gcc builds are supported on ppc64le.
> 2. Hugepages are not available in the ppc64le Travis environment.
> 3. Memory requirements are larger for ppc64le due to a higher
>    RTE_MAX_LCORE value.
>
> V2: Insures iova-mode is VA when --no-huge is selected.
>     Removed setting of --iova-mode=VA in test-null.sh.
> V3: Refactor ppc64le changes on top of David Marchand's
>     Patch series: "Reorganise Travis jobs"
>     http://mails.dpdk.org/archives/dev/2020-February/158231.html
> V4: Adding unit testing.
>     Updated eal/linux: patch to force PA mode when --huge-page is used.
>     This should be a more straightforward solution than my V3 patch.
>
> A Travis build with theses patches can be found here:
> https://travis-ci.org/github/djlwilder/dpdk/builds/670214578
> David Wilder (4):
>   eal/linux: force iova-mode va with no-huge option
>   devtools: allow test-null.sh to run on ppc64le
>   ci: add travis ci support for native ppc64le
>   ci: enable unit test for ppc64le
>

Is this series still applicable?
The changes on EAL did not get a review.
Christian Ehrhardt April 15, 2021, 2:45 p.m. UTC | #2 
On Thu, Apr 2, 2020 at 7:13 PM David Wilder <dwilder@us.ibm.com> wrote:
>
> This patch series adds Travis gcc compilation jobs and unit testing
> for ppc64le.  Limitations for ppc64le are similar to arm64 (see commit
> 31bb45bcfd).
>
> 1. Only gcc builds are supported on ppc64le.
> 2. Hugepages are not available in the ppc64le Travis environment.
> 3. Memory requirements are larger for ppc64le due to a higher
>    RTE_MAX_LCORE value.
>
> V2: Insures iova-mode is VA when --no-huge is selected.
>     Removed setting of --iova-mode=VA in test-null.sh.
> V3: Refactor ppc64le changes on top of David Marchand's
>     Patch series: "Reorganise Travis jobs"
>     http://mails.dpdk.org/archives/dev/2020-February/158231.html
> V4: Adding unit testing.
>     Updated eal/linux: patch to force PA mode when --huge-page is used.
>     This should be a more straightforward solution than my V3 patch.
>
> A Travis build with theses patches can be found here:
> https://travis-ci.org/github/djlwilder/dpdk/builds/670214578
> David Wilder (4):
>   eal/linux: force iova-mode va with no-huge option
>   devtools: allow test-null.sh to run on ppc64le

This affects our testing and from reviewing the code I think the first
two are safe and good.
In addition it affects mostly no-huge which is almost testing-only.
Therefore for patch #1 and #2:

Reviewed-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>

@Luca - could you give this a try if it applies and fixes our issues please?
That would also answer DMs question about applicability.

>   ci: add travis ci support for native ppc64le
>   ci: enable unit test for ppc64le

I can't speak much about the travis change :-/


>  .travis.yml                | 23 +++++++++++++++++++++++
>  devtools/test-null.sh      |  2 +-
>  lib/librte_eal/linux/eal.c | 24 ++++++++++++------------
>  3 files changed, 36 insertions(+), 13 deletions(-)
>
> --
> 2.25.0
>


--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
Luca Boccassi April 19, 2021, 12:22 p.m. UTC | #3 
On Thu, 2021-04-15 at 16:45 +0200, Christian Ehrhardt wrote:
> On Thu, Apr 2, 2020 at 7:13 PM David Wilder <dwilder@us.ibm.com> wrote:
> > This patch series adds Travis gcc compilation jobs and unit testing
> > for ppc64le.  Limitations for ppc64le are similar to arm64 (see commit
> > 31bb45bcfd).
> > 
> > 1. Only gcc builds are supported on ppc64le.
> > 2. Hugepages are not available in the ppc64le Travis environment.
> > 3. Memory requirements are larger for ppc64le due to a higher
> >    RTE_MAX_LCORE value.
> > 
> > V2: Insures iova-mode is VA when --no-huge is selected.
> >     Removed setting of --iova-mode=VA in test-null.sh.
> > V3: Refactor ppc64le changes on top of David Marchand's
> >     Patch series: "Reorganise Travis jobs"
> >     http://mails.dpdk.org/archives/dev/2020-February/158231.html
> > V4: Adding unit testing.
> >     Updated eal/linux: patch to force PA mode when --huge-page is used.
> >     This should be a more straightforward solution than my V3 patch.
> > 
> > A Travis build with theses patches can be found here:
> > https://travis-ci.org/github/djlwilder/dpdk/builds/670214578
> > David Wilder (4):
> >   eal/linux: force iova-mode va with no-huge option
> >   devtools: allow test-null.sh to run on ppc64le
> 
> This affects our testing and from reviewing the code I think the first
> two are safe and good.
> In addition it affects mostly no-huge which is almost testing-only.
> Therefore for patch #1 and #2:
> 
> Reviewed-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> 
> @Luca - could you give this a try if it applies and fixes our issues please?
> That would also answer DMs question about applicability.

Hi,

The first patch applies with very minor and trivial refresh for fuzz to
20.11, and fixes the issue for me - the fast suite can now run without
privileges in autopkgtest. I'd like to have this included for 21.05 so
that we can fix the tests.

So:

Tested-by: Luca Boccassi <bluca@debian.org>