[v2,0/2] net/mlx5: cache the associated network device ifindex
mbox series

Message ID 1563721001-3730-1-git-send-email-viacheslavo@mellanox.com
Headers show
Series
  • net/mlx5: cache the associated network device ifindex
Related show

Message

Viacheslav Ovsiienko July 21, 2019, 2:56 p.m. UTC
In mlx5 PMD the associated device index is retrieved via Netlink request to
underlying Infiniband device driver. This network device index is permanent
throughout the lifetime of device. We do not spawn the rte_eth_dev ports
without associated network device, and if network device is being unbound
we get the remove notification event message and rte_eth_dev port is also
detached. So, we may store the ifindex in mlx5_device_spawn() routine at
rte_eth_dev port creation and initialization time and use the cached
value further instead of doing actual Netlink request.

This approach allows the query API routines like mlx5_link_update to be
thread-safe due to Netlink request elimination. mlx5_link_update() may
be called in asynchronous event handler concurrently and it may cause
application hang.

This patch extends and updates the [1]. 

[1] http://patches.dpdk.org/patch/56417/

Reported-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>

---
v2:
  -- comments addressed

v1:
  -- http://patches.dpdk.org/cover/56749/

Viacheslav Ovsiienko (2):
  net/mlx5: cache the associated network device ifindex
  Revert "net/mlx5: fix master device Netlink socket sharing"

 drivers/net/mlx5/mlx5.c        |   7 +++
 drivers/net/mlx5/mlx5.h        |   7 +--
 drivers/net/mlx5/mlx5_ethdev.c | 128 ++++-------------------------------------
 3 files changed, 18 insertions(+), 124 deletions(-)

Comments

Raslan Darawsheh July 22, 2019, 8:43 a.m. UTC | #1
Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Viacheslav Ovsiienko
> Sent: Sunday, July 21, 2019 5:57 PM
> To: dev@dpdk.org
> Cc: Yongseok Koh <yskoh@mellanox.com>; Shahaf Shuler
> <shahafs@mellanox.com>; stephen@networkplumber.org
> Subject: [dpdk-dev] [PATCH v2 0/2] net/mlx5: cache the associated network
> device ifindex
> 
> In mlx5 PMD the associated device index is retrieved via Netlink request to
> underlying Infiniband device driver. This network device index is permanent
> throughout the lifetime of device. We do not spawn the rte_eth_dev ports
> without associated network device, and if network device is being unbound
> we get the remove notification event message and rte_eth_dev port is also
> detached. So, we may store the ifindex in mlx5_device_spawn() routine at
> rte_eth_dev port creation and initialization time and use the cached
> value further instead of doing actual Netlink request.
> 
> This approach allows the query API routines like mlx5_link_update to be
> thread-safe due to Netlink request elimination. mlx5_link_update() may
> be called in asynchronous event handler concurrently and it may cause
> application hang.
> 
> This patch extends and updates the [1].
> 
> [1]
> https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch
> es.dpdk.org%2Fpatch%2F56417%2F&amp;data=02%7C01%7Crasland%40mell
> anox.com%7C3c155fb435384529783608d70debb168%7Ca652971c7d2e4d9ba6
> a4d149256f461b%7C0%7C0%7C636993178256642102&amp;sdata=GNj8%2B79
> %2FoBQzu7esmy4wN4e6WC7RHREDbV4OZTq6SOA%3D&amp;reserved=0
> 
> Reported-by: Stephen Hemminger <stephen@networkplumber.org>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> 
> ---

Series applied to next-net-mlx

Kindest regards,
Raslan Darawsheh