[00/22] bnxt patchset

  This patchset based on commit a164bb7c0a5ab3b100357cf56696c945fe28ab73
contains bug fixes and an update to the HWRM API.
Please apply.

Ajit Khaparde (1):
  net/bnxt: update HWRM API to version 1.10.0.91

Kalesh AP (11):
  net/bnxt: fix to handle error case during port start
  net/bnxt: fix return value check of address mapping
  net/bnxt: fix failure to add a MAC address
  net/bnxt: fix an unconditional wait in link update
  net/bnxt: fix setting primary MAC address
  net/bnxt: fix failure path in dev init
  net/bnxt: reset filters before registering interrupts
  net/bnxt: fix error checking of FW commands
  net/bnxt: fix to return standard error codes
  net/bnxt: fix lock release on getting NVM info
  net/bnxt: fix to correctly check result of HWRM command

Lance Richardson (8):
  net/bnxt: use correct vnic default completion ring
  net/bnxt: use dedicated cpr for async events
  net/bnxt: retry irq callback deregistration
  net/bnxt: use correct RSS table sizes
  net/bnxt: fully initialize hwrm msgs for thor RSS cfg
  net/bnxt: use correct number of RSS contexts for thor
  net/bnxt: pass correct RSS table address for thor
  net/bnxt: avoid overrun in get statistics

Santoshkumar Karanappa Rastapur (2):
  net/bnxt: fix RSS disable issue for thor-based adapters
  net/bnxt: fix MAC/VLAN filter allocation failure

 config/common_base                           |    1 +
 config/defconfig_arm64-stingray-linuxapp-gcc |    3 +
 drivers/net/bnxt/bnxt.h                      |   11 +-
 drivers/net/bnxt/bnxt_ethdev.c               |  346 +++--
 drivers/net/bnxt/bnxt_hwrm.c                 |  160 +--
 drivers/net/bnxt/bnxt_hwrm.h                 |    2 +
 drivers/net/bnxt/bnxt_irq.c                  |  108 +-
 drivers/net/bnxt/bnxt_irq.h                  |    2 +-
 drivers/net/bnxt/bnxt_ring.c                 |  147 +-
 drivers/net/bnxt/bnxt_ring.h                 |    3 +
 drivers/net/bnxt/bnxt_rxr.c                  |    2 +-
 drivers/net/bnxt/bnxt_rxtx_vec_sse.c         |    2 +-
 drivers/net/bnxt/bnxt_stats.c                |   11 +-
 drivers/net/bnxt/bnxt_vnic.c                 |   18 +-
 drivers/net/bnxt/hsi_struct_def_dpdk.h       | 1283 +++++++++++++++---
 15 files changed, 1562 insertions(+), 537 deletions(-)
  

On 7/18/2019 4:35 AM, Ajit Khaparde wrote:
> This patchset based on commit a164bb7c0a5ab3b100357cf56696c945fe28ab73
> contains bug fixes and an update to the HWRM API.
> Please apply.
> 
> Ajit Khaparde (1):
>   net/bnxt: update HWRM API to version 1.10.0.91
> 
> Kalesh AP (11):
>   net/bnxt: fix to handle error case during port start
>   net/bnxt: fix return value check of address mapping
>   net/bnxt: fix failure to add a MAC address
>   net/bnxt: fix an unconditional wait in link update
>   net/bnxt: fix setting primary MAC address
>   net/bnxt: fix failure path in dev init
>   net/bnxt: reset filters before registering interrupts
>   net/bnxt: fix error checking of FW commands
>   net/bnxt: fix to return standard error codes
>   net/bnxt: fix lock release on getting NVM info
>   net/bnxt: fix to correctly check result of HWRM command
> 
> Lance Richardson (8):
>   net/bnxt: use correct vnic default completion ring
>   net/bnxt: use dedicated cpr for async events
>   net/bnxt: retry irq callback deregistration
>   net/bnxt: use correct RSS table sizes
>   net/bnxt: fully initialize hwrm msgs for thor RSS cfg
>   net/bnxt: use correct number of RSS contexts for thor
>   net/bnxt: pass correct RSS table address for thor
>   net/bnxt: avoid overrun in get statistics
> 
> Santoshkumar Karanappa Rastapur (2):
>   net/bnxt: fix RSS disable issue for thor-based adapters
>   net/bnxt: fix MAC/VLAN filter allocation failure
> 


Hi Ajit,

All bnxt patches has been sent after rc1, and this one has been sent a day
before rc2. A believe you are aware that proposal deadline was "June 3, 2019".

I will still try to get them but most probably the patchset won't able to make
this release, fyi.

Regards,
ferruh
  

> On Jul 19, 2019, at 18:00, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
>> On 7/18/2019 4:35 AM, Ajit Khaparde wrote:
>> This patchset based on commit a164bb7c0a5ab3b100357cf56696c945fe28ab73
>> contains bug fixes and an update to the HWRM API.
>> Please apply.
>>
>> Ajit Khaparde (1):
>>  net/bnxt: update HWRM API to version 1.10.0.91
>>
>> Kalesh AP (11):
>>  net/bnxt: fix to handle error case during port start
>>  net/bnxt: fix return value check of address mapping
>>  net/bnxt: fix failure to add a MAC address
>>  net/bnxt: fix an unconditional wait in link update
>>  net/bnxt: fix setting primary MAC address
>>  net/bnxt: fix failure path in dev init
>>  net/bnxt: reset filters before registering interrupts
>>  net/bnxt: fix error checking of FW commands
>>  net/bnxt: fix to return standard error codes
>>  net/bnxt: fix lock release on getting NVM info
>>  net/bnxt: fix to correctly check result of HWRM command
>>
>> Lance Richardson (8):
>>  net/bnxt: use correct vnic default completion ring
>>  net/bnxt: use dedicated cpr for async events
>>  net/bnxt: retry irq callback deregistration
>>  net/bnxt: use correct RSS table sizes
>>  net/bnxt: fully initialize hwrm msgs for thor RSS cfg
>>  net/bnxt: use correct number of RSS contexts for thor
>>  net/bnxt: pass correct RSS table address for thor
>>  net/bnxt: avoid overrun in get statistics
>>
>> Santoshkumar Karanappa Rastapur (2):
>>  net/bnxt: fix RSS disable issue for thor-based adapters
>>  net/bnxt: fix MAC/VLAN filter allocation failure
>>
>
>
> Hi Ajit,
>
> All bnxt patches has been sent after rc1, and this one has been sent a day
> before rc2. A believe you are aware that proposal deadline was "June 3, 2019".
I understand. But most of these including the next patch set are bug fixes.
It just that some stayed in our staging area longer. But most of them
were detected and fixed in the last week when our QA ramped testing on
rc1.

Intact as I type this mail I see two more bug fixes ready for submission.

>
> I will still try to get them but most probably the patchset won't able to make
> this release, fyi.

Thanks
Ajit

>
> Regards,
> ferruh
  

On 7/19/2019 2:22 PM, Ajit Kumar Khaparde wrote:
>> On Jul 19, 2019, at 18:00, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>
>>> On 7/18/2019 4:35 AM, Ajit Khaparde wrote:
>>> This patchset based on commit a164bb7c0a5ab3b100357cf56696c945fe28ab73
>>> contains bug fixes and an update to the HWRM API.
>>> Please apply.
>>>
>>> Ajit Khaparde (1):
>>>  net/bnxt: update HWRM API to version 1.10.0.91
>>>
>>> Kalesh AP (11):
>>>  net/bnxt: fix to handle error case during port start
>>>  net/bnxt: fix return value check of address mapping
>>>  net/bnxt: fix failure to add a MAC address
>>>  net/bnxt: fix an unconditional wait in link update
>>>  net/bnxt: fix setting primary MAC address
>>>  net/bnxt: fix failure path in dev init
>>>  net/bnxt: reset filters before registering interrupts
>>>  net/bnxt: fix error checking of FW commands
>>>  net/bnxt: fix to return standard error codes
>>>  net/bnxt: fix lock release on getting NVM info
>>>  net/bnxt: fix to correctly check result of HWRM command
>>>
>>> Lance Richardson (8):
>>>  net/bnxt: use correct vnic default completion ring
>>>  net/bnxt: use dedicated cpr for async events
>>>  net/bnxt: retry irq callback deregistration
>>>  net/bnxt: use correct RSS table sizes
>>>  net/bnxt: fully initialize hwrm msgs for thor RSS cfg
>>>  net/bnxt: use correct number of RSS contexts for thor
>>>  net/bnxt: pass correct RSS table address for thor
>>>  net/bnxt: avoid overrun in get statistics
>>>
>>> Santoshkumar Karanappa Rastapur (2):
>>>  net/bnxt: fix RSS disable issue for thor-based adapters
>>>  net/bnxt: fix MAC/VLAN filter allocation failure
>>>
>>
>>
>> Hi Ajit,
>>
>> All bnxt patches has been sent after rc1, and this one has been sent a day
>> before rc2. A believe you are aware that proposal deadline was "June 3, 2019".
> I understand. But most of these including the next patch set are bug fixes.
> It just that some stayed in our staging area longer. But most of them
> were detected and fixed in the last week when our QA ramped testing on
> rc1.

You are right, I will do my best to get them for rc2.

> 
> Intact as I type this mail I see two more bug fixes ready for submission.
> 
>>
>> I will still try to get them but most probably the patchset won't able to make
>> this release, fyi.
> 
> Thanks
> Ajit
> 
>>
>> Regards,
>> ferruh
  

On 7/18/2019 4:35 AM, Ajit Khaparde wrote:
> This patchset based on commit a164bb7c0a5ab3b100357cf56696c945fe28ab73
> contains bug fixes and an update to the HWRM API.
> Please apply.
> 
> Ajit Khaparde (1):
>   net/bnxt: update HWRM API to version 1.10.0.91
> 
> Kalesh AP (11):
>   net/bnxt: fix to handle error case during port start
>   net/bnxt: fix return value check of address mapping
>   net/bnxt: fix failure to add a MAC address
>   net/bnxt: fix an unconditional wait in link update
>   net/bnxt: fix setting primary MAC address
>   net/bnxt: fix failure path in dev init
>   net/bnxt: reset filters before registering interrupts
>   net/bnxt: fix error checking of FW commands
>   net/bnxt: fix to return standard error codes
>   net/bnxt: fix lock release on getting NVM info
>   net/bnxt: fix to correctly check result of HWRM command
> 
> Lance Richardson (8):
>   net/bnxt: use correct vnic default completion ring
>   net/bnxt: use dedicated cpr for async events
>   net/bnxt: retry irq callback deregistration
>   net/bnxt: use correct RSS table sizes
>   net/bnxt: fully initialize hwrm msgs for thor RSS cfg
>   net/bnxt: use correct number of RSS contexts for thor
>   net/bnxt: pass correct RSS table address for thor
>   net/bnxt: avoid overrun in get statistics
> 
> Santoshkumar Karanappa Rastapur (2):
>   net/bnxt: fix RSS disable issue for thor-based adapters
>   net/bnxt: fix MAC/VLAN filter allocation failure


Series applied to dpdk-next-net/master, thanks.


- fixed build error [1] for some targets [2], because of missing header
- fixed checkpatch warnings [3]

[1]
.../drivers/net/bnxt/bnxt_irq.c: In function ‘bnxt_free_int’:
.../drivers/net/bnxt/bnxt_irq.c:79:4: error: implicit declaration of function
‘rte_delay_ms’; did you mean ‘rte_read64’? [-Werror=implicit-function-declaration]
    rte_delay_ms(50);
    ^~~~~~~~~~~~
    rte_read64

[2]
arm64-armv8a-linuxapp-gcc
ppc_64-power8-linuxapp-gcc
arm64-thunderx-linuxapp-gcc


[3]
fixed following checkpatch warnings (not including multiple instance for same
typo) while merging, please fix them before sending next time.

WARNING:TYPO_SPELLING: 'preceed' may be misspelled - perhaps 'precede'?
#933: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:3982:
+        * preceed the TPA End completion. If the value is zero, then the

WARNING:TYPO_SPELLING: 'occured' may be misspelled - perhaps 'occurred'?
#1110: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:4603:
+       /* Indicates the physical function this event occured on. */

WARNING:TYPO_SPELLING: 'auxillary' may be misspelled - perhaps 'auxiliary'?
#1658: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:31204:
+        * that are input as auxillary data.