mbox series

[v2,0/7] ethdev: add min/max MTU to device info

Message ID 1553259678-4515-1-git-send-email-ian.stokes@intel.com (mailing list archive)
Headers
Series ethdev: add min/max MTU to device info |

Message

Ian Stokes March 22, 2019, 1:01 p.m. UTC
  Building upon the discussion around [1], this series introduces MTU min
and MTU max variables. It also provides updates to PMD implementations
for ixgbe, i40e and IGB devices so that these variables are populated
for use when retrieving device info.

This series was tested with OVS DPDK and functions as expected for the
drivers listed below. But a wider selection of PMD drivers would have to
adopt this to ensure jumbo frames functionality remains for drivers not
modified in the series.

There is also ongoing discussion in [2] regarding overhead to be
considered with MTU and how this may change from device to device, this
series uses existing overhead assumptions.

This series was previously posted as an RFC in [3] and a v1 in [4],
this revision implements changes received in feedback on v1.

[1] http://mails.dpdk.org/archives/dev/2018-September/110959.html
[2] http://mails.dpdk.org/archives/dev/2019-February/124457.html
[3] http://mails.dpdk.org/archives/dev/2019-February/124938.html
[4] http://mails.dpdk.org/archives/dev/2019-February/125319.html

Ian Stokes (6):
  net/i40e: set min and max MTU for i40e devices
  net/i40e: set min and max MTU for i40e VF devices
  net/ixgbe: set min and max MTU for ixgbe devices
  net/ixgbe: set min and max MTU for ixgbe VF devices
  net/e1000: set min and max MTU for igb devices
  app/testpmd: verify mtu with rte_eth_dev_info_get()

Stephen Hemminger (1):
  ethdev: add min/max MTU to device info

 app/test-pmd/config.c                  |  4 ++++
 doc/guides/rel_notes/deprecation.rst   | 12 ------------
 doc/guides/rel_notes/release_19_05.rst |  8 +++++++-
 drivers/net/e1000/e1000_ethdev.h       |  6 ++++++
 drivers/net/e1000/igb_ethdev.c         |  7 +++++--
 drivers/net/i40e/i40e_ethdev.c         |  2 ++
 drivers/net/i40e/i40e_ethdev_vf.c      |  2 ++
 drivers/net/ixgbe/ixgbe_ethdev.c       |  7 +++++--
 drivers/net/ixgbe/ixgbe_ethdev.h       |  3 +++
 lib/librte_ethdev/Makefile             |  2 +-
 lib/librte_ethdev/meson.build          |  2 +-
 lib/librte_ethdev/rte_ethdev.c         | 15 +++++++++++++++
 lib/librte_ethdev/rte_ethdev.h         | 33 ++++++++++++++++++++++++++++++++-
 13 files changed, 83 insertions(+), 20 deletions(-)
  

Comments

Ferruh Yigit March 28, 2019, 4:43 p.m. UTC | #1
On 3/22/2019 1:01 PM, Ian Stokes wrote:
> Building upon the discussion around [1], this series introduces MTU min
> and MTU max variables. It also provides updates to PMD implementations
> for ixgbe, i40e and IGB devices so that these variables are populated
> for use when retrieving device info.
> 
> This series was tested with OVS DPDK and functions as expected for the
> drivers listed below. But a wider selection of PMD drivers would have to
> adopt this to ensure jumbo frames functionality remains for drivers not
> modified in the series.
> 
> There is also ongoing discussion in [2] regarding overhead to be
> considered with MTU and how this may change from device to device, this
> series uses existing overhead assumptions.
> 
> This series was previously posted as an RFC in [3] and a v1 in [4],
> this revision implements changes received in feedback on v1.
> 
> [1] http://mails.dpdk.org/archives/dev/2018-September/110959.html
> [2] http://mails.dpdk.org/archives/dev/2019-February/124457.html
> [3] http://mails.dpdk.org/archives/dev/2019-February/124938.html
> [4] http://mails.dpdk.org/archives/dev/2019-February/125319.html
> 
> Ian Stokes (6):
>   net/i40e: set min and max MTU for i40e devices
>   net/i40e: set min and max MTU for i40e VF devices
>   net/ixgbe: set min and max MTU for ixgbe devices
>   net/ixgbe: set min and max MTU for ixgbe VF devices
>   net/e1000: set min and max MTU for igb devices
>   app/testpmd: verify mtu with rte_eth_dev_info_get()
> 
> Stephen Hemminger (1):
>   ethdev: add min/max MTU to device info

Final notice about the patch, if there is no objection will be merged tomorrow
this for rc1.

Reminder that all net PMD maintainers should update according this new 'min_mtu'
& 'max_mtu' approach.