mbox series

[0/3] net/enic: minor bug fixes

Message ID 20181020083249.8187-1-hyonkim@cisco.com (mailing list archive)
Headers
Series net/enic: minor bug fixes |

Message

Hyong Youb Kim (hyonkim) Oct. 20, 2018, 8:32 a.m. UTC 
  Fix a couple bugs found during internal testing, and update the
release notes, which was missing in previous patches.

The second patch ("net/enic: add missing Tx offload flags") addresses
a side effect from the following commit, which adds several previously
existing flags (e.g. PKT_TX_IPV4) to PKT_TX_OFFLOAD_MASK. The enic
driver, like a few other drivers, uses 'not-supported offload mask'
derived from PKT_TX_OFFLOAD_MASK to detect bad mbufs in
tx_pkt_prepare. And this mask needs an update to account for the added
flags. At least i40e is also affected.

commit ef28cfa73822 ("mbuf: fix Tx offload mask")

Hyong Youb Kim (3):
  net/enic: fix supported packet types
  net/enic: add missing Tx offload flags
  doc: update release notes for the enic driver

 doc/guides/rel_notes/release_18_11.rst |  7 +++++++
 drivers/net/enic/enic_ethdev.c         | 30 +++++++++++++++++++++++++++---
 drivers/net/enic/enic_main.c           |  6 ++----
 drivers/net/enic/enic_res.c            |  2 ++
 4 files changed, 38 insertions(+), 7 deletions(-)

Comments

Ferruh Yigit Oct. 22, 2018, 2:27 p.m. UTC | #1 
On 10/20/2018 9:32 AM, Hyong Youb Kim wrote:
> Fix a couple bugs found during internal testing, and update the
> release notes, which was missing in previous patches.
> 
> The second patch ("net/enic: add missing Tx offload flags") addresses
> a side effect from the following commit, which adds several previously
> existing flags (e.g. PKT_TX_IPV4) to PKT_TX_OFFLOAD_MASK. The enic
> driver, like a few other drivers, uses 'not-supported offload mask'
> derived from PKT_TX_OFFLOAD_MASK to detect bad mbufs in
> tx_pkt_prepare. And this mask needs an update to account for the added
> flags. At least i40e is also affected.

Thanks for hint, we will check it.

> 
> commit ef28cfa73822 ("mbuf: fix Tx offload mask")
> 
> Hyong Youb Kim (3):
>   net/enic: fix supported packet types
>   net/enic: add missing Tx offload flags
>   doc: update release notes for the enic driver

Series applied to dpdk-next-net/master, thanks.