Message ID | 20180903144311eucas1p2b6499c49dbd0d54334e973113cdc5ad6~Q6vBsFYRm1033710337eucas1p2D@eucas1p2.samsung.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0E3865F2E; Mon, 3 Sep 2018 16:43:15 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id AB6E05F2C for <dev@dpdk.org>; Mon, 3 Sep 2018 16:43:13 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20180903144312euoutp02d09deb376bd844ea96a235c5066ce767~Q6vDMzEy40054500545euoutp02c for <dev@dpdk.org>; Mon, 3 Sep 2018 14:43:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20180903144312euoutp02d09deb376bd844ea96a235c5066ce767~Q6vDMzEy40054500545euoutp02c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1535985792; bh=/YW7Hhwx36354jp7iukx6RxV91f+92ynLe+xkc17vng=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nhQrUBuAU5DM6CkyTsIu/Z2QTdJ7UbmRn1+BCAc4uobcNBvuUgnhv8Vw/okUCA9hJ f/RQ1TeMrwGcyZKEAkLFQTwa43jJTNMH9kVlO4Ir3NDReBrMwUQmXOU4+igCJ6PBLn jtendgFu2cLnrHzuuyI1I52LxpGB8FGRsuPmv404= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20180903144312eucas1p1c2e2642ebcbe42ff7e1f1afc67d6e573~Q6vCnnP-l2371823718eucas1p1s; Mon, 3 Sep 2018 14:43:12 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id E0.72.04441.F784D8B5; Mon, 3 Sep 2018 15:43:11 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20180903144311eucas1p2b6499c49dbd0d54334e973113cdc5ad6~Q6vBsFYRm1033710337eucas1p2D; Mon, 3 Sep 2018 14:43:11 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20180903144310eusmtrp2fc19354656b827cb919e98bd5ba590ba~Q6vBZsKvL0775007750eusmtrp2I; Mon, 3 Sep 2018 14:43:10 +0000 (GMT) X-AuditID: cbfec7f2-5c9ff70000001159-44-5b8d487f513b Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 15.67.04128.E784D8B5; Mon, 3 Sep 2018 15:43:10 +0100 (BST) Received: from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20180903144310eusmtip187bc02e17eec52ab7f6b8968934cfd9d~Q6vAzBM5b0837608376eusmtip1D; Mon, 3 Sep 2018 14:43:10 +0000 (GMT) From: Ilya Maximets <i.maximets@samsung.com> To: dev@dpdk.org Cc: Jingjing Wu <jingjing.wu@intel.com>, Konstantin Ananyev <konstantin.ananyev@intel.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>, Beilei Xing <beilei.xing@intel.com>, Qi Zhang <qi.z.zhang@intel.com>, Xiao Wang <xiao.w.wang@intel.com>, Bruce Richardson <bruce.richardson@intel.com>, Ilya Maximets <i.maximets@samsung.com> Date: Mon, 3 Sep 2018 17:44:31 +0300 X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180831124358eucas1p22a0f8a7d0ae34dfad73b3b9e819366ec~P_LFZr9ro1664316643eucas1p2m@eucas1p2.samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrJIsWRmVeSWpSXmKPExsWy7djPc7r1Hr3RBj8uGVl0f2hhsrixyt7i 3aftTBZX2n+yW8xc8JnR4v2fRSwW0zf0s1lsPfOX0WL/88PsDpwevxYsZfVYvOclk0ffllWM AcxRXDYpqTmZZalF+nYJXBmzzx5gK1jMWTH5023WBsZlbF2MnBwSAiYSv841M4HYQgIrGCXu n/LuYuQCsr8wSrR17IdKfGaU2HPDtIuRA6xhQn8ARM1yRomLiz6xQTg/GCX+rr3KDNLAJqAj cWr1EUYQW0RAQOJz52KwImaBo0wS17qmgxUJC+hJzN55BayIRUBV4vHBX0wQJ8lLrN5wAKyG U6BcomHGO3aQZgmB92wS7X+Os4KcwStQJjGz3Q6i3kVi7uu/jBC2sMSr41vYIWwZif8750PN rJe43/KSEWJOB6PE9EP/oBL2Elten2MHmcksoCmxfpc+RNhR4uy0FjaIj/kkbrwVBAkzA5mT toGcDxLmlehoE4KoVpH4fXA5M4QtJXHz3WeoCzwk5uxtZoWEzylGic1rzjFPYJSfhbBsASPj Kkbx1NLi3PTUYsO81HK94sTc4tK8dL3k/NxNjMAEcfrf8U87GL9eSjrEKMDBqMTDG2DQGy3E mlhWXJl7iFGCg1lJhLfRHSjEm5JYWZValB9fVJqTWnyIUZqDRUmcl08rLVpIID2xJDU7NbUg tQgmy8TBKdXAWKY1m1tslfvvs5rxHuEL34vkL+W79qLg4R1DLqs6dusvzJMWB4gLbLS8Ja7X k8Bqkuwy/0zXB83f+0+IuMjtj7qRezTcsPe0rcw/f46nHoe69uzsupjy+0mbk+sNi/IFJtU9 4kc6L05+/07VMnvO64a5fuuFNF1WTZp4T134XaRTdmsw8+dGJZbijERDLeai4kQABh91bgwD AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLLMWRmVeSWpSXmKPExsVy+t/xu7p1Hr3RBvebLC26P7QwWdxYZW/x 7tN2Josr7T/ZLWYu+Mxo8f7PIhaL6Rv62Sy2nvnLaLH/+WF2B06PXwuWsnos3vOSyaNvyyrG AOYoPZui/NKSVIWM/OISW6VoQwsjPUNLCz0jE0s9Q2PzWCsjUyV9O5uU1JzMstQifbsEvYzZ Zw+wFSzmrJj86TZrA+Myti5GDg4JAROJCf0BXYxcHEICSxkl9m15x9jFyAkUl5L48esCK4Qt LPHnWhcbRNE3Ron7fZvBitgEdCROrT4CZosICEh87lwMVsQscJpJ4sDaTcwgCWEBPYnZO6+A FbEIqEo8PviLCcTmFbCWeLDlMdQGeYnVGw6A1XMKlEs0zHjHDmILCZRJnH2/hmkCI98CRoZV jCKppcW56bnFRnrFibnFpXnpesn5uZsYgUG77djPLTsYu94FH2IU4GBU4uH9odsbLcSaWFZc mXuIUYKDWUmEt9EdKMSbklhZlVqUH19UmpNafIjRFOioicxSosn5wIjKK4k3NDU0t7A0NDc2 NzazUBLnPW9QGSUkkJ5YkpqdmlqQWgTTx8TBKdXA6GmxX1WoVfsMR88VaZ2UQ1a7YibeZjiV sy7Iv9VfdrmtsP2WrLVbUhLOq97xDJFw5lfaUzDFYP8Mt7eXP5ltXbHR7DpjtGraK4lNSwW/ PwyR1gwQUFq62XX+9vLfP00sYz9fZbMQkw2q+3Tjj/fsltP7si0bk69/tz0SmrCk+5xeaOe2 D1asSizFGYmGWsxFxYkAQBs4KHACAAA= Message-Id: <20180903144311eucas1p2b6499c49dbd0d54334e973113cdc5ad6~Q6vBsFYRm1033710337eucas1p2D@eucas1p2.samsung.com> X-CMS-MailID: 20180903144311eucas1p2b6499c49dbd0d54334e973113cdc5ad6 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20180903144311eucas1p2b6499c49dbd0d54334e973113cdc5ad6 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180903144311eucas1p2b6499c49dbd0d54334e973113cdc5ad6 References: <20180831124358eucas1p22a0f8a7d0ae34dfad73b3b9e819366ec~P_LFZr9ro1664316643eucas1p2m@eucas1p2.samsung.com> <CGME20180903144311eucas1p2b6499c49dbd0d54334e973113cdc5ad6@eucas1p2.samsung.com> Subject: [dpdk-dev] [PATCH v1 0/2] CPU non-blocking delay X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
CPU non-blocking delay
|
|
Message
Ilya Maximets
Sept. 3, 2018, 2:44 p.m. UTC
For meson build without deprecation warnings following patch should be applied first: http://patches.dpdk.org/patch/44129/ Ilya Maximets (2): eal: add nanosleep based delay function drivers/net: use sleep delay by default for intel NICs drivers/net/avf/Makefile | 1 + drivers/net/avf/base/avf_osdep.h | 4 +- drivers/net/e1000/Makefile | 1 + drivers/net/e1000/base/e1000_osdep.h | 2 +- drivers/net/e1000/meson.build | 2 + drivers/net/i40e/base/i40e_osdep.h | 6 +-- drivers/net/ifc/base/ifcvf_osdep.h | 2 +- drivers/net/ixgbe/base/ixgbe_osdep.h | 2 +- drivers/net/ixgbe/meson.build | 3 +- lib/librte_eal/common/eal_common_timer.c | 19 +++++++ .../common/include/generic/rte_cycles.h | 11 ++++ lib/librte_eal/rte_eal_version.map | 1 + test/test/autotest_data.py | 6 +++ test/test/meson.build | 1 + test/test/test_cycles.c | 51 ++++++++++++++----- 15 files changed, 89 insertions(+), 23 deletions(-)
Comments
> On Sep 3, 2018, at 9:44 AM, Ilya Maximets <i.maximets@samsung.com> wrote: > > For meson build without deprecation warnings following > patch should be applied first: > http://patches.dpdk.org/patch/44129/ Not to be super picky (OK I am super picky sometimes) can we change the name of the function rte_delay_us_sleep() to rte_sleep_us() the reason is delay and sleep conflict IMO. The rte_sleep_us() tells me it sleeps, which is a form of delay, but delay in DPDK assume busy wait. > > Ilya Maximets (2): > eal: add nanosleep based delay function > drivers/net: use sleep delay by default for intel NICs > > drivers/net/avf/Makefile | 1 + > drivers/net/avf/base/avf_osdep.h | 4 +- > drivers/net/e1000/Makefile | 1 + > drivers/net/e1000/base/e1000_osdep.h | 2 +- > drivers/net/e1000/meson.build | 2 + > drivers/net/i40e/base/i40e_osdep.h | 6 +-- > drivers/net/ifc/base/ifcvf_osdep.h | 2 +- > drivers/net/ixgbe/base/ixgbe_osdep.h | 2 +- > drivers/net/ixgbe/meson.build | 3 +- > lib/librte_eal/common/eal_common_timer.c | 19 +++++++ > .../common/include/generic/rte_cycles.h | 11 ++++ > lib/librte_eal/rte_eal_version.map | 1 + > test/test/autotest_data.py | 6 +++ > test/test/meson.build | 1 + > test/test/test_cycles.c | 51 ++++++++++++++----- > 15 files changed, 89 insertions(+), 23 deletions(-) > > -- > 2.17.1 > Regards, Keith
On 05.10.2018 17:09, Wiles, Keith wrote: > > >> On Sep 3, 2018, at 9:44 AM, Ilya Maximets <i.maximets@samsung.com> wrote: >> >> For meson build without deprecation warnings following >> patch should be applied first: >> http://patches.dpdk.org/patch/44129/ > > Not to be super picky (OK I am super picky sometimes) can we change the name of the function rte_delay_us_sleep() to rte_sleep_us() the reason is delay and sleep conflict IMO. The rte_sleep_us() tells me it sleeps, which is a form of delay, but delay in DPDK assume busy wait. I'm not sure about this, because this function intended to be used as 'rte_delay_us_callback', i.e. as implementation of 'rte_delay_us()'. IMO, it should state that it is the part of this API and that it sleeps internally at the same time. So I tried to combine both "delay" and "sleep" in one function name. If we'll change the name to 'rte_sleep_us' it will look like alternative to 'rte_delay_us', but it's one of its implementations. 'rte_delay_us_sleep' should be alternative to 'rte_delay_us_block()'. I'd like to call it 'rte_delay_us_nonblock()', but it may be way more confusing. What do you think? >> >> Ilya Maximets (2): >> eal: add nanosleep based delay function >> drivers/net: use sleep delay by default for intel NICs >> >> drivers/net/avf/Makefile | 1 + >> drivers/net/avf/base/avf_osdep.h | 4 +- >> drivers/net/e1000/Makefile | 1 + >> drivers/net/e1000/base/e1000_osdep.h | 2 +- >> drivers/net/e1000/meson.build | 2 + >> drivers/net/i40e/base/i40e_osdep.h | 6 +-- >> drivers/net/ifc/base/ifcvf_osdep.h | 2 +- >> drivers/net/ixgbe/base/ixgbe_osdep.h | 2 +- >> drivers/net/ixgbe/meson.build | 3 +- >> lib/librte_eal/common/eal_common_timer.c | 19 +++++++ >> .../common/include/generic/rte_cycles.h | 11 ++++ >> lib/librte_eal/rte_eal_version.map | 1 + >> test/test/autotest_data.py | 6 +++ >> test/test/meson.build | 1 + >> test/test/test_cycles.c | 51 ++++++++++++++----- >> 15 files changed, 89 insertions(+), 23 deletions(-) >> >> -- >> 2.17.1 >> > > Regards, > Keith > > >
> On Oct 5, 2018, at 9:44 AM, Ilya Maximets <i.maximets@samsung.com> wrote: > > On 05.10.2018 17:09, Wiles, Keith wrote: >> >> >>> On Sep 3, 2018, at 9:44 AM, Ilya Maximets <i.maximets@samsung.com> wrote: >>> >>> For meson build without deprecation warnings following >>> patch should be applied first: >>> http://patches.dpdk.org/patch/44129/ >> >> Not to be super picky (OK I am super picky sometimes) can we change the name of the function rte_delay_us_sleep() to rte_sleep_us() the reason is delay and sleep conflict IMO. The rte_sleep_us() tells me it sleeps, which is a form of delay, but delay in DPDK assume busy wait. > > I'm not sure about this, because this function intended to be used > as 'rte_delay_us_callback', i.e. as implementation of 'rte_delay_us()'. > IMO, it should state that it is the part of this API and that it > sleeps internally at the same time. So I tried to combine both "delay" > and "sleep" in one function name. > > If we'll change the name to 'rte_sleep_us' it will look like alternative > to 'rte_delay_us', but it's one of its implementations. > 'rte_delay_us_sleep' should be alternative to 'rte_delay_us_block()'. > > I'd like to call it 'rte_delay_us_nonblock()', but it may be way more > confusing. > > What do you think? I personally do not see the big tie to delay and callback as the rte_delay_us() is not rte_delay_us_with_callback() :-) Yes the code maybe doing a callback, but that has nothing to do with the API name IMO. Anyone else care about the name? > >>> >>> Ilya Maximets (2): >>> eal: add nanosleep based delay function >>> drivers/net: use sleep delay by default for intel NICs >>> >>> drivers/net/avf/Makefile | 1 + >>> drivers/net/avf/base/avf_osdep.h | 4 +- >>> drivers/net/e1000/Makefile | 1 + >>> drivers/net/e1000/base/e1000_osdep.h | 2 +- >>> drivers/net/e1000/meson.build | 2 + >>> drivers/net/i40e/base/i40e_osdep.h | 6 +-- >>> drivers/net/ifc/base/ifcvf_osdep.h | 2 +- >>> drivers/net/ixgbe/base/ixgbe_osdep.h | 2 +- >>> drivers/net/ixgbe/meson.build | 3 +- >>> lib/librte_eal/common/eal_common_timer.c | 19 +++++++ >>> .../common/include/generic/rte_cycles.h | 11 ++++ >>> lib/librte_eal/rte_eal_version.map | 1 + >>> test/test/autotest_data.py | 6 +++ >>> test/test/meson.build | 1 + >>> test/test/test_cycles.c | 51 ++++++++++++++----- >>> 15 files changed, 89 insertions(+), 23 deletions(-) >>> >>> -- >>> 2.17.1 >>> >> >> Regards, >> Keith >> >> >> Regards, Keith