Message ID | 1560505157-9769-1-git-send-email-david.marchand@redhat.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 692B31D4F6; Fri, 14 Jun 2019 11:39:45 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 3D5B31D4B6 for <dev@dpdk.org>; Fri, 14 Jun 2019 11:39:44 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 77E62307D90D; Fri, 14 Jun 2019 09:39:43 +0000 (UTC) Received: from dmarchan.remote.csb (unknown [10.40.205.71]) by smtp.corp.redhat.com (Postfix) with ESMTP id 74CFF6C357; Fri, 14 Jun 2019 09:39:36 +0000 (UTC) From: David Marchand <david.marchand@redhat.com> To: dev@dpdk.org Cc: benjamin.walker@intel.com, jerinj@marvell.com, anatoly.burakov@intel.com, maxime.coquelin@redhat.com, thomas@monjalon.net Date: Fri, 14 Jun 2019 11:39:14 +0200 Message-Id: <1560505157-9769-1-git-send-email-david.marchand@redhat.com> In-Reply-To: <20190530174819.1160221-1-benjamin.walker@intel.com> References: <20190530174819.1160221-1-benjamin.walker@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Fri, 14 Jun 2019 09:39:43 +0000 (UTC) Subject: [dpdk-dev] [PATCH v2 0/3] Improve automatic selection of IOVA mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
Improve automatic selection of IOVA mode
|
|
Message
David Marchand
June 14, 2019, 9:39 a.m. UTC
In SPDK, not all drivers are registered with DPDK at start up time. Previously, that meant DPDK always chose to set itself up in IOVA_PA mode. Instead, when the correct iova choice is unclear based on the devices and drivers known to DPDK at start up time, use other heuristics (such as whether /proc/self/pagemap is accessible) to make a better choice. This enables SPDK to run as an unprivileged user again without requiring users to explicitly set the iova mode on the command line. Changelog since v1: - I took over the series following experiments and discussions with Ben and others, squashed Ben patches as two patches focusing on the main issues, - introduced a fix on KNI, - on the EAL bits, - added log on which IOVA mode has been selected, - updated BSD EAL, - in Linux EAL, moved KNI special case after IOVA selection, - in Linux EAL, added check on forced mode wrt physical addresses availability, - on the PCI bus driver bits, - enforced the checks in the common code of the PCI bus, - added debug logs to track why a iova mode has been chosen per device, - added BSD part, - in Linux part, checked that VFIO is enabled, - in Linux part, defaulted to DC if a driver supports both PA and VA,
Comments
Help in review would be much appreciated here, thanks. 14/06/2019 11:39, David Marchand: > In SPDK, not all drivers are registered with DPDK at start up time. > Previously, that meant DPDK always chose to set itself up in IOVA_PA > mode. Instead, when the correct iova choice is unclear based on the > devices and drivers known to DPDK at start up time, use other heuristics > (such as whether /proc/self/pagemap is accessible) to make a better > choice. > > This enables SPDK to run as an unprivileged user again without requiring > users to explicitly set the iova mode on the command line. > > > Changelog since v1: > - I took over the series following experiments and discussions with Ben > and others, squashed Ben patches as two patches focusing on the main > issues, > - introduced a fix on KNI, > - on the EAL bits, > > - added log on which IOVA mode has been selected, > - updated BSD EAL, > - in Linux EAL, moved KNI special case after IOVA selection, > - in Linux EAL, added check on forced mode wrt physical addresses > availability, > > - on the PCI bus driver bits, > > - enforced the checks in the common code of the PCI bus, > - added debug logs to track why a iova mode has been chosen per device, > - added BSD part, > - in Linux part, checked that VFIO is enabled, > - in Linux part, defaulted to DC if a driver supports both PA and VA,
No review at all? I can merge then? 27/06/2019 19:05, Thomas Monjalon: > Help in review would be much appreciated here, thanks. > > 14/06/2019 11:39, David Marchand: > > In SPDK, not all drivers are registered with DPDK at start up time. > > Previously, that meant DPDK always chose to set itself up in IOVA_PA > > mode. Instead, when the correct iova choice is unclear based on the > > devices and drivers known to DPDK at start up time, use other heuristics > > (such as whether /proc/self/pagemap is accessible) to make a better > > choice. > > > > This enables SPDK to run as an unprivileged user again without requiring > > users to explicitly set the iova mode on the command line. > > > > > > Changelog since v1: > > - I took over the series following experiments and discussions with Ben > > and others, squashed Ben patches as two patches focusing on the main > > issues, > > - introduced a fix on KNI, > > - on the EAL bits, > > > > - added log on which IOVA mode has been selected, > > - updated BSD EAL, > > - in Linux EAL, moved KNI special case after IOVA selection, > > - in Linux EAL, added check on forced mode wrt physical addresses > > availability, > > > > - on the PCI bus driver bits, > > > > - enforced the checks in the common code of the PCI bus, > > - added debug logs to track why a iova mode has been chosen per device, > > - added BSD part, > > - in Linux part, checked that VFIO is enabled, > > - in Linux part, defaulted to DC if a driver supports both PA and VA, > > > >
14/06/2019 11:39, David Marchand: > In SPDK, not all drivers are registered with DPDK at start up time. > Previously, that meant DPDK always chose to set itself up in IOVA_PA > mode. Instead, when the correct iova choice is unclear based on the > devices and drivers known to DPDK at start up time, use other heuristics > (such as whether /proc/self/pagemap is accessible) to make a better > choice. > > This enables SPDK to run as an unprivileged user again without requiring > users to explicitly set the iova mode on the command line. Applied, thanks