Message ID | 1560152324-20538-1-git-send-email-arybchenko@solarflare.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8F6521BECD; Mon, 10 Jun 2019 09:39:18 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id F30DE1BE8C for <dev@dpdk.org>; Mon, 10 Jun 2019 09:38:55 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us5.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 23B084C005D for <dev@dpdk.org>; Mon, 10 Jun 2019 07:38:55 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 10 Jun 2019 00:38:51 -0700 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Mon, 10 Jun 2019 00:38:50 -0700 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id x5A7cm6Y008745 for <dev@dpdk.org>; Mon, 10 Jun 2019 08:38:48 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id E63AD1616E0 for <dev@dpdk.org>; Mon, 10 Jun 2019 08:38:48 +0100 (BST) From: Andrew Rybchenko <arybchenko@solarflare.com> To: <dev@dpdk.org> Date: Mon, 10 Jun 2019 08:38:15 +0100 Message-ID: <1560152324-20538-1-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24664.003 X-TM-AS-Result: No-1.260500-4.000000-10 X-TMASE-MatchedRID: Us3rGoNkxxlPwZftMdoCRoEU1kn9F/MZhVDnkfzD7uYda1Vk3RqxOAoe RRhCZWIBR7XN4n7P47k4qWHFgFCBg1mfmDNkuRFgIAjxomarSPBdxx6WRf+5sPp5Xn4sBppfsVm 3YvAah+8iR9Ooric5uW+HS1uc1hEBgbQtvKmrIqrRPkPVCrqkJxNNj6+ApDUjdLv/+WrG6tN6Ra SpHJq/AA4Xs7pbWEXf/+NIzv9aFBkYqWwQaFNQ7Zl84NGwes5gyiKgKtIyB4pIDkMISJ8DGqegu OhTIJ7RKPEiJMQqjbVT5dcN2eqlXpljT9UZ6uNJgbv7/FiYQRk6VbUEB5u/MLeW2B07O0Pwprlq 21wUI7RRMT949JbJEVy+m96b8Y7jPaeJTtZ7O6jm96eHJyFxjd1eFEoaE12nlzy6qhJBbZbfkEv 4DlDrSf0q3GPWZeE6bCexVCeAAegZuObll1qVQUhwlOfYeSqxSeIjeghh/zNBtyXLXw7qwwGRVP pr3xmq4pP0cHwc0iuAMuqetGVetnyef22ep6XYro1URZJFbJs9DbkjiQDNjjnjdlNnoBk+rwpJ5 TGWBqoSSroX7ZG3piuasmDsNfmQgUKdVBJROI9QV+CqiWyZ2HGgfvO2M7rKQAjLfPIg/CRPvZyg FH23fTojDH4s7aaP+F1mT75dk2SwKHQZ1VzS+Yt+jtoYM47t X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10-1.260500-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24664.003 X-MDID: 1560152335-CLYV2-Z77bY2 Subject: [dpdk-dev] [PATCH 00/29] net/sfc/base: update base driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
net/sfc/base: update base driver
|
|
Message
Andrew Rybchenko
June 10, 2019, 7:38 a.m. UTC
checkpatches.sh generates warnings/errors because of a bit different coding style in base driver. Andrew Lee (1): net/sfc/base: fix signed/unsigned mismatch errors Andrew Rybchenko (2): net/sfc/base: do not rely on indirect header inclusion net/sfc/base: update MCDI headers Gautam Dawar (14): net/sfc/base: enable chained multicast on all EF10 cards net/sfc/base: export the zero-based MCDI port number net/sfc/base: introduce of EVB module for SR-IOV support net/sfc/base: add MCDI wrappers for vPort and vSwitch in EVB net/sfc/base: add EVB module vSwitch/vPort/vAdaptor ops net/sfc/base: implement vSwitch create/destroy net/sfc/base: factor out upstream port vAdaptor allocation net/sfc/base: support data path with EVB module net/sfc/base: support proxy auth operations for SR-IOV net/sfc/base: implement proxy auth MCDI event handling net/sfc/base: provide proxy APIs to client drivers net/sfc/base: provide APIs to configure and reset vPort net/sfc/base: provide API to fetch vPort statistics net/sfc/base: add APIs for PTP privilege configuration Kevin Lampis (1): net/sfc/base: add definition of OEM TLV Mark Spender (2): net/sfc/base: fix shift by more bits than field width net/sfc/base: improve code style in sensors decoding Paul Fox (1): net/sfc/base: add definition of bundle metadata partition Richard Houldsworth (8): net/sfc/base: add driver version string registration net/sfc/base: add capabilities for bundle partition support net/sfc/base: add extensible NVRAM info function net/sfc/base: add NVRAM info to API net/sfc/base: add firmware ID header net/sfc/base: support direct FW update for bundle partitions net/sfc/base: transition to the extensible NVRAM info API net/sfc/base: add background mode firmware updating drivers/net/sfc/Makefile | 4 + drivers/net/sfc/base/ef10_ev.c | 7 + drivers/net/sfc/base/ef10_evb.c | 553 ++++++++++ drivers/net/sfc/base/ef10_filter.c | 3 +- drivers/net/sfc/base/ef10_firmware_ids.h | 184 ++++ drivers/net/sfc/base/ef10_image.c | 74 +- drivers/net/sfc/base/ef10_impl.h | 163 +++ drivers/net/sfc/base/ef10_nic.c | 212 +++- drivers/net/sfc/base/ef10_nvram.c | 110 +- drivers/net/sfc/base/ef10_proxy.c | 474 ++++++++ drivers/net/sfc/base/ef10_rx.c | 4 +- drivers/net/sfc/base/ef10_tlv_layout.h | 35 + drivers/net/sfc/base/ef10_tx.c | 2 +- drivers/net/sfc/base/ef10_vpd.c | 7 +- drivers/net/sfc/base/efx.h | 223 +++- drivers/net/sfc/base/efx_check.h | 16 +- drivers/net/sfc/base/efx_evb.c | 544 ++++++++++ drivers/net/sfc/base/efx_impl.h | 112 +- drivers/net/sfc/base/efx_mcdi.c | 92 +- drivers/net/sfc/base/efx_mcdi.h | 9 +- drivers/net/sfc/base/efx_nic.c | 35 + drivers/net/sfc/base/efx_nvram.c | 104 +- drivers/net/sfc/base/efx_proxy.c | 364 +++++++ drivers/net/sfc/base/efx_regs_mcdi.h | 1667 ++++++++++++++++++++++++++++- drivers/net/sfc/base/efx_regs_mcdi_aoe.h | 13 + drivers/net/sfc/base/efx_regs_mcdi_strs.h | 174 +-- drivers/net/sfc/base/hunt_nic.c | 41 +- drivers/net/sfc/base/mcdi_mon.c | 27 +- drivers/net/sfc/base/medford2_nic.c | 3 - drivers/net/sfc/base/medford_nic.c | 3 - drivers/net/sfc/base/meson.build | 4 + drivers/net/sfc/base/siena_impl.h | 6 + drivers/net/sfc/base/siena_nvram.c | 34 +- drivers/net/sfc/efsys.h | 4 + 34 files changed, 4985 insertions(+), 322 deletions(-) create mode 100644 drivers/net/sfc/base/ef10_evb.c create mode 100644 drivers/net/sfc/base/ef10_firmware_ids.h create mode 100644 drivers/net/sfc/base/ef10_proxy.c create mode 100644 drivers/net/sfc/base/efx_evb.c create mode 100644 drivers/net/sfc/base/efx_proxy.c
Comments
On 6/10/2019 8:38 AM, Andrew Rybchenko wrote: > checkpatches.sh generates warnings/errors because of a bit different > coding style in base driver. > > Andrew Lee (1): > net/sfc/base: fix signed/unsigned mismatch errors > > Andrew Rybchenko (2): > net/sfc/base: do not rely on indirect header inclusion > net/sfc/base: update MCDI headers > > Gautam Dawar (14): > net/sfc/base: enable chained multicast on all EF10 cards > net/sfc/base: export the zero-based MCDI port number > net/sfc/base: introduce of EVB module for SR-IOV support > net/sfc/base: add MCDI wrappers for vPort and vSwitch in EVB > net/sfc/base: add EVB module vSwitch/vPort/vAdaptor ops > net/sfc/base: implement vSwitch create/destroy > net/sfc/base: factor out upstream port vAdaptor allocation > net/sfc/base: support data path with EVB module > net/sfc/base: support proxy auth operations for SR-IOV > net/sfc/base: implement proxy auth MCDI event handling > net/sfc/base: provide proxy APIs to client drivers > net/sfc/base: provide APIs to configure and reset vPort > net/sfc/base: provide API to fetch vPort statistics > net/sfc/base: add APIs for PTP privilege configuration > > Kevin Lampis (1): > net/sfc/base: add definition of OEM TLV > > Mark Spender (2): > net/sfc/base: fix shift by more bits than field width > net/sfc/base: improve code style in sensors decoding > > Paul Fox (1): > net/sfc/base: add definition of bundle metadata partition > > Richard Houldsworth (8): > net/sfc/base: add driver version string registration > net/sfc/base: add capabilities for bundle partition support > net/sfc/base: add extensible NVRAM info function > net/sfc/base: add NVRAM info to API > net/sfc/base: add firmware ID header > net/sfc/base: support direct FW update for bundle partitions > net/sfc/base: transition to the extensible NVRAM info API > net/sfc/base: add background mode firmware updating Series applied to dpdk-next-net/master, thanks. Fixed following checkpatch warnings while merging: ERROR:SPACING: space required before the open brace '{' #49: FILE: drivers/net/sfc/base/mcdi_mon.c:85: + (efx_mon_get_stat_portmap(id, &stat_portmask) != B_TRUE)){ WARNING:TYPO_SPELLING: 'paramter' may be misspelled - perhaps 'parameter'? #1: identifier and hence this paramter is unused for EF10 architecture WARNING:TYPO_SPELLING: 'initilization' may be misspelled - perhaps 'initialization'? #13: the changes in NIC initilization flow.
18/06/2019 09:52, Ferruh Yigit: > On 6/10/2019 8:38 AM, Andrew Rybchenko wrote: > > checkpatches.sh generates warnings/errors because of a bit different > > coding style in base driver. [...] > Series applied to dpdk-next-net/master, thanks. > > Fixed following checkpatch warnings while merging: There are a lot more checkpatch warnings in this code. Is it possible to fix the style of the code in the sfc/base directory? Or we prefer to continue with so many checkpatch warnings?
Hi Thomas, On 6/24/19 1:37 AM, Thomas Monjalon wrote: > 18/06/2019 09:52, Ferruh Yigit: >> On 6/10/2019 8:38 AM, Andrew Rybchenko wrote: >>> checkpatches.sh generates warnings/errors because of a bit different >>> coding style in base driver. > [...] >> Series applied to dpdk-next-net/master, thanks. >> >> Fixed following checkpatch warnings while merging: > There are a lot more checkpatch warnings in this code. > Is it possible to fix the style of the code in the sfc/base directory? > Or we prefer to continue with so many checkpatch warnings? In short: I'm trying to minimize a number of warnings, but it is not always possible. I'll pay even more attention to it in the future. The base driver is used for other OS drivers and coding style in the base driver is a common denominator of their coding styles plus some kind of established practices. Unfortunately some points in coding style in FreeBSD and GLD (Solaris) contradict to DPDK coding style. Of course, there is a grey area and we're trying to avoid checkpatches.sh warning there. Sometimes even changing existing practices, but anyway major changes of coding style in existing sources is not a good idea.
On 6/24/2019 8:53 AM, Andrew Rybchenko wrote: > Hi Thomas, > > On 6/24/19 1:37 AM, Thomas Monjalon wrote: >> 18/06/2019 09:52, Ferruh Yigit: >>> On 6/10/2019 8:38 AM, Andrew Rybchenko wrote: >>>> checkpatches.sh generates warnings/errors because of a bit different >>>> coding style in base driver. >> [...] >>> Series applied to dpdk-next-net/master, thanks. >>> >>> Fixed following checkpatch warnings while merging: >> There are a lot more checkpatch warnings in this code. >> Is it possible to fix the style of the code in the sfc/base directory? >> Or we prefer to continue with so many checkpatch warnings? > > In short: I'm trying to minimize a number of warnings, but it is not always > possible. I'll pay even more attention to it in the future. There are a few known syntax differences between DPDK and sfc/base/*, most of the warnings are from those, at least I am OK with them as long as the syntax is consistent in sfc/base/* which seems the case, I believe this is better than having a mixture of two different syntax in the code.
24/06/2019 13:17, Ferruh Yigit: > On 6/24/2019 8:53 AM, Andrew Rybchenko wrote: > > Hi Thomas, > > > > On 6/24/19 1:37 AM, Thomas Monjalon wrote: > >> 18/06/2019 09:52, Ferruh Yigit: > >>> On 6/10/2019 8:38 AM, Andrew Rybchenko wrote: > >>>> checkpatches.sh generates warnings/errors because of a bit different > >>>> coding style in base driver. > >> [...] > >>> Series applied to dpdk-next-net/master, thanks. > >>> > >>> Fixed following checkpatch warnings while merging: > >> There are a lot more checkpatch warnings in this code. > >> Is it possible to fix the style of the code in the sfc/base directory? > >> Or we prefer to continue with so many checkpatch warnings? > > > > In short: I'm trying to minimize a number of warnings, but it is not always > > possible. I'll pay even more attention to it in the future. > > There are a few known syntax differences between DPDK and sfc/base/*, most of > the warnings are from those, > > at least I am OK with them as long as the syntax is consistent in sfc/base/* > which seems the case, I believe this is better than having a mixture of two > different syntax in the code. OK thanks for the answers