diff mbox series

[v1,7/9] cpt: mark internal functions with __rte_internal

Message ID 20190612203903.16565-8-nhorman@tuxdriver.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series dpdk: introduce __rte_internal tag |

Checks

Context Check Description
ci/Intel-compilation fail Compilation issues
ci/checkpatch success coding style OK

Commit Message

Neil Horman June 12, 2019, 8:39 p.m. UTC 
  Identify functions in the cpt driver which are internal (based on
their not having an rte_ prefix) and tag them with __rte_internal

Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
CC: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
CC: Bruce Richardson <bruce.richardson@intel.com>
CC: Thomas Monjalon <thomas@monjalon.net>
CC: Anoob Joseph <anoobj@marvell.com>
---
 drivers/common/cpt/cpt_pmd_ops_helper.c       | 4 ++--
 drivers/common/cpt/cpt_pmd_ops_helper.h       | 4 ++--
 drivers/common/cpt/rte_common_cpt_version.map | 6 +++++-
 3 files changed, 9 insertions(+), 5 deletions(-)

Comments

Anoob Joseph June 17, 2019, 5:27 a.m. UTC | #1 
> -----Original Message-----
> From: Neil Horman <nhorman@tuxdriver.com>
> Sent: Thursday, June 13, 2019 2:09 AM
> To: dev@dpdk.org
> Cc: Neil Horman <nhorman@tuxdriver.com>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; Bruce Richardson <bruce.richardson@intel.com>;
> Thomas Monjalon <thomas@monjalon.net>; Anoob Joseph
> <anoobj@marvell.com>
> Subject: [EXT] [PATCH v1 7/9] cpt: mark internal functions with
> __rte_internal
> 
> External Email
> 
> ----------------------------------------------------------------------
> Identify functions in the cpt driver which are internal (based on their not
> having an rte_ prefix) and tag them with __rte_internal
> 
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> CC: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> CC: Bruce Richardson <bruce.richardson@intel.com>
> CC: Thomas Monjalon <thomas@monjalon.net>
> CC: Anoob Joseph <anoobj@marvell.com>
> ---
>  drivers/common/cpt/cpt_pmd_ops_helper.c       | 4 ++--
>  drivers/common/cpt/cpt_pmd_ops_helper.h       | 4 ++--
>  drivers/common/cpt/rte_common_cpt_version.map | 6 +++++-
>  3 files changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/common/cpt/cpt_pmd_ops_helper.c
> b/drivers/common/cpt/cpt_pmd_ops_helper.c
> index 1c18180f8..d8c7add66 100644
> --- a/drivers/common/cpt/cpt_pmd_ops_helper.c
> +++ b/drivers/common/cpt/cpt_pmd_ops_helper.c
> @@ -13,7 +13,7 @@
>  #define CPT_OFFSET_CONTROL_BYTES 8
> 
>  int32_t
> -cpt_pmd_ops_helper_get_mlen_direct_mode(void)
> +__rte_internal cpt_pmd_ops_helper_get_mlen_direct_mode(void)
>  {
>  	uint32_t len = 0;
> 
> @@ -27,7 +27,7 @@ cpt_pmd_ops_helper_get_mlen_direct_mode(void)
>  }
> 
>  int
> -cpt_pmd_ops_helper_get_mlen_sg_mode(void)
> +__rte_internal cpt_pmd_ops_helper_get_mlen_sg_mode(void)
>  {
>  	uint32_t len = 0;
> 
> diff --git a/drivers/common/cpt/cpt_pmd_ops_helper.h
> b/drivers/common/cpt/cpt_pmd_ops_helper.h
> index dd32f9a40..314e3871b 100644
> --- a/drivers/common/cpt/cpt_pmd_ops_helper.h
> +++ b/drivers/common/cpt/cpt_pmd_ops_helper.h
> @@ -20,7 +20,7 @@
>   */
> 
>  int32_t
> -cpt_pmd_ops_helper_get_mlen_direct_mode(void);
> +__rte_internal cpt_pmd_ops_helper_get_mlen_direct_mode(void);
> 
>  /*
>   * Get size of contiguous meta buffer to be allocated when working in
> scatter @@ -30,5 +30,5 @@
> cpt_pmd_ops_helper_get_mlen_direct_mode(void);
>   *   - length
>   */
>  int
> -cpt_pmd_ops_helper_get_mlen_sg_mode(void);
> +__rte_internal cpt_pmd_ops_helper_get_mlen_sg_mode(void);
>  #endif /* _CPT_PMD_OPS_HELPER_H_ */
> diff --git a/drivers/common/cpt/rte_common_cpt_version.map
> b/drivers/common/cpt/rte_common_cpt_version.map
> index dec614f0d..7459d551b 100644
> --- a/drivers/common/cpt/rte_common_cpt_version.map
> +++ b/drivers/common/cpt/rte_common_cpt_version.map
> @@ -1,6 +1,10 @@
> -DPDK_18.11 {
> +INTERNAL {
>  	global:
> 
>  	cpt_pmd_ops_helper_get_mlen_direct_mode;
>  	cpt_pmd_ops_helper_get_mlen_sg_mode;
>  };
> +
> +DPDK_18.11 {
> +	local: *;
> +};
> --
> 2.20.1

Acked-by: Anoob Joseph <anoobj@marvell.com>
diff mbox series

Patch

diff --git a/drivers/common/cpt/cpt_pmd_ops_helper.c b/drivers/common/cpt/cpt_pmd_ops_helper.c
index 1c18180f8..d8c7add66 100644
--- a/drivers/common/cpt/cpt_pmd_ops_helper.c
+++ b/drivers/common/cpt/cpt_pmd_ops_helper.c
@@ -13,7 +13,7 @@ 
 #define CPT_OFFSET_CONTROL_BYTES 8
 
 int32_t
-cpt_pmd_ops_helper_get_mlen_direct_mode(void)
+__rte_internal cpt_pmd_ops_helper_get_mlen_direct_mode(void)
 {
 	uint32_t len = 0;
 
@@ -27,7 +27,7 @@  cpt_pmd_ops_helper_get_mlen_direct_mode(void)
 }
 
 int
-cpt_pmd_ops_helper_get_mlen_sg_mode(void)
+__rte_internal cpt_pmd_ops_helper_get_mlen_sg_mode(void)
 {
 	uint32_t len = 0;
 
diff --git a/drivers/common/cpt/cpt_pmd_ops_helper.h b/drivers/common/cpt/cpt_pmd_ops_helper.h
index dd32f9a40..314e3871b 100644
--- a/drivers/common/cpt/cpt_pmd_ops_helper.h
+++ b/drivers/common/cpt/cpt_pmd_ops_helper.h
@@ -20,7 +20,7 @@ 
  */
 
 int32_t
-cpt_pmd_ops_helper_get_mlen_direct_mode(void);
+__rte_internal cpt_pmd_ops_helper_get_mlen_direct_mode(void);
 
 /*
  * Get size of contiguous meta buffer to be allocated when working in scatter
@@ -30,5 +30,5 @@  cpt_pmd_ops_helper_get_mlen_direct_mode(void);
  *   - length
  */
 int
-cpt_pmd_ops_helper_get_mlen_sg_mode(void);
+__rte_internal cpt_pmd_ops_helper_get_mlen_sg_mode(void);
 #endif /* _CPT_PMD_OPS_HELPER_H_ */
diff --git a/drivers/common/cpt/rte_common_cpt_version.map b/drivers/common/cpt/rte_common_cpt_version.map
index dec614f0d..7459d551b 100644
--- a/drivers/common/cpt/rte_common_cpt_version.map
+++ b/drivers/common/cpt/rte_common_cpt_version.map
@@ -1,6 +1,10 @@ 
-DPDK_18.11 {
+INTERNAL {
 	global:
 
 	cpt_pmd_ops_helper_get_mlen_direct_mode;
 	cpt_pmd_ops_helper_get_mlen_sg_mode;
 };
+
+DPDK_18.11 {
+	local: *;
+};