meson: Update flags and values for ppc_64
Checks
Commit Message
Setting RTE_MAX_LCORE to reflect the largest available configuration.
Adding defines for missing RTE_MACHINE_CPUFLAGs.
Signed-off-by: David Wilder <dwilder@us.ibm.com>
---
config/ppc_64/meson.build | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Comments
On Fri, May 24, 2019 at 09:04:04AM -0700, David Wilder wrote:
> Setting RTE_MAX_LCORE to reflect the largest available configuration.
> Adding defines for missing RTE_MACHINE_CPUFLAGs.
>
> Signed-off-by: David Wilder <dwilder@us.ibm.com>
> ---
> config/ppc_64/meson.build | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/config/ppc_64/meson.build b/config/ppc_64/meson.build
> index 7ceae1d..0e65f9d 100644
> --- a/config/ppc_64/meson.build
> +++ b/config/ppc_64/meson.build
> @@ -8,6 +8,8 @@ dpdk_conf.set('RTE_ARCH', 'ppc_64')
> dpdk_conf.set('RTE_ARCH_PPC_64', 1)
>
> # overrides specific to ppc64
> -dpdk_conf.set('RTE_MAX_LCORE', 256)
> +dpdk_conf.set('RTE_MAX_LCORE', 1536)
> dpdk_conf.set('RTE_MAX_NUMA_NODES', 32)
> dpdk_conf.set('RTE_CACHE_LINE_SIZE', 128)
> +dpdk_conf.set('RTE_MACHINE_CPUFLAG_ALTIVEC', 1)
> +dpdk_conf.set('RTE_MACHINE_CPUFLAG_VSX', 1)
> --
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
27/05/2019 11:41, Bruce Richardson:
> On Fri, May 24, 2019 at 09:04:04AM -0700, David Wilder wrote:
> > Setting RTE_MAX_LCORE to reflect the largest available configuration.
> > Adding defines for missing RTE_MACHINE_CPUFLAGs.
> >
> > Signed-off-by: David Wilder <dwilder@us.ibm.com>
> > ---
> > --- a/config/ppc_64/meson.build
> > +++ b/config/ppc_64/meson.build
> > # overrides specific to ppc64
> > -dpdk_conf.set('RTE_MAX_LCORE', 256)
> > +dpdk_conf.set('RTE_MAX_LCORE', 1536)
> > dpdk_conf.set('RTE_MAX_NUMA_NODES', 32)
> > dpdk_conf.set('RTE_CACHE_LINE_SIZE', 128)
> > +dpdk_conf.set('RTE_MACHINE_CPUFLAG_ALTIVEC', 1)
> > +dpdk_conf.set('RTE_MACHINE_CPUFLAG_VSX', 1)
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Suggested title:
config: update for ppc build with meson
Why config/defconfig_ppc_64-power8-linuxapp-gcc is not updated as well
for RTE_MAX_LCORE?
On 2019-06-03 15:30, Thomas Monjalon wrote:
> 27/05/2019 11:41, Bruce Richardson:
>> On Fri, May 24, 2019 at 09:04:04AM -0700, David Wilder wrote:
>> > Setting RTE_MAX_LCORE to reflect the largest available configuration.
>> > Adding defines for missing RTE_MACHINE_CPUFLAGs.
>> >
>> > Signed-off-by: David Wilder <dwilder@us.ibm.com>
>> > ---
>> > --- a/config/ppc_64/meson.build
>> > +++ b/config/ppc_64/meson.build
>> > # overrides specific to ppc64
>> > -dpdk_conf.set('RTE_MAX_LCORE', 256)
>> > +dpdk_conf.set('RTE_MAX_LCORE', 1536)
>> > dpdk_conf.set('RTE_MAX_NUMA_NODES', 32)
>> > dpdk_conf.set('RTE_CACHE_LINE_SIZE', 128)
>> > +dpdk_conf.set('RTE_MACHINE_CPUFLAG_ALTIVEC', 1)
>> > +dpdk_conf.set('RTE_MACHINE_CPUFLAG_VSX', 1)
>>
>> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
>
> Suggested title:
> config: update for ppc build with meson
>
> Why config/defconfig_ppc_64-power8-linuxapp-gcc is not updated as well
> for RTE_MAX_LCORE?
Hi Thomas
I am taking the opportunity to update RTE_MAX_LCORE for future releases
of dpdk. As we are switching to meson builds soon so this is an
appropriate opportunity to update the value and keep in step with the
hardware. Older stable release can continue to use the smaller value
found in deconfig..
04/06/2019 22:25, dwilder:
> On 2019-06-03 15:30, Thomas Monjalon wrote:
> > 27/05/2019 11:41, Bruce Richardson:
> >> On Fri, May 24, 2019 at 09:04:04AM -0700, David Wilder wrote:
> >> > Setting RTE_MAX_LCORE to reflect the largest available configuration.
> >> > Adding defines for missing RTE_MACHINE_CPUFLAGs.
> >> >
> >> > Signed-off-by: David Wilder <dwilder@us.ibm.com>
> >> > ---
> >> > --- a/config/ppc_64/meson.build
> >> > +++ b/config/ppc_64/meson.build
> >> > # overrides specific to ppc64
> >> > -dpdk_conf.set('RTE_MAX_LCORE', 256)
> >> > +dpdk_conf.set('RTE_MAX_LCORE', 1536)
> >> > dpdk_conf.set('RTE_MAX_NUMA_NODES', 32)
> >> > dpdk_conf.set('RTE_CACHE_LINE_SIZE', 128)
> >> > +dpdk_conf.set('RTE_MACHINE_CPUFLAG_ALTIVEC', 1)
> >> > +dpdk_conf.set('RTE_MACHINE_CPUFLAG_VSX', 1)
> >>
> >> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> >
> >
> > Suggested title:
> > config: update for ppc build with meson
> >
> > Why config/defconfig_ppc_64-power8-linuxapp-gcc is not updated as well
> > for RTE_MAX_LCORE?
>
> Hi Thomas
> I am taking the opportunity to update RTE_MAX_LCORE for future releases
> of dpdk. As we are switching to meson builds soon so this is an
> appropriate opportunity to update the value and keep in step with the
> hardware. Older stable release can continue to use the smaller value
> found in deconfig..
I don't understand the logic.
You are updating only the new release.
Some users may use make and others meson.
There is no reason they don't have the same config.
On 2019-06-04 14:04, Thomas Monjalon wrote:
> 04/06/2019 22:25, dwilder:
>> On 2019-06-03 15:30, Thomas Monjalon wrote:
>> > 27/05/2019 11:41, Bruce Richardson:
>> >> On Fri, May 24, 2019 at 09:04:04AM -0700, David Wilder wrote:
>> >> > Setting RTE_MAX_LCORE to reflect the largest available configuration.
>> >> > Adding defines for missing RTE_MACHINE_CPUFLAGs.
>> >> >
>> >> > Signed-off-by: David Wilder <dwilder@us.ibm.com>
>> >> > ---
>> >> > --- a/config/ppc_64/meson.build
>> >> > +++ b/config/ppc_64/meson.build
>> >> > # overrides specific to ppc64
>> >> > -dpdk_conf.set('RTE_MAX_LCORE', 256)
>> >> > +dpdk_conf.set('RTE_MAX_LCORE', 1536)
>> >> > dpdk_conf.set('RTE_MAX_NUMA_NODES', 32)
>> >> > dpdk_conf.set('RTE_CACHE_LINE_SIZE', 128)
>> >> > +dpdk_conf.set('RTE_MACHINE_CPUFLAG_ALTIVEC', 1)
>> >> > +dpdk_conf.set('RTE_MACHINE_CPUFLAG_VSX', 1)
>> >>
>> >> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>> >
>> >
>> > Suggested title:
>> > config: update for ppc build with meson
>> >
>> > Why config/defconfig_ppc_64-power8-linuxapp-gcc is not updated as well
>> > for RTE_MAX_LCORE?
>>
>> Hi Thomas
>> I am taking the opportunity to update RTE_MAX_LCORE for future
>> releases
>> of dpdk. As we are switching to meson builds soon so this is an
>> appropriate opportunity to update the value and keep in step with the
>> hardware. Older stable release can continue to use the smaller value
>> found in deconfig..
>
> I don't understand the logic.
> You are updating only the new release.
> Some users may use make and others meson.
> There is no reason they don't have the same config.
Fair enough, if make will continue to be supported then both methods
need updating. I will resubmit with you suggestions.
@@ -8,6 +8,8 @@ dpdk_conf.set('RTE_ARCH', 'ppc_64')
dpdk_conf.set('RTE_ARCH_PPC_64', 1)
# overrides specific to ppc64
-dpdk_conf.set('RTE_MAX_LCORE', 256)
+dpdk_conf.set('RTE_MAX_LCORE', 1536)
dpdk_conf.set('RTE_MAX_NUMA_NODES', 32)
dpdk_conf.set('RTE_CACHE_LINE_SIZE', 128)
+dpdk_conf.set('RTE_MACHINE_CPUFLAG_ALTIVEC', 1)
+dpdk_conf.set('RTE_MACHINE_CPUFLAG_VSX', 1)