Message ID | 1553768834-19072-1-git-send-email-ayverma@marvell.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 42B3C4C8D; Thu, 28 Mar 2019 11:27:57 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id DDF8C4C88 for <dev@dpdk.org>; Thu, 28 Mar 2019 11:27:55 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x2SAPSYG030060; Thu, 28 Mar 2019 03:27:55 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=IDW6j+xxfAPzl23/GbPA9Uz9htnbDugjxv7wQcAZi/w=; b=u72wtmWXYS1rdcXV/tnkgiGcZYcLFONKUOZ/fv42NKjsrPAG+GYVkx0mEjIgyAX8A66k mJE1jVDXsrdpl2zhit/G14e9gBpNnv22OOkplLiylTnONr1rDV8qxwonZ284vO0Xbc7l lGUuRPwf0A4YAEoTg7v07AJA1XjA+HqZawL1PrtKI2v3UqyFXVy5wN1Y7Du7qDBD3viN s4vjq4A91E+8RBmt+1B23P61P8NdvDlasMYZk8G76FjomwBoc09je8fj58YPfyFTomSo lqktHDYbVAAwP1+nBCaM2JJIcUZs4nqybZdApBAzjAwIZHqQ6JdUdyfmu9+XP9+egnAe XQ== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 2rgfn5a79x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 28 Mar 2019 03:27:54 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 28 Mar 2019 03:27:53 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.50) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 28 Mar 2019 03:27:53 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IDW6j+xxfAPzl23/GbPA9Uz9htnbDugjxv7wQcAZi/w=; b=i6dfujS7lbogkwvSiclk2M4XIYkIJJyurJHdwOyBhl3QUT2mlqHvEWgZxKgEfJmaMA4G2xCes8ZhTjdRjsDU8RPXs7uG/BqqkWbJb9q82hPFbb0cLWqikqGOtz/in77yakYOzIh2KRN5/x5cvircCvQy7DFeHQBfhOM56sYdgRk= Received: from MN2PR18MB2542.namprd18.prod.outlook.com (20.179.82.221) by MN2PR18MB2733.namprd18.prod.outlook.com (20.179.21.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.15; Thu, 28 Mar 2019 10:27:52 +0000 Received: from MN2PR18MB2542.namprd18.prod.outlook.com ([fe80::ecb7:6a6e:f852:3d90]) by MN2PR18MB2542.namprd18.prod.outlook.com ([fe80::ecb7:6a6e:f852:3d90%6]) with mapi id 15.20.1750.014; Thu, 28 Mar 2019 10:27:52 +0000 From: Ayuj Verma <ayverma@marvell.com> To: "akhil.goyal@nxp.com" <akhil.goyal@nxp.com> CC: "arkadiuszx.kusztal@intel.com" <arkadiuszx.kusztal@intel.com>, "Shally Verma" <shallyv@marvell.com>, Sunila Sahu <ssahu@marvell.com>, "Kanaka Durga Kotamarthy" <kkotamarthy@marvell.com>, Arvind Desai <adesai@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>, Ayuj Verma <ayverma@marvell.com> Thread-Topic: [PATCH v3 0/4] adding rsa priv key feature flag Thread-Index: AQHU5VDmFr4Qf/EZl0y7lnKudFqeNA== Date: Thu, 28 Mar 2019 10:27:52 +0000 Message-ID: <1553768834-19072-1-git-send-email-ayverma@marvell.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BM1PR01CA0150.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:68::20) To MN2PR18MB2542.namprd18.prod.outlook.com (2603:10b6:208:103::29) x-mailer: git-send-email 1.8.3.1 x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [49.200.218.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8299cb10-977d-4a8d-e38e-08d6b3680863 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600127)(711020)(4605104)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:MN2PR18MB2733; x-ms-traffictypediagnostic: MN2PR18MB2733: x-microsoft-antispam-prvs: <MN2PR18MB2733AF75F1A8D34F5C4A79C7AD590@MN2PR18MB2733.namprd18.prod.outlook.com> x-forefront-prvs: 0990C54589 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(39860400002)(366004)(396003)(136003)(346002)(199004)(189003)(3846002)(6436002)(8676002)(81166006)(186003)(2616005)(476003)(105586002)(81156014)(106356001)(26005)(36756003)(107886003)(2501003)(486006)(86362001)(8936002)(2351001)(7736002)(71190400001)(53936002)(50226002)(4326008)(102836004)(71200400001)(55236004)(386003)(6506007)(5640700003)(6916009)(97736004)(99286004)(25786009)(6512007)(305945005)(5660300002)(68736007)(4720700003)(478600001)(66066001)(316002)(256004)(6116002)(2906002)(6486002)(14444005)(14454004)(54906003)(52116002); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2733; H:MN2PR18MB2542.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: OrEvKTjxzy5RvcjBomeFjnQHf/8h0KZPZ6FSpenweeORGv7qOD80Uhc5HdSwi+CKnFXuN9iwL9ouxU/LLmaqLUN8L1+e6I501swXE+NZ3qdILFv2FxePUoHS2p3OQYQS2UmJybqOS/3mGO1+LIghUJ8vtSU7sRS5RtvqDavQJ1mVv1fDzCncfI/8/5MM1ItUVOtikc9ywbXfnB7L+3JcTGyTFtrY1dNa+N47EFlcOU2v9JcmutSoinbkopAlJo2DV4Rb4W/ABhnpi3K57nsid5kTZQAd2S/X7oxBCr7skfGnwlRF1qL6yW2uhv5/hdrbvWGdpWPxIZiEE2W7W6XTfyB9i1whDAGU4sqAMVyka5E0FHNSlJgjUz1XalF+//bi4CmyutTusDKy200KqNnU6Rn9yHU6bMsweW5OMctaiL8= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 8299cb10-977d-4a8d-e38e-08d6b3680863 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2019 10:27:52.3182 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2733 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-03-28_05:, , signatures=0 Subject: [dpdk-dev] [PATCH v3 0/4] adding rsa priv key feature flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series | adding rsa priv key feature flag | |
Message
Ayuj Verma
March 28, 2019, 10:27 a.m. UTC
Some PMDs can support RSA private key operations using CRT (quintuple) or exponent key only. Thus add a feature flag RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_EXP and RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_QT in PMD to reflect which key type is supported to perform rsa private key op. App should query PMD feature flag to check if specific key type is supported and call operation with relevant key type. Changes in v3: - Rebase changes on top of latest unit test application - add feature flag description in documentation Changes in v2: - RSA key type feature flags exponenet and quintuple, in place of making them part of xform capabilities. Ayuj Verma (4): lib/cryptodev: add rsa priv key feature flag crypto/openssl: set rsa private op feature flag app/test: check for key type ff in asym unit test doc: add rsa key type to feature list app/test/test_cryptodev_asym.c | 26 ++++++++++++++++++++++++++ doc/guides/cryptodevs/features/openssl.ini | 2 ++ doc/guides/cryptodevs/overview.rst | 6 ++++++ drivers/crypto/openssl/rte_openssl_pmd.c | 4 +++- lib/librte_cryptodev/rte_cryptodev.c | 4 ++++ lib/librte_cryptodev/rte_cryptodev.h | 4 ++++ 6 files changed, 45 insertions(+), 1 deletion(-)
Comments
On 3/28/2019 3:57 PM, Ayuj Verma wrote: > Some PMDs can support RSA private key operations using CRT > (quintuple) or exponent key only. Thus add a feature flag > RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_EXP and > RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_QT in PMD to reflect which key > type is supported to perform rsa private key op. > > App should query PMD feature flag to check if specific > key type is supported and call operation with relevant key type. > > Changes in v3: > - Rebase changes on top of latest unit test application > - add feature flag description in documentation > > Changes in v2: > - RSA key type feature flags exponenet and quintuple, > in place of making them part of xform capabilities. > > Ayuj Verma (4): > lib/cryptodev: add rsa priv key feature flag > crypto/openssl: set rsa private op feature flag > app/test: check for key type ff in asym unit test > doc: add rsa key type to feature list > > app/test/test_cryptodev_asym.c | 26 ++++++++++++++++++++++++++ > doc/guides/cryptodevs/features/openssl.ini | 2 ++ > doc/guides/cryptodevs/overview.rst | 6 ++++++ > drivers/crypto/openssl/rte_openssl_pmd.c | 4 +++- > lib/librte_cryptodev/rte_cryptodev.c | 4 ++++ > lib/librte_cryptodev/rte_cryptodev.h | 4 ++++ > 6 files changed, 45 insertions(+), 1 deletion(-) > Series- Acked-by: Akhil Goyal <akhil.goyal@nxp.com> doc patch should be merged in previous patches. Will do it while merging. Thanks.
On 3/28/2019 3:57 PM, Ayuj Verma wrote: > Some PMDs can support RSA private key operations using CRT > (quintuple) or exponent key only. Thus add a feature flag > RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_EXP and > RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_QT in PMD to reflect which key > type is supported to perform rsa private key op. > > App should query PMD feature flag to check if specific > key type is supported and call operation with relevant key type. > > Changes in v3: > - Rebase changes on top of latest unit test application > - add feature flag description in documentation > > Changes in v2: > - RSA key type feature flags exponenet and quintuple, > in place of making them part of xform capabilities. > > Ayuj Verma (4): > lib/cryptodev: add rsa priv key feature flag > crypto/openssl: set rsa private op feature flag > app/test: check for key type ff in asym unit test > doc: add rsa key type to feature list > > app/test/test_cryptodev_asym.c | 26 ++++++++++++++++++++++++++ > doc/guides/cryptodevs/features/openssl.ini | 2 ++ > doc/guides/cryptodevs/overview.rst | 6 ++++++ > drivers/crypto/openssl/rte_openssl_pmd.c | 4 +++- > lib/librte_cryptodev/rte_cryptodev.c | 4 ++++ > lib/librte_cryptodev/rte_cryptodev.h | 4 ++++ > 6 files changed, 45 insertions(+), 1 deletion(-) > Applied to dpdk-next-crypto 4th patch squashed to 1st and 2nd. Also added description for 3rd patch. Please add relevant information in the description in future. Thanks.
Hi Akhil, Thanks. Please add relevant information in the description in future. Sure will keep this in mind. Thanks and regards Ayuj Verma
On 3/29/2019 8:47 PM, Akhil Goyal wrote: > > On 3/28/2019 3:57 PM, Ayuj Verma wrote: >> Some PMDs can support RSA private key operations using CRT >> (quintuple) or exponent key only. Thus add a feature flag >> RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_EXP and >> RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_QT in PMD to reflect which key >> type is supported to perform rsa private key op. >> >> App should query PMD feature flag to check if specific >> key type is supported and call operation with relevant key type. >> >> Changes in v3: >> - Rebase changes on top of latest unit test application >> - add feature flag description in documentation >> >> Changes in v2: >> - RSA key type feature flags exponenet and quintuple, >> in place of making them part of xform capabilities. >> >> Ayuj Verma (4): >> lib/cryptodev: add rsa priv key feature flag >> crypto/openssl: set rsa private op feature flag >> app/test: check for key type ff in asym unit test >> doc: add rsa key type to feature list >> >> app/test/test_cryptodev_asym.c | 26 ++++++++++++++++++++++++++ >> doc/guides/cryptodevs/features/openssl.ini | 2 ++ >> doc/guides/cryptodevs/overview.rst | 6 ++++++ >> drivers/crypto/openssl/rte_openssl_pmd.c | 4 +++- >> lib/librte_cryptodev/rte_cryptodev.c | 4 ++++ >> lib/librte_cryptodev/rte_cryptodev.h | 4 ++++ >> 6 files changed, 45 insertions(+), 1 deletion(-) >> > Applied to dpdk-next-crypto > > 4th patch squashed to 1st and 2nd. > Also added description for 3rd patch. Please add relevant information in > the description in future. > > Thanks. Following errors were observed in compiling documentation Warning generate_overview_table(): Unknown feature 'RSA PRIV OP KEY EXP' in 'openssl.ini' Warning generate_overview_table(): Unknown feature 'RSA PRIV OP KEY QT' in 'openssl.ini' I corrected these byadding the two features in features/default.ini. -Akhil
Hi Akhil, Thanks. Regards Ayuj Verma