diff mbox series

app/testpmd: fix a typo.

Message ID 20190312054843.26184-1-ramirose@gmail.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series app/testpmd: fix a typo. |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS

Commit Message

Rami Rosen March 12, 2019, 5:48 a.m. UTC 
  This patch fixes a typo in test-pmd/cmdline.c:
succcessfully->successfully
Two C's are good enough for success...

Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
 app/test-pmd/cmdline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Iremonger, Bernard March 19, 2019, 5:24 p.m. UTC | #1 
Hi Rami,

> -----Original Message-----
> From: Rami Rosen [mailto:ramirose@gmail.com]
> Sent: Tuesday, March 12, 2019 5:49 AM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>; Rami Rosen <ramirose@gmail.com>
> Subject: [PATCH] app/testpmd: fix a typo.
> 
> This patch fixes a typo in test-pmd/cmdline.c:
> succcessfully->successfully
> Two C's are good enough for success...
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
>  app/test-pmd/cmdline.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> db53cc0cc..815e5e887 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -12076,7 +12076,7 @@ cmd_set_hash_global_config_parsed(void
> *parsed_result,
>  							res->port_id);
>  	else
>  		printf("Global hash configurations have been set "
> -			"succcessfully by port %d\n", res->port_id);
> +			"successfully by port %d\n", res->port_id);
>  }
> 
>  cmdline_parse_token_string_t cmd_set_hash_global_config_all =
> --
> 2.17.1
#/dpdk./devtools/check-git-log.sh -1
Wrong headline format:
        app/testpmd: fix a typo.
Wrong tag:
        This patch fixes a typo in test-pmd/cmdline.c:
Missing 'Fixes' tag:
        app/testpmd: fix a typo.

This patch should have a fixes line and "typo." seems to be causing an error.

Regards,

Bernard.
Ferruh Yigit March 19, 2019, 6:30 p.m. UTC | #2 
On 3/12/2019 5:48 AM, Rami Rosen wrote:
> This patch fixes a typo in test-pmd/cmdline.c:
> succcessfully->successfully
> Two C's are good enough for success...
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>

    Fixes: a09f3e4c5046 ("app/testpmd: add hash configuration")
    Cc: stable@dpdk.org

(fixed check-git-log.sh warnings)

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.
Iremonger, Bernard March 20, 2019, 11:19 a.m. UTC | #3 
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, March 19, 2019 6:31 PM
> To: Rami Rosen <ramirose@gmail.com>; dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix a typo.
> 
> On 3/12/2019 5:48 AM, Rami Rosen wrote:
> > This patch fixes a typo in test-pmd/cmdline.c:
> > succcessfully->successfully
> > Two C's are good enough for success...
> >
> > Signed-off-by: Rami Rosen <ramirose@gmail.com>
> 
>     Fixes: a09f3e4c5046 ("app/testpmd: add hash configuration")
>     Cc: stable@dpdk.org
> 
> (fixed check-git-log.sh warnings)
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Applied to dpdk-next-net/master, thanks.

Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
diff mbox series

Patch

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index db53cc0cc..815e5e887 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -12076,7 +12076,7 @@  cmd_set_hash_global_config_parsed(void *parsed_result,
 							res->port_id);
 	else
 		printf("Global hash configurations have been set "
-			"succcessfully by port %d\n", res->port_id);
+			"successfully by port %d\n", res->port_id);
 }
 
 cmdline_parse_token_string_t cmd_set_hash_global_config_all =