doc: fix two typos in contributing guide
Checks
Commit Message
This patch fixes two typos in the coding style part of
DPDK contributing guide:
- The header entry should have .h file instead of .c file.
- The will->This will
Fixes: 44a6dface13b ("doc: describe how to add new components")
Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
doc/guides/contributing/coding_style.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
> This patch fixes two typos in the coding style part of DPDK contributing guide:
>
> - The header entry should have .h file instead of .c file.
> - The will->This will
>
> Fixes: 44a6dface13b ("doc: describe how to add new components")
>
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
> doc/guides/contributing/coding_style.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guides/contributing/coding_style.rst
> b/doc/guides/contributing/coding_style.rst
> index d96698a73..656563dde 100644
> --- a/doc/guides/contributing/coding_style.rst
> +++ b/doc/guides/contributing/coding_style.rst
> @@ -825,10 +825,10 @@ format.
> .. code-block:: python
>
> sources = files('file1.c', ...)
> - headers = files('file1.c', ...)
> + headers = files('file1.h', ...)
>
>
> -The will build based on a number of conventions and assumptions within the
> DPDK
> +This will build based on a number of conventions and assumptions within
> +the DPDK
> itself, for example, that the library name is the same as the directory name
> in which the files are stored.
Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
15/03/2019 11:39, Kovacevic, Marko:
> > This patch fixes two typos in the coding style part of DPDK contributing guide:
> >
> > - The header entry should have .h file instead of .c file.
> > - The will->This will
> >
> > Fixes: 44a6dface13b ("doc: describe how to add new components")
+Cc: stable@dpdk.org
> > Signed-off-by: Rami Rosen <ramirose@gmail.com>
>
> Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
Applied, thanks
@@ -825,10 +825,10 @@ format.
.. code-block:: python
sources = files('file1.c', ...)
- headers = files('file1.c', ...)
+ headers = files('file1.h', ...)
-The will build based on a number of conventions and assumptions within the DPDK
+This will build based on a number of conventions and assumptions within the DPDK
itself, for example, that the library name is the same as the directory name in
which the files are stored.