[02/12] net/avp: fix incorrect rxq errors stat

Message ID 1551698315-2611-3-git-send-email-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series rxq q_errors[] statistics fixes |

Checks

Context Check Description
ci/Intel-compilation success Compilation OK

Commit Message

David Marchand March 4, 2019, 11:18 a.m. UTC
  Transmit errors must not be reported in q_errors[] which is for
reception.

Fixes: 5a5abe2de94b ("net/avp: add device statistics operations")
Cc: stable@dpdk.org
Cc: Allain Legacy <allain.legacy@windriver.com>
Cc: Matt Peters <matt.peters@windriver.com>
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 drivers/net/avp/avp_ethdev.c | 1 -
 1 file changed, 1 deletion(-)
  

Comments

Allain Legacy March 4, 2019, 12:18 p.m. UTC | #1
> -----Original Message-----
> From: David Marchand [mailto:david.marchand@redhat.com]
> Sent: Monday, March 04, 2019 6:18 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Legacy, Allain; Peters, Matt
> Subject: [PATCH 02/12] net/avp: fix incorrect rxq errors stat
> 
> Transmit errors must not be reported in q_errors[] which is for reception.
> 
> Fixes: 5a5abe2de94b ("net/avp: add device statistics operations")
> Cc: stable@dpdk.org
> Cc: Allain Legacy <allain.legacy@windriver.com>
> Cc: Matt Peters <matt.peters@windriver.com>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Acked-by:  Allain Legacy <allain.legacy@windriver.com>
  

Patch

diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c
index 09388d0..5d069a2 100644
--- a/drivers/net/avp/avp_ethdev.c
+++ b/drivers/net/avp/avp_ethdev.c
@@ -2228,7 +2228,6 @@  struct avp_queue {
 
 			stats->q_opackets[i] += txq->packets;
 			stats->q_obytes[i] += txq->bytes;
-			stats->q_errors[i] += txq->errors;
 		}
 	}