[v4,1/2] lib/librte_meter: add RFC4115 trTCM meter support
Checks
Commit Message
This patch adds support for RFC4115 trTCM meters.
Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
---
lib/librte_meter/rte_meter.c | 42 ++++++
lib/librte_meter/rte_meter.h | 233 ++++++++++++++++++++++++++++++++
lib/librte_meter/rte_meter_version.map | 9 +
3 files changed, 282 insertions(+), 2 deletions(-)
Comments
On Fri, 4 Jan 2019 13:59:42 +0000
Eelco Chaudron <echaudro@redhat.com> wrote:
> This patch adds support for RFC4115 trTCM meters.
>
> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
Fix comment formatting.
### [dpdk-dev] [PATCH v4 1/2] lib/librte_meter: add RFC4115 trTCM meter support
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#172: FILE: lib/librte_meter/rte_meter.h:59:
+/** trTCM parameters per metered traffic flow. The CIR, EIR, CBS and EBS
+parameters only count bytes of IP packets and do not include link specific
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#174: FILE: lib/librte_meter/rte_meter.h:61:
+none-zero respectively.*/
WARNING:LONG_LINE_COMMENT: line over 80 characters
#176: FILE: lib/librte_meter/rte_meter.h:63:
+ uint64_t cir; /**< Committed Information Rate (CIR). Measured in bytes per second. */
WARNING:LONG_LINE_COMMENT: line over 80 characters
#177: FILE: lib/librte_meter/rte_meter.h:64:
+ uint64_t eir; /**< Excess Information Rate (EIR). Measured in bytes per second. */
WARNING:LONG_LINE_COMMENT: line over 80 characters
#355: FILE: lib/librte_meter/rte_meter.h:406:
+ /**< Number of bytes currently available in the excess(E) token bucket */
total: 0 errors, 5 warnings, 356 lines checked
On 4 Jan 2019, at 20:42, Stephen Hemminger wrote:
> On Fri, 4 Jan 2019 13:59:42 +0000
> Eelco Chaudron <echaudro@redhat.com> wrote:
>
>> This patch adds support for RFC4115 trTCM meters.
>>
>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
>
>
>
> Fix comment formatting.
Hi Stephen, I left these warnings in on purpose, to match the existing
comment style in the file.
These specific warnings are from a structure copied from one right above
which also has the same style and line lengths.
As they are warning I though I should leave it as is, Christian what are
your thoughts on this?
>
> ### [dpdk-dev] [PATCH v4 1/2] lib/librte_meter: add RFC4115 trTCM
> meter support
>
> WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
> #172: FILE: lib/librte_meter/rte_meter.h:59:
> +/** trTCM parameters per metered traffic flow. The CIR, EIR, CBS and
> EBS
> +parameters only count bytes of IP packets and do not include link
> specific
>
> WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a
> separate line
> #174: FILE: lib/librte_meter/rte_meter.h:61:
> +none-zero respectively.*/
>
> WARNING:LONG_LINE_COMMENT: line over 80 characters
> #176: FILE: lib/librte_meter/rte_meter.h:63:
> + uint64_t cir; /**< Committed Information Rate (CIR). Measured in
> bytes per second. */
>
> WARNING:LONG_LINE_COMMENT: line over 80 characters
> #177: FILE: lib/librte_meter/rte_meter.h:64:
> + uint64_t eir; /**< Excess Information Rate (EIR). Measured in bytes
> per second. */
>
> WARNING:LONG_LINE_COMMENT: line over 80 characters
> #355: FILE: lib/librte_meter/rte_meter.h:406:
> + /**< Number of bytes currently available in the excess(E) token
> bucket */
>
> total: 0 errors, 5 warnings, 356 lines checked
> -----Original Message-----
> From: Eelco Chaudron [mailto:echaudro@redhat.com]
> Sent: Monday, January 7, 2019 7:42 AM
> To: Stephen Hemminger <stephen@networkplumber.org>; Dumitrescu,
> Cristian <cristian.dumitrescu@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4 1/2] lib/librte_meter: add RFC4115 trTCM
> meter support
>
>
>
> On 4 Jan 2019, at 20:42, Stephen Hemminger wrote:
>
> > On Fri, 4 Jan 2019 13:59:42 +0000
> > Eelco Chaudron <echaudro@redhat.com> wrote:
> >
> >> This patch adds support for RFC4115 trTCM meters.
> >>
> >> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
> >
> >
> >
> > Fix comment formatting.
>
> Hi Stephen, I left these warnings in on purpose, to match the existing
> comment style in the file.
>
> These specific warnings are from a structure copied from one right above
> which also has the same style and line lengths.
>
> As they are warning I though I should leave it as is, Christian what are
> your thoughts on this?
>
I agree with Eelco, we can later on send a patch to adjust the whole file to the latest coding standard rather than change just a few lines inconsistently.
> >
> > ### [dpdk-dev] [PATCH v4 1/2] lib/librte_meter: add RFC4115 trTCM
> > meter support
> >
> > WARNING:BLOCK_COMMENT_STYLE: Block comments use * on
> subsequent lines
> > #172: FILE: lib/librte_meter/rte_meter.h:59:
> > +/** trTCM parameters per metered traffic flow. The CIR, EIR, CBS and
> > EBS
> > +parameters only count bytes of IP packets and do not include link
> > specific
> >
> > WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a
> > separate line
> > #174: FILE: lib/librte_meter/rte_meter.h:61:
> > +none-zero respectively.*/
> >
> > WARNING:LONG_LINE_COMMENT: line over 80 characters
> > #176: FILE: lib/librte_meter/rte_meter.h:63:
> > + uint64_t cir; /**< Committed Information Rate (CIR). Measured in
> > bytes per second. */
> >
> > WARNING:LONG_LINE_COMMENT: line over 80 characters
> > #177: FILE: lib/librte_meter/rte_meter.h:64:
> > + uint64_t eir; /**< Excess Information Rate (EIR). Measured in bytes
> > per second. */
> >
> > WARNING:LONG_LINE_COMMENT: line over 80 characters
> > #355: FILE: lib/librte_meter/rte_meter.h:406:
> > + /**< Number of bytes currently available in the excess(E) token
> > bucket */
> >
> > total: 0 errors, 5 warnings, 356 lines checked
@@ -110,3 +110,45 @@ rte_meter_trtcm_config(struct rte_meter_trtcm *m,
return 0;
}
+
+int __rte_experimental
+rte_meter_trtcm_rfc4115_profile_config(
+ struct rte_meter_trtcm_rfc4115_profile *p,
+ struct rte_meter_trtcm_rfc4115_params *params)
+{
+ uint64_t hz = rte_get_tsc_hz();
+
+ /* Check input parameters */
+ if ((p == NULL) ||
+ (params == NULL) ||
+ (params->cir != 0 && params->cbs == 0) ||
+ (params->eir != 0 && params->ebs == 0))
+ return -EINVAL;
+
+ /* Initialize trTCM run-time structure */
+ p->cbs = params->cbs;
+ p->ebs = params->ebs;
+ rte_meter_get_tb_params(hz, params->cir, &p->cir_period,
+ &p->cir_bytes_per_period);
+ rte_meter_get_tb_params(hz, params->eir, &p->eir_period,
+ &p->eir_bytes_per_period);
+
+ return 0;
+}
+
+int __rte_experimental
+rte_meter_trtcm_rfc4115_config(
+ struct rte_meter_trtcm_rfc4115 *m,
+ struct rte_meter_trtcm_rfc4115_profile *p)
+{
+ /* Check input parameters */
+ if ((m == NULL) || (p == NULL))
+ return -EINVAL;
+
+ /* Initialize trTCM run-time structure */
+ m->time_tc = m->time_te = rte_get_tsc_cycles();
+ m->tc = p->cbs;
+ m->te = p->ebs;
+
+ return 0;
+}
@@ -1,3 +1,4 @@
+
/* SPDX-License-Identifier: BSD-3-Clause
* Copyright(c) 2010-2014 Intel Corporation
*/
@@ -16,6 +17,7 @@ extern "C" {
* Traffic metering algorithms:
* 1. Single Rate Three Color Marker (srTCM): defined by IETF RFC 2697
* 2. Two Rate Three Color Marker (trTCM): defined by IETF RFC 2698
+ * 3. Two Rate Three Color Marker (trTCM): defined by IETF RFC 4115
*
***/
@@ -49,10 +51,21 @@ be greater than or equal to CIR. Both CBS or EBS have to be greater than zero. *
struct rte_meter_trtcm_params {
uint64_t cir; /**< Committed Information Rate (CIR). Measured in bytes per second. */
uint64_t pir; /**< Peak Information Rate (PIR). Measured in bytes per second. */
- uint64_t cbs; /**< Committed Burst Size (CBS). Measured in byes. */
+ uint64_t cbs; /**< Committed Burst Size (CBS). Measured in bytes. */
uint64_t pbs; /**< Peak Burst Size (PBS). Measured in bytes. */
};
+/** trTCM parameters per metered traffic flow. The CIR, EIR, CBS and EBS
+parameters only count bytes of IP packets and do not include link specific
+headers. The CBS and EBS need to be greater than zero if CIR and EIR are
+none-zero respectively.*/
+struct rte_meter_trtcm_rfc4115_params {
+ uint64_t cir; /**< Committed Information Rate (CIR). Measured in bytes per second. */
+ uint64_t eir; /**< Excess Information Rate (EIR). Measured in bytes per second. */
+ uint64_t cbs; /**< Committed Burst Size (CBS). Measured in bytes. */
+ uint64_t ebs; /**< Excess Burst Size (EBS). Measured in bytes. */
+};
+
/**
* Internal data structure storing the srTCM configuration profile. Typically
* shared by multiple srTCM objects.
@@ -65,12 +78,24 @@ struct rte_meter_srtcm_profile;
*/
struct rte_meter_trtcm_profile;
+/**
+ * Internal data structure storing the trTCM RFC4115 configuration profile.
+ * Typically shared by multiple trTCM objects.
+ */
+struct rte_meter_trtcm_rfc4115_profile;
+
/** Internal data structure storing the srTCM run-time context per metered traffic flow. */
struct rte_meter_srtcm;
/** Internal data structure storing the trTCM run-time context per metered traffic flow. */
struct rte_meter_trtcm;
+/**
+ * Internal data structure storing the trTCM RFC4115 run-time context per
+ * metered traffic flow.
+ */
+struct rte_meter_trtcm_rfc4115;
+
/**
* srTCM profile configuration
*
@@ -98,6 +123,23 @@ rte_meter_srtcm_profile_config(struct rte_meter_srtcm_profile *p,
int
rte_meter_trtcm_profile_config(struct rte_meter_trtcm_profile *p,
struct rte_meter_trtcm_params *params);
+/**
+ * @warning
+ * @b EXPERIMENTAL: this API may change without prior notice
+ *
+ * trTCM RFC 4115 profile configuration
+ *
+ * @param p
+ * Pointer to pre-allocated trTCM profile data structure
+ * @param params
+ * trTCM profile parameters
+ * @return
+ * 0 upon success, error code otherwise
+ */
+int __rte_experimental
+rte_meter_trtcm_rfc4115_profile_config(
+ struct rte_meter_trtcm_rfc4115_profile *p,
+ struct rte_meter_trtcm_rfc4115_params *params);
/**
* srTCM configuration per metered traffic flow
@@ -127,6 +169,23 @@ int
rte_meter_trtcm_config(struct rte_meter_trtcm *m,
struct rte_meter_trtcm_profile *p);
+/**
+ * @warning
+ * @b EXPERIMENTAL: this API may change without prior notice
+ *
+ * trTCM RFC 4115 configuration per metered traffic flow
+ *
+ * @param m
+ * Pointer to pre-allocated trTCM data structure
+ * @param p
+ * trTCM profile. Needs to be valid.
+ * @return
+ * 0 upon success, error code otherwise
+ */
+int __rte_experimental
+rte_meter_trtcm_rfc4115_config(struct rte_meter_trtcm_rfc4115 *m,
+ struct rte_meter_trtcm_rfc4115_profile *p);
+
/**
* srTCM color blind traffic metering
*
@@ -213,6 +272,57 @@ rte_meter_trtcm_color_aware_check(struct rte_meter_trtcm *m,
uint32_t pkt_len,
enum rte_meter_color pkt_color);
+/**
+ * @warning
+ * @b EXPERIMENTAL: this API may change without prior notice
+ *
+ * trTCM RFC4115 color blind traffic metering
+ *
+ * @param m
+ * Handle to trTCM instance
+ * @param p
+ * trTCM profile specified at trTCM object creation time
+ * @param time
+ * Current CPU time stamp (measured in CPU cycles)
+ * @param pkt_len
+ * Length of the current IP packet (measured in bytes)
+ * @return
+ * Color assigned to the current IP packet
+ */
+static inline enum rte_meter_color __rte_experimental
+rte_meter_trtcm_rfc4115_color_blind_check(
+ struct rte_meter_trtcm_rfc4115 *m,
+ struct rte_meter_trtcm_rfc4115_profile *p,
+ uint64_t time,
+ uint32_t pkt_len);
+
+/**
+ * @warning
+ * @b EXPERIMENTAL: this API may change without prior notice
+ *
+ * trTCM RFC4115 color aware traffic metering
+ *
+ * @param m
+ * Handle to trTCM instance
+ * @param p
+ * trTCM profile specified at trTCM object creation time
+ * @param time
+ * Current CPU time stamp (measured in CPU cycles)
+ * @param pkt_len
+ * Length of the current IP packet (measured in bytes)
+ * @param pkt_color
+ * Input color of the current IP packet
+ * @return
+ * Color assigned to the current IP packet
+ */
+static inline enum rte_meter_color __rte_experimental
+rte_meter_trtcm_rfc4115_color_aware_check(
+ struct rte_meter_trtcm_rfc4115 *m,
+ struct rte_meter_trtcm_rfc4115_profile *p,
+ uint64_t time,
+ uint32_t pkt_len,
+ enum rte_meter_color pkt_color);
+
/*
* Inline implementation of run-time methods
*
@@ -259,13 +369,43 @@ struct rte_meter_trtcm {
uint64_t time_tc;
/**< Time of latest update of C token bucket */
uint64_t time_tp;
- /**< Time of latest update of E token bucket */
+ /**< Time of latest update of P token bucket */
uint64_t tc;
/**< Number of bytes currently available in committed(C) token bucket */
uint64_t tp;
/**< Number of bytes currently available in the peak(P) token bucket */
};
+struct rte_meter_trtcm_rfc4115_profile {
+ uint64_t cbs;
+ /**< Upper limit for C token bucket */
+ uint64_t ebs;
+ /**< Upper limit for E token bucket */
+ uint64_t cir_period;
+ /**< Number of CPU cycles for one update of C token bucket */
+ uint64_t cir_bytes_per_period;
+ /**< Number of bytes to add to C token bucket on each update */
+ uint64_t eir_period;
+ /**< Number of CPU cycles for one update of E token bucket */
+ uint64_t eir_bytes_per_period;
+ /**< Number of bytes to add to E token bucket on each update */
+};
+
+/**
+ * Internal data structure storing the trTCM RFC4115 run-time context per
+ * metered traffic flow.
+ */
+struct rte_meter_trtcm_rfc4115 {
+ uint64_t time_tc;
+ /**< Time of latest update of C token bucket */
+ uint64_t time_te;
+ /**< Time of latest update of E token bucket */
+ uint64_t tc;
+ /**< Number of bytes currently available in committed(C) token bucket */
+ uint64_t te;
+ /**< Number of bytes currently available in the excess(E) token bucket */
+};
+
static inline enum rte_meter_color
rte_meter_srtcm_color_blind_check(struct rte_meter_srtcm *m,
struct rte_meter_srtcm_profile *p,
@@ -434,6 +574,95 @@ rte_meter_trtcm_color_aware_check(struct rte_meter_trtcm *m,
return e_RTE_METER_GREEN;
}
+static inline enum rte_meter_color __rte_experimental
+rte_meter_trtcm_rfc4115_color_blind_check(
+ struct rte_meter_trtcm_rfc4115 *m,
+ struct rte_meter_trtcm_rfc4115_profile *p,
+ uint64_t time,
+ uint32_t pkt_len)
+{
+ uint64_t time_diff_tc, time_diff_te, n_periods_tc, n_periods_te, tc, te;
+
+ /* Bucket update */
+ time_diff_tc = time - m->time_tc;
+ time_diff_te = time - m->time_te;
+ n_periods_tc = time_diff_tc / p->cir_period;
+ n_periods_te = time_diff_te / p->eir_period;
+ m->time_tc += n_periods_tc * p->cir_period;
+ m->time_te += n_periods_te * p->eir_period;
+
+ tc = m->tc + n_periods_tc * p->cir_bytes_per_period;
+ if (tc > p->cbs)
+ tc = p->cbs;
+
+ te = m->te + n_periods_te * p->eir_bytes_per_period;
+ if (te > p->ebs)
+ te = p->ebs;
+
+ /* Color logic */
+ if (tc >= pkt_len) {
+ m->tc = tc - pkt_len;
+ m->te = te;
+ return e_RTE_METER_GREEN;
+ }
+ if (te >= pkt_len) {
+ m->tc = tc;
+ m->te = te - pkt_len;
+ return e_RTE_METER_YELLOW;
+ }
+
+ /* If we end up here the color is RED */
+ m->tc = tc;
+ m->te = te;
+ return e_RTE_METER_RED;
+}
+
+static inline enum rte_meter_color __rte_experimental
+rte_meter_trtcm_rfc4115_color_aware_check(
+ struct rte_meter_trtcm_rfc4115 *m,
+ struct rte_meter_trtcm_rfc4115_profile *p,
+ uint64_t time,
+ uint32_t pkt_len,
+ enum rte_meter_color pkt_color)
+{
+ uint64_t time_diff_tc, time_diff_te, n_periods_tc, n_periods_te, tc, te;
+
+ /* Bucket update */
+ time_diff_tc = time - m->time_tc;
+ time_diff_te = time - m->time_te;
+ n_periods_tc = time_diff_tc / p->cir_period;
+ n_periods_te = time_diff_te / p->eir_period;
+ m->time_tc += n_periods_tc * p->cir_period;
+ m->time_te += n_periods_te * p->eir_period;
+
+ tc = m->tc + n_periods_tc * p->cir_bytes_per_period;
+ if (tc > p->cbs)
+ tc = p->cbs;
+
+ te = m->te + n_periods_te * p->eir_bytes_per_period;
+ if (te > p->ebs)
+ te = p->ebs;
+
+ /* Color logic */
+ if ((pkt_color == e_RTE_METER_GREEN) && (tc >= pkt_len)) {
+ m->tc = tc - pkt_len;
+ m->te = te;
+ return e_RTE_METER_GREEN;
+ }
+
+ if ((pkt_color != e_RTE_METER_RED) && (te >= pkt_len)) {
+ m->tc = tc;
+ m->te = te - pkt_len;
+ return e_RTE_METER_YELLOW;
+ }
+
+ /* If we end up here the color is RED */
+ m->tc = tc;
+ m->te = te;
+ return e_RTE_METER_RED;
+}
+
+
#ifdef __cplusplus
}
#endif
@@ -17,3 +17,12 @@ DPDK_18.08 {
rte_meter_srtcm_profile_config;
rte_meter_trtcm_profile_config;
};
+
+EXPERIMENTAL {
+ global:
+
+ rte_meter_trtcm_rfc4115_color_aware_check;
+ rte_meter_trtcm_rfc4115_color_blind_check;
+ rte_meter_trtcm_rfc4115_config;
+ rte_meter_trtcm_rfc4115_profile_config;
+};