eal: remove unnecessary dirent.h include
Checks
Commit Message
Prior to this patch, the two affected .c files include <dirent.h>
unnecessarily. This commit removes the include lines.
Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
---
lib/librte_eal/common/eal_common_lcore.c | 1 -
lib/librte_eal/common/rte_service.c | 1 -
2 files changed, 2 deletions(-)
Comments
Reviewed-by: Rami Rosen <ramirose@gmail.com>
On Fri, 14 Dec 2018 at 18:43, Jeff Shaw <jeffrey.b.shaw@intel.com> wrote:
>
> Prior to this patch, the two affected .c files include <dirent.h>
> unnecessarily. This commit removes the include lines.
>
> Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
> ---
> lib/librte_eal/common/eal_common_lcore.c | 1 -
> lib/librte_eal/common/rte_service.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/lib/librte_eal/common/eal_common_lcore.c b/lib/librte_eal/common/eal_common_lcore.c
> index 3167e9d79..1cbac4228 100644
> --- a/lib/librte_eal/common/eal_common_lcore.c
> +++ b/lib/librte_eal/common/eal_common_lcore.c
> @@ -5,7 +5,6 @@
> #include <unistd.h>
> #include <limits.h>
> #include <string.h>
> -#include <dirent.h>
>
> #include <rte_errno.h>
> #include <rte_log.h>
> diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c
> index 0f3695c4b..03fde97a9 100644
> --- a/lib/librte_eal/common/rte_service.c
> +++ b/lib/librte_eal/common/rte_service.c
> @@ -7,7 +7,6 @@
> #include <inttypes.h>
> #include <limits.h>
> #include <string.h>
> -#include <dirent.h>
>
> #include <rte_compat.h>
> #include <rte_service.h>
> --
> 2.14.3
>
On 12/17/2018 3:42 PM, Rami Rosen wrote:
> On Fri, 14 Dec 2018 at 18:43, Jeff Shaw <jeffrey.b.shaw@intel.com> wrote:
>>
>> Prior to this patch, the two affected .c files include <dirent.h>
>> unnecessarily. This commit removes the include lines.
>>
>> Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
>
> Reviewed-by: Rami Rosen <ramirose@gmail.com>
>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
18/12/2018 00:58, Ferruh Yigit:
> On 12/17/2018 3:42 PM, Rami Rosen wrote:
> > On Fri, 14 Dec 2018 at 18:43, Jeff Shaw <jeffrey.b.shaw@intel.com> wrote:
> >>
> >> Prior to this patch, the two affected .c files include <dirent.h>
> >> unnecessarily. This commit removes the include lines.
> >>
> >> Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
> >
> > Reviewed-by: Rami Rosen <ramirose@gmail.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
@@ -5,7 +5,6 @@
#include <unistd.h>
#include <limits.h>
#include <string.h>
-#include <dirent.h>
#include <rte_errno.h>
#include <rte_log.h>
@@ -7,7 +7,6 @@
#include <inttypes.h>
#include <limits.h>
#include <string.h>
-#include <dirent.h>
#include <rte_compat.h>
#include <rte_service.h>