diff mbox series

net/vdev_netvsc: get rid of unnecessary debug log message

Message ID 20181120211351.17761-1-stephen@networkplumber.org (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series net/vdev_netvsc: get rid of unnecessary debug log message |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

Stephen Hemminger Nov. 20, 2018, 9:13 p.m. UTC 
  If vdev_netvsc is run with debug logging enabled, then the
log output will fill with:
	net_vdev_netvsc: interface lo is non-ethernet device

Remove the message since it is not useful.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/vdev_netvsc/vdev_netvsc.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Matan Azrad Nov. 27, 2018, 4:18 p.m. UTC | #1 
From: Stephen Hemminger
> If vdev_netvsc is run with debug logging enabled, then the log output will fill
> with:
> 	net_vdev_netvsc: interface lo is non-ethernet device
> 
> Remove the message since it is not useful.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Matan Azrad <matan@mellanox.com>
Ferruh Yigit Nov. 27, 2018, 4:26 p.m. UTC | #2 
On 11/27/2018 4:18 PM, Matan Azrad wrote:
> 
> 
>  From: Stephen Hemminger
>> If vdev_netvsc is run with debug logging enabled, then the log output will fill
>> with:
>> 	net_vdev_netvsc: interface lo is non-ethernet device
>>
>> Remove the message since it is not useful.
>>
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Acked-by: Matan Azrad <matan@mellanox.com>
> 

Applied to dpdk-next-net/master, thanks.
diff mbox series

Patch

diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c
index 16303ef5ef9b..ba63fac2a598 100644
--- a/drivers/net/vdev_netvsc/vdev_netvsc.c
+++ b/drivers/net/vdev_netvsc/vdev_netvsc.c
@@ -191,11 +191,8 @@  vdev_netvsc_foreach_iface(int (*func)(const struct if_nameindex *iface,
 					 req.ifr_name, rte_strerror(errno));
 			continue;
 		}
-		if (req.ifr_hwaddr.sa_family != ARPHRD_ETHER) {
-			DRV_LOG(DEBUG, "interface %s is non-ethernet device",
-				req.ifr_name);
+		if (req.ifr_hwaddr.sa_family != ARPHRD_ETHER)
 			continue;
-		}
 		memcpy(eth_addr.addr_bytes, req.ifr_hwaddr.sa_data,
 		       RTE_DIM(eth_addr.addr_bytes));
 		va_start(ap, is_netvsc);