diff mbox series

doc: fix mismatch descriptorion

Message ID 20181119093831.54753-1-roy.fan.zhang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series doc: fix mismatch descriptorion |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS

Commit Message

Fan Zhang Nov. 19, 2018, 9:38 a.m. UTC 
  This patch fixes the mismatch keyword in vhost_crypto sample
application guide.

Fixes: 709521f4c2cd ("examples/vhost_crypto: support multi-core")
Cc: stable@dpdk.org

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
 doc/guides/sample_app_ug/vhost_crypto.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Maxime Coquelin Nov. 19, 2018, 9:49 a.m. UTC | #1 
On 11/19/18 10:38 AM, Fan Zhang wrote:
> This patch fixes the mismatch keyword in vhost_crypto sample
> application guide.
> 
> Fixes: 709521f4c2cd ("examples/vhost_crypto: support multi-core")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>   doc/guides/sample_app_ug/vhost_crypto.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/doc/guides/sample_app_ug/vhost_crypto.rst b/doc/guides/sample_app_ug/vhost_crypto.rst
> index 3db57eab9..bbc25bde1 100644
> --- a/doc/guides/sample_app_ug/vhost_crypto.rst
> +++ b/doc/guides/sample_app_ug/vhost_crypto.rst
> @@ -30,7 +30,7 @@ Start the vhost_crypto example
>   
>       ./vhost_crypto [EAL options] --
>       		--config (lcore,cdev-id,queue-id)[,(lcore,cdev-id,queue-id)]
> -    		--socketfile lcore,PATH
> +    		--socket-file lcore,PATH
>       		[--zero-copy]
>       		[--guest-polling]
>   
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime
Kovacevic, Marko Nov. 19, 2018, 10:28 a.m. UTC | #2 
> [dpdk-dev] [PATCH] doc: fix mismatch descriptorion

Spelling mistake in the heading but that's fine it can be changed when applied.

> This patch fixes the mismatch keyword in vhost_crypto sample application
> guide.
> 
> Fixes: 709521f4c2cd ("examples/vhost_crypto: support multi-core")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>  doc/guides/sample_app_ug/vhost_crypto.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/doc/guides/sample_app_ug/vhost_crypto.rst
> b/doc/guides/sample_app_ug/vhost_crypto.rst
> index 3db57eab9..bbc25bde1 100644
> --- a/doc/guides/sample_app_ug/vhost_crypto.rst
> +++ b/doc/guides/sample_app_ug/vhost_crypto.rst
> @@ -30,7 +30,7 @@ Start the vhost_crypto example
> 
>      ./vhost_crypto [EAL options] --
>      		--config (lcore,cdev-id,queue-id)[,(lcore,cdev-id,queue-id)]
> -    		--socketfile lcore,PATH
> +    		--socket-file lcore,PATH
>      		[--zero-copy]
>      		[--guest-polling]
> 

Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
Ferruh Yigit Nov. 20, 2018, 12:28 p.m. UTC | #3 
On 11/19/2018 9:49 AM, Maxime Coquelin wrote:
> 
> 
> On 11/19/18 10:38 AM, Fan Zhang wrote:
>> This patch fixes the mismatch keyword in vhost_crypto sample
>> application guide.
>>
>> Fixes: 709521f4c2cd ("examples/vhost_crypto: support multi-core")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
>> ---
>>   doc/guides/sample_app_ug/vhost_crypto.rst | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/doc/guides/sample_app_ug/vhost_crypto.rst b/doc/guides/sample_app_ug/vhost_crypto.rst
>> index 3db57eab9..bbc25bde1 100644
>> --- a/doc/guides/sample_app_ug/vhost_crypto.rst
>> +++ b/doc/guides/sample_app_ug/vhost_crypto.rst
>> @@ -30,7 +30,7 @@ Start the vhost_crypto example
>>   
>>       ./vhost_crypto [EAL options] --
>>       		--config (lcore,cdev-id,queue-id)[,(lcore,cdev-id,queue-id)]
>> -    		--socketfile lcore,PATH
>> +    		--socket-file lcore,PATH
>>       		[--zero-copy]
>>       		[--guest-polling]
>>   
>>
> 
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> 

Applied to dpdk-next-net/master, thanks.

(typo on title fixed while applying)
Maxime Coquelin Nov. 20, 2018, 12:30 p.m. UTC | #4 
On 11/20/18 1:28 PM, Ferruh Yigit wrote:
> On 11/19/2018 9:49 AM, Maxime Coquelin wrote:
>>
>>
>> On 11/19/18 10:38 AM, Fan Zhang wrote:
>>> This patch fixes the mismatch keyword in vhost_crypto sample
>>> application guide.
>>>
>>> Fixes: 709521f4c2cd ("examples/vhost_crypto: support multi-core")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
>>> ---
>>>    doc/guides/sample_app_ug/vhost_crypto.rst | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/doc/guides/sample_app_ug/vhost_crypto.rst b/doc/guides/sample_app_ug/vhost_crypto.rst
>>> index 3db57eab9..bbc25bde1 100644
>>> --- a/doc/guides/sample_app_ug/vhost_crypto.rst
>>> +++ b/doc/guides/sample_app_ug/vhost_crypto.rst
>>> @@ -30,7 +30,7 @@ Start the vhost_crypto example
>>>    
>>>        ./vhost_crypto [EAL options] --
>>>        		--config (lcore,cdev-id,queue-id)[,(lcore,cdev-id,queue-id)]
>>> -    		--socketfile lcore,PATH
>>> +    		--socket-file lcore,PATH
>>>        		[--zero-copy]
>>>        		[--guest-polling]
>>>    
>>>
>>
>> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>>
> 
> Applied to dpdk-next-net/master, thanks.
> 
> (typo on title fixed while applying)
> 

Thanks Ferruh,

You may want to sync with Thomas, as I thought he was picking it
yesterday.
diff mbox series

Patch

diff --git a/doc/guides/sample_app_ug/vhost_crypto.rst b/doc/guides/sample_app_ug/vhost_crypto.rst
index 3db57eab9..bbc25bde1 100644
--- a/doc/guides/sample_app_ug/vhost_crypto.rst
+++ b/doc/guides/sample_app_ug/vhost_crypto.rst
@@ -30,7 +30,7 @@  Start the vhost_crypto example
 
     ./vhost_crypto [EAL options] --
     		--config (lcore,cdev-id,queue-id)[,(lcore,cdev-id,queue-id)]
-    		--socketfile lcore,PATH
+    		--socket-file lcore,PATH
     		[--zero-copy]
     		[--guest-polling]