diff mbox series

[v1] net/tap: invoke probe finish for multiq failure

Message ID 20181107135817.15139-1-vipin.varghese@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series [v1] net/tap: invoke probe finish for multiq failure |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS

Commit Message

Varghese, Vipin Nov. 7, 2018, 1:58 p.m. UTC 
  In scenarion for multiq or flowq setup failure rte_eth_dev_probing_finish
has to be invoked for successful device registration.

Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
---
---
 drivers/net/tap/rte_eth_tap.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Wiles, Keith Nov. 7, 2018, 3:11 p.m. UTC | #1 
> On Nov 7, 2018, at 1:58 PM, Varghese, Vipin <vipin.varghese@intel.com> wrote:
> 
> In scenarion for multiq or flowq setup failure rte_eth_dev_probing_finish
> has to be invoked for successful device registration.
> 
Acked-by: Keith Wiles <keith.wiles@intel.com>
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> ---
> ---
> drivers/net/tap/rte_eth_tap.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index e7817e896..40911923d 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -1848,6 +1848,7 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, char *tap_name,
> 		TAP_LOG(ERR, "Remote feature requires flow support.");
> 		goto error_exit;
> 	}
> +	rte_eth_dev_probing_finish(dev);
> 	return 0;
> 
> error_remote:
> -- 
> 2.17.1
> 

Regards,
Keith
Ferruh Yigit Nov. 7, 2018, 7:03 p.m. UTC | #2 
On 11/7/2018 3:11 PM, Wiles, Keith wrote:
> 
> 
>> On Nov 7, 2018, at 1:58 PM, Varghese, Vipin <vipin.varghese@intel.com> wrote:
>>
>> In scenarion for multiq or flowq setup failure rte_eth_dev_probing_finish
>> has to be invoked for successful device registration.
>>
>>
>> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
>
> Acked-by: Keith Wiles <keith.wiles@intel.com>

    Fixes: fbe90cdd776c ("ethdev: add probing finish function")
    Cc: stable@dpdk.org

Applied to dpdk-next-net/master, thanks.
diff mbox series

Patch

diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index e7817e896..40911923d 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -1848,6 +1848,7 @@  eth_dev_tap_create(struct rte_vdev_device *vdev, char *tap_name,
 		TAP_LOG(ERR, "Remote feature requires flow support.");
 		goto error_exit;
 	}
+	rte_eth_dev_probing_finish(dev);
 	return 0;
 
 error_remote: