[1/2] bus/pci: rename devargs parameter id to addr
Checks
Commit Message
We could match devices by their PCI id (vendor id, device id, etc).
But for now, only matching by PCI address is implemented.
The devargs parameter "id" is renamed "addr" to reflect its real meaning.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
drivers/bus/pci/pci_params.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Comments
On 10/3/18 10:40 PM, Thomas Monjalon wrote:
> We could match devices by their PCI id (vendor id, device id, etc).
> But for now, only matching by PCI address is implemented.
> The devargs parameter "id" is renamed "addr" to reflect its real meaning.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
10/10/2018 08:48, Andrew Rybchenko:
> On 10/3/18 10:40 PM, Thomas Monjalon wrote:
> > We could match devices by their PCI id (vendor id, device id, etc).
> > But for now, only matching by PCI address is implemented.
> > The devargs parameter "id" is renamed "addr" to reflect its real meaning.
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
Series applied
@@ -12,12 +12,12 @@
#include "private.h"
enum pci_params {
- RTE_PCI_PARAMS_ID,
+ RTE_PCI_PARAMS_ADDR,
RTE_PCI_PARAMS_MAX,
};
static const char * const pci_params_keys[] = {
- [RTE_PCI_PARAMS_ID] = "id",
+ [RTE_PCI_PARAMS_ADDR] = "addr",
[RTE_PCI_PARAMS_MAX] = NULL,
};
@@ -47,7 +47,7 @@ pci_dev_match(const struct rte_device *dev,
return 0;
pdev = RTE_DEV_TO_PCI_CONST(dev);
/* if any field does not match. */
- if (rte_kvargs_process(kvlist, "id",
+ if (rte_kvargs_process(kvlist, pci_params_keys[RTE_PCI_PARAMS_ADDR],
&pci_addr_kv_cmp,
(void *)(intptr_t)&pdev->addr))
return 1;