[v3,1/2] test/event: fix eth Rx adapter autotest for skeleton PMD
Checks
Commit Message
skeleton PMD does not support
RTE_EVENT_ETH_RX_ADAPTER_CAP_MULTI_EVENTQ and
implicit_release_disable so make the Rx queue_id = -1 and
initialize the event port configuration to zero.
Fixes: ec36d881f56d ("eventdev: add implicit release disable capability")
Fixes: 2a9c83ae3b2e ("test/eventdev: add multi-ports test")
Cc: vipin.varghese@intel.com
CC: stable@dpdk.org
Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
---
test/test/test_event_eth_rx_adapter.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
v2:
* include patch to fix Rx adapter intr autotest as it is
dependent on the first patch in this series.
v3:
* use memset to initialize structure in place of assignment.
Comments
-----Original Message-----
> Date: Tue, 25 Sep 2018 12:49:04 +0530
> From: Nikhil Rao <nikhil.rao@intel.com>
> To: jerin.jacob@caviumnetworks.com
> CC: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>,
> vipin.varghese@intel.com, stable@dpdk.org
> Subject: [PATCH v3 1/2] test/event: fix eth Rx adapter autotest for
> skeleton PMD
> X-Mailer: git-send-email 1.8.3.1
>
> skeleton PMD does not support
> RTE_EVENT_ETH_RX_ADAPTER_CAP_MULTI_EVENTQ and
> implicit_release_disable so make the Rx queue_id = -1 and
> initialize the event port configuration to zero.
>
> Fixes: ec36d881f56d ("eventdev: add implicit release disable capability")
> Fixes: 2a9c83ae3b2e ("test/eventdev: add multi-ports test")
> Cc: vipin.varghese@intel.com
> CC: stable@dpdk.org
>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
-----Original Message-----
> Date: Tue, 25 Sep 2018 12:49:04 +0530
> From: Nikhil Rao <nikhil.rao@intel.com>
> To: jerin.jacob@caviumnetworks.com
> CC: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>,
> vipin.varghese@intel.com, stable@dpdk.org
> Subject: [PATCH v3 1/2] test/event: fix eth Rx adapter autotest for
> skeleton PMD
> X-Mailer: git-send-email 1.8.3.1
>
>
> skeleton PMD does not support
> RTE_EVENT_ETH_RX_ADAPTER_CAP_MULTI_EVENTQ and
> implicit_release_disable so make the Rx queue_id = -1 and
> initialize the event port configuration to zero.
>
> Fixes: ec36d881f56d ("eventdev: add implicit release disable capability")
> Fixes: 2a9c83ae3b2e ("test/eventdev: add multi-ports test")
> Cc: vipin.varghese@intel.com
> CC: stable@dpdk.org
>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
Series applied to dpdk-next-eventdev/master. Thanks.
@@ -312,6 +312,8 @@ struct event_eth_rx_adapter_test_params {
struct rte_event_dev_info dev_info;
struct rte_event_port_conf rx_p_conf;
+ memset(&rx_p_conf, 0, sizeof(rx_p_conf));
+
err = rte_event_dev_info_get(TEST_DEV_ID, &dev_info);
TEST_ASSERT(err == 0, "Expected 0 got %d", err);
@@ -493,7 +495,7 @@ struct event_eth_rx_adapter_test_params {
port_index = 0;
for (; port_index < rte_eth_dev_count_total(); port_index += 1) {
err = rte_event_eth_rx_adapter_queue_add(TEST_INST_ID,
- port_index, 0,
+ port_index, -1,
&queue_config);
TEST_ASSERT(err == 0, "Expected 0 got %d", err);
}
@@ -502,7 +504,7 @@ struct event_eth_rx_adapter_test_params {
port_index = 0;
for (; port_index < rte_eth_dev_count_total(); port_index += 1) {
err = rte_event_eth_rx_adapter_queue_del(TEST_INST_ID,
- port_index, 0);
+ port_index, -1);
TEST_ASSERT(err == 0, "Expected 0 got %d", err);
}