diff mbox series

devtools: add compressdev tests to test-build

Message ID 20180711071750.9872-1-pablo.de.lara.guarch@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series devtools: add compressdev tests to test-build |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

De Lara Guarch, Pablo July 11, 2018, 7:17 a.m. UTC 
  Compressdev tests depend on Zlib library,
so they can only be enabled if this is available.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 devtools/test-build.sh | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Monjalon July 11, 2018, 3:49 p.m. UTC | #1 
11/07/2018 09:17, Pablo de Lara:
> Compressdev tests depend on Zlib library,
> so they can only be enabled if this is available.
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> --- a/devtools/test-build.sh
> +++ b/devtools/test-build.sh
> @@ -154,6 +154,7 @@ config () # <directory> <target> <options>
>  		test "$DPDK_DEP_ZLIB" != y || \
>  		sed -ri          's,(BNX2X_PMD=)n,\1y,' $1/.config
>  		sed -ri            's,(NFP_PMD=)n,\1y,' $1/.config
> +		sed -ri   's,(COMPRESSDEV_TEST=)n,\1y,' $1/.config

It is always enabled here.
You need to repeat the ZLIB condition for NFP and COMPRESSDEV_TEST.
De Lara Guarch, Pablo July 16, 2018, 5:33 p.m. UTC | #2 
HI Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Wednesday, July 11, 2018 4:50 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [PATCH] devtools: add compressdev tests to test-build
> 
> 11/07/2018 09:17, Pablo de Lara:
> > Compressdev tests depend on Zlib library, so they can only be enabled
> > if this is available.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > ---
> > --- a/devtools/test-build.sh
> > +++ b/devtools/test-build.sh
> > @@ -154,6 +154,7 @@ config () # <directory> <target> <options>
> >  		test "$DPDK_DEP_ZLIB" != y || \
> >  		sed -ri          's,(BNX2X_PMD=)n,\1y,' $1/.config
> >  		sed -ri            's,(NFP_PMD=)n,\1y,' $1/.config
> > +		sed -ri   's,(COMPRESSDEV_TEST=)n,\1y,' $1/.config
> 
> It is always enabled here.
> You need to repeat the ZLIB condition for NFP and COMPRESSDEV_TEST.
> 

I see. So, does this mean that NFP PMD is always enabled? Do we need a fix for that?

Thanks,
Pablo

> 
>
Thomas Monjalon July 16, 2018, 7:50 p.m. UTC | #3 
16/07/2018 19:33, De Lara Guarch, Pablo:
> HI Thomas,
> 
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > Sent: Wednesday, July 11, 2018 4:50 PM
> > To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> > Cc: dev@dpdk.org
> > Subject: Re: [PATCH] devtools: add compressdev tests to test-build
> > 
> > 11/07/2018 09:17, Pablo de Lara:
> > > Compressdev tests depend on Zlib library, so they can only be enabled
> > > if this is available.
> > >
> > > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > > ---
> > > --- a/devtools/test-build.sh
> > > +++ b/devtools/test-build.sh
> > > @@ -154,6 +154,7 @@ config () # <directory> <target> <options>
> > >  		test "$DPDK_DEP_ZLIB" != y || \
> > >  		sed -ri          's,(BNX2X_PMD=)n,\1y,' $1/.config
> > >  		sed -ri            's,(NFP_PMD=)n,\1y,' $1/.config
> > > +		sed -ri   's,(COMPRESSDEV_TEST=)n,\1y,' $1/.config
> > 
> > It is always enabled here.
> > You need to repeat the ZLIB condition for NFP and COMPRESSDEV_TEST.
> > 
> 
> I see. So, does this mean that NFP PMD is always enabled? Do we need a fix for that?

Exact
diff mbox series

Patch

diff --git a/devtools/test-build.sh b/devtools/test-build.sh
index 3ea82bb46..059065891 100755
--- a/devtools/test-build.sh
+++ b/devtools/test-build.sh
@@ -154,6 +154,7 @@  config () # <directory> <target> <options>
 		test "$DPDK_DEP_ZLIB" != y || \
 		sed -ri          's,(BNX2X_PMD=)n,\1y,' $1/.config
 		sed -ri            's,(NFP_PMD=)n,\1y,' $1/.config
+		sed -ri   's,(COMPRESSDEV_TEST=)n,\1y,' $1/.config
 		test "$DPDK_DEP_PCAP" != y || \
 		sed -ri               's,(PCAP=)n,\1y,' $1/.config
 		test -z "$ARMV8_CRYPTO_LIB_PATH" || \