app/testpmd: set keep CRC offload flag
Checks
Commit Message
If "--disable-crc-strip" testpmd parameter issued, it removes the
DEV_RX_OFFLOAD_CRC_STRIP flag.
With introduction of new DEV_RX_OFFLOAD_KEEP_CRC offload flag, this
flag also should be set when this parameter issued.
Fixes: 3d12dceed2df ("ethdev: add new offload flag to keep CRC")
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
app/test-pmd/parameters.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Comments
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, July 3, 2018 7:45 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>
> Subject: [PATCH] app/testpmd: set keep CRC offload flag
>
> If "--disable-crc-strip" testpmd parameter issued, it removes the
> DEV_RX_OFFLOAD_CRC_STRIP flag.
> With introduction of new DEV_RX_OFFLOAD_KEEP_CRC offload flag, this flag
> also should be set when this parameter issued.
>
> Fixes: 3d12dceed2df ("ethdev: add new offload flag to keep CRC")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
10/07/2018 15:43, Iremonger, Bernard:
> From: Yigit, Ferruh
> > If "--disable-crc-strip" testpmd parameter issued, it removes the
> > DEV_RX_OFFLOAD_CRC_STRIP flag.
> > With introduction of new DEV_RX_OFFLOAD_KEEP_CRC offload flag, this flag
> > also should be set when this parameter issued.
> >
> > Fixes: 3d12dceed2df ("ethdev: add new offload flag to keep CRC")
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
Applied, thanks
@@ -878,8 +878,10 @@ launch_args_parse(int argc, char** argv)
" must be >= 0\n", n);
}
#endif
- if (!strcmp(lgopts[opt_idx].name, "disable-crc-strip"))
+ if (!strcmp(lgopts[opt_idx].name, "disable-crc-strip")) {
rx_offloads &= ~DEV_RX_OFFLOAD_CRC_STRIP;
+ rx_offloads |= DEV_RX_OFFLOAD_KEEP_CRC;
+ }
if (!strcmp(lgopts[opt_idx].name, "enable-lro"))
rx_offloads |= DEV_RX_OFFLOAD_TCP_LRO;
if (!strcmp(lgopts[opt_idx].name, "enable-scatter"))