Message ID | 1426230179-1891-1-git-send-email-michael.qiu@intel.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 9F7485947; Fri, 13 Mar 2015 08:03:09 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 269B65682 for <dev@dpdk.org>; Fri, 13 Mar 2015 08:03:06 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP; 13 Mar 2015 00:03:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,393,1422950400"; d="scan'208";a="691493412" Received: from shvmail01.sh.intel.com ([10.239.29.42]) by fmsmga002.fm.intel.com with ESMTP; 13 Mar 2015 00:03:05 -0700 Received: from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com [10.239.29.89]) by shvmail01.sh.intel.com with ESMTP id t2D733Sa011091; Fri, 13 Mar 2015 15:03:03 +0800 Received: from shecgisg004.sh.intel.com (localhost [127.0.0.1]) by shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP id t2D730VT001925; Fri, 13 Mar 2015 15:03:02 +0800 Received: (from dayuqiu@localhost) by shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t2D730Hu001921; Fri, 13 Mar 2015 15:03:00 +0800 From: Michael Qiu <michael.qiu@intel.com> To: dev@dpdk.org Date: Fri, 13 Mar 2015 15:02:59 +0800 Message-Id: <1426230179-1891-1-git-send-email-michael.qiu@intel.com> X-Mailer: git-send-email 1.7.4.1 Subject: [dpdk-dev] [PATCH] common/rte_memcpy: Fix x86intrin.h missed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Michael Qiu
March 13, 2015, 7:02 a.m. UTC
rte_memcpy.h(46): catastrophic error: cannot open source file "x86intrin.h"
For icc and old gcc, this header is not included.
Signed-off-by: Michael Qiu <michael.qiu@intel.com>
---
lib/librte_eal/common/include/arch/x86/rte_memcpy.h | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
Comments
> -----Original Message----- > From: Qiu, Michael > Sent: Friday, March 13, 2015 3:03 PM > To: dev@dpdk.org > Cc: Wang, Zhihong; Qiu, Michael > Subject: [PATCH] common/rte_memcpy: Fix x86intrin.h missed > > rte_memcpy.h(46): catastrophic error: cannot open source file "x86intrin.h" > > For icc and old gcc, this header is not included. > > Signed-off-by: Michael Qiu <michael.qiu@intel.com> > --- > lib/librte_eal/common/include/arch/x86/rte_memcpy.h | 20 > ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h > b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h > index ac72069..bd10d36 100644 > --- a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h > +++ b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h > @@ -43,7 +43,27 @@ > #include <stdio.h> > #include <stdint.h> > #include <string.h> > +#if (defined(__ICC) || (__GNUC__ == 4 && __GNUC_MINOR__ < 4)) > + > +#ifdef __SSE__ > +#include <xmmintrin.h> > +#endif > + > +#ifdef __SSE2__ > +#include <emmintrin.h> > +#endif > + > +#if defined(__SSE4_2__) || defined(__SSE4_1__) #include <smmintrin.h> > +#endif > + > +#if defined(__AVX__) > +#include <immintrin.h> > +#endif > + > +#else > #include <x86intrin.h> > +#endif > > #ifdef __cplusplus > extern "C" { > -- > 1.9.3 Acked-by: Wang, Zhihong <zhihong.wang@intel.com>
Hi Michael, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michael Qiu > Sent: Friday, March 13, 2015 7:03 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] common/rte_memcpy: Fix x86intrin.h missed > > rte_memcpy.h(46): catastrophic error: cannot open source file "x86intrin.h" > > For icc and old gcc, this header is not included. > > Signed-off-by: Michael Qiu <michael.qiu@intel.com> > --- > lib/librte_eal/common/include/arch/x86/rte_memcpy.h | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h > index ac72069..bd10d36 100644 > --- a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h > +++ b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h > @@ -43,7 +43,27 @@ > #include <stdio.h> > #include <stdint.h> > #include <string.h> > +#if (defined(__ICC) || (__GNUC__ == 4 && __GNUC_MINOR__ < 4)) > + > +#ifdef __SSE__ > +#include <xmmintrin.h> > +#endif > + > +#ifdef __SSE2__ > +#include <emmintrin.h> > +#endif > + > +#if defined(__SSE4_2__) || defined(__SSE4_1__) > +#include <smmintrin.h> > +#endif > + > +#if defined(__AVX__) > +#include <immintrin.h> > +#endif > + > +#else > #include <x86intrin.h> > +#endif > > #ifdef __cplusplus > extern "C" { > -- > 1.9.3 Wonder why to spread this thing over? Why not just #include <rte_common_vec.h>? Konstantin
> -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michael Qiu > Sent: Friday, March 13, 2015 7:03 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] common/rte_memcpy: Fix x86intrin.h missed > > rte_memcpy.h(46): catastrophic error: cannot open source file > "x86intrin.h" Hi Michael, How are you generating that error? John
On 3/13/2015 10:25 PM, Mcnamara, John wrote: >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michael Qiu >> Sent: Friday, March 13, 2015 7:03 AM >> To: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH] common/rte_memcpy: Fix x86intrin.h missed >> >> rte_memcpy.h(46): catastrophic error: cannot open source file >> "x86intrin.h" > > Hi Michael, > > How are you generating that error? For ICC compile, it will report this error, also in suse11sp2 i686 platform, also have this issue as internal report. Thanks, Michael > John >
2015-03-13 09:44, Ananyev, Konstantin: > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michael Qiu > > > > rte_memcpy.h(46): catastrophic error: cannot open source file "x86intrin.h" > > > > For icc and old gcc, this header is not included. > > > > Signed-off-by: Michael Qiu <michael.qiu@intel.com> > > --- > > lib/librte_eal/common/include/arch/x86/rte_memcpy.h | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h > > index ac72069..bd10d36 100644 > > --- a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h > > +++ b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h > > @@ -43,7 +43,27 @@ > > #include <stdio.h> > > #include <stdint.h> > > #include <string.h> > > +#if (defined(__ICC) || (__GNUC__ == 4 && __GNUC_MINOR__ < 4)) > > + > > +#ifdef __SSE__ > > +#include <xmmintrin.h> > > +#endif > > + > > +#ifdef __SSE2__ > > +#include <emmintrin.h> > > +#endif > > + > > +#if defined(__SSE4_2__) || defined(__SSE4_1__) > > +#include <smmintrin.h> > > +#endif > > + > > +#if defined(__AVX__) > > +#include <immintrin.h> > > +#endif > > + > > +#else > > #include <x86intrin.h> > > +#endif > > > > #ifdef __cplusplus > > extern "C" { > > -- > > 1.9.3 > > Wonder why to spread this thing over? > Why not just #include <rte_common_vec.h>? I agree to use rte_common_vec.h. I pushed this approach to check every tested compilers: http://dpdk.org/browse/dpdk/commit/?id=9a01c31b94e54384 I think that rte_common_vec.h should be moved into lib/librte_eal/common/include/arch/x86/rte_vec.h as it's x86-specific.
Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Monday, March 16, 2015 4:05 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org; Qiu, Michael > Subject: Re: [dpdk-dev] [PATCH] common/rte_memcpy: Fix x86intrin.h missed > > 2015-03-13 09:44, Ananyev, Konstantin: > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michael Qiu > > > > > > rte_memcpy.h(46): catastrophic error: cannot open source file "x86intrin.h" > > > > > > For icc and old gcc, this header is not included. > > > > > > Signed-off-by: Michael Qiu <michael.qiu@intel.com> > > > --- > > > lib/librte_eal/common/include/arch/x86/rte_memcpy.h | 20 ++++++++++++++++++++ > > > 1 file changed, 20 insertions(+) > > > > > > diff --git a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h > > > index ac72069..bd10d36 100644 > > > --- a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h > > > +++ b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h > > > @@ -43,7 +43,27 @@ > > > #include <stdio.h> > > > #include <stdint.h> > > > #include <string.h> > > > +#if (defined(__ICC) || (__GNUC__ == 4 && __GNUC_MINOR__ < 4)) > > > + > > > +#ifdef __SSE__ > > > +#include <xmmintrin.h> > > > +#endif > > > + > > > +#ifdef __SSE2__ > > > +#include <emmintrin.h> > > > +#endif > > > + > > > +#if defined(__SSE4_2__) || defined(__SSE4_1__) > > > +#include <smmintrin.h> > > > +#endif > > > + > > > +#if defined(__AVX__) > > > +#include <immintrin.h> > > > +#endif > > > + > > > +#else > > > #include <x86intrin.h> > > > +#endif > > > > > > #ifdef __cplusplus > > > extern "C" { > > > -- > > > 1.9.3 > > > > Wonder why to spread this thing over? > > Why not just #include <rte_common_vec.h>? > > I agree to use rte_common_vec.h. > I pushed this approach to check every tested compilers: > http://dpdk.org/browse/dpdk/commit/?id=9a01c31b94e54384 > > I think that rte_common_vec.h should be moved into > lib/librte_eal/common/include/arch/x86/rte_vec.h as it's x86-specific. Seems like a good thing to do. Do you want me to submit a patch for 2.0 for that? Konstantin
2015-03-16 17:39, Ananyev, Konstantin: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > I think that rte_common_vec.h should be moved into > > lib/librte_eal/common/include/arch/x86/rte_vec.h as it's x86-specific. > > Seems like a good thing to do. > Do you want me to submit a patch for 2.0 for that? It would be nice yes. Thanks
On 3/13/2015 5:45 PM, Ananyev, Konstantin wrote: > Hi Michael, > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michael Qiu >> Sent: Friday, March 13, 2015 7:03 AM >> To: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH] common/rte_memcpy: Fix x86intrin.h missed >> >> rte_memcpy.h(46): catastrophic error: cannot open source file "x86intrin.h" >> >> For icc and old gcc, this header is not included. >> >> Signed-off-by: Michael Qiu <michael.qiu@intel.com> >> --- >> lib/librte_eal/common/include/arch/x86/rte_memcpy.h | 20 ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> >> diff --git a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h >> index ac72069..bd10d36 100644 >> --- a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h >> +++ b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h >> @@ -43,7 +43,27 @@ >> #include <stdio.h> >> #include <stdint.h> >> #include <string.h> >> +#if (defined(__ICC) || (__GNUC__ == 4 && __GNUC_MINOR__ < 4)) >> + >> +#ifdef __SSE__ >> +#include <xmmintrin.h> >> +#endif >> + >> +#ifdef __SSE2__ >> +#include <emmintrin.h> >> +#endif >> + >> +#if defined(__SSE4_2__) || defined(__SSE4_1__) >> +#include <smmintrin.h> >> +#endif >> + >> +#if defined(__AVX__) >> +#include <immintrin.h> >> +#endif >> + >> +#else >> #include <x86intrin.h> >> +#endif >> >> #ifdef __cplusplus >> extern "C" { >> -- >> 1.9.3 > Wonder why to spread this thing over? > Why not just #include <rte_common_vec.h>? Yes, I will send other patch to fix this, Thanks, Michael > Konstantin > > > >
diff --git a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h index ac72069..bd10d36 100644 --- a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h +++ b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h @@ -43,7 +43,27 @@ #include <stdio.h> #include <stdint.h> #include <string.h> +#if (defined(__ICC) || (__GNUC__ == 4 && __GNUC_MINOR__ < 4)) + +#ifdef __SSE__ +#include <xmmintrin.h> +#endif + +#ifdef __SSE2__ +#include <emmintrin.h> +#endif + +#if defined(__SSE4_2__) || defined(__SSE4_1__) +#include <smmintrin.h> +#endif + +#if defined(__AVX__) +#include <immintrin.h> +#endif + +#else #include <x86intrin.h> +#endif #ifdef __cplusplus extern "C" {