diff mbox

[dpdk-dev] mbuf: remove experimental tag from pool ops functions

Message ID 1528179851-26589-1-git-send-email-hemant.agrawal@nxp.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Hemant Agrawal June 5, 2018, 6:24 a.m. UTC 
  Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 lib/librte_mbuf/rte_mbuf.c           |  2 +-
 lib/librte_mbuf/rte_mbuf.h           |  2 +-
 lib/librte_mbuf/rte_mbuf_pool_ops.c  | 10 +++++-----
 lib/librte_mbuf/rte_mbuf_pool_ops.h  | 13 +++++--------
 lib/librte_mbuf/rte_mbuf_version.map |  4 ++--
 5 files changed, 14 insertions(+), 17 deletions(-)

Comments

Andrew Rybchenko June 8, 2018, 9:17 a.m. UTC | #1 
On 06/05/2018 09:24 AM, Hemant Agrawal wrote:
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
Jerin Jacob June 11, 2018, 2:07 p.m. UTC | #2 
-----Original Message-----
> Date: Tue,  5 Jun 2018 11:54:11 +0530
> From: Hemant Agrawal <hemant.agrawal@nxp.com>
> To: dev@dpdk.org
> CC: olivier.matz@6wind.com, santosh.shukla@caviumnetworks.com, Hemant
>  Agrawal <hemant.agrawal@nxp.com>
> Subject: [dpdk-dev] [PATCH] mbuf: remove experimental tag from pool ops
>  functions
> X-Mailer: git-send-email 2.7.4
> 
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Santosh Shukla June 11, 2018, 2:19 p.m. UTC | #3 
On Monday 11 June 2018 07:37 PM, Jerin Jacob wrote:
> -----Original Message-----
>> Date: Tue,  5 Jun 2018 11:54:11 +0530
>> From: Hemant Agrawal <hemant.agrawal@nxp.com>
>> To: dev@dpdk.org
>> CC: olivier.matz@6wind.com, santosh.shukla@caviumnetworks.com, Hemant
>>  Agrawal <hemant.agrawal@nxp.com>
>> Subject: [dpdk-dev] [PATCH] mbuf: remove experimental tag from pool ops
>>  functions
>> X-Mailer: git-send-email 2.7.4
>>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>

Thanks.
Olivier Matz June 25, 2018, 3:27 p.m. UTC | #4 
On Mon, Jun 11, 2018 at 07:49:37PM +0530, santosh wrote:
> 
> On Monday 11 June 2018 07:37 PM, Jerin Jacob wrote:
> > -----Original Message-----
> >> Date: Tue,  5 Jun 2018 11:54:11 +0530
> >> From: Hemant Agrawal <hemant.agrawal@nxp.com>
> >> To: dev@dpdk.org
> >> CC: olivier.matz@6wind.com, santosh.shukla@caviumnetworks.com, Hemant
> >>  Agrawal <hemant.agrawal@nxp.com>
> >> Subject: [dpdk-dev] [PATCH] mbuf: remove experimental tag from pool ops
> >>  functions
> >> X-Mailer: git-send-email 2.7.4
> >>
> >> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> 
> Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>

Shouldn't we add something in doc/guides/rel_notes/release_18_08.rst,
like it's done for instance in 60df5711972e ("service: remove experimental
tags")?

Apart from this,
Acked-by: Olivier Matz <olivier.matz@6wind.com>

By the way I'm preparing a patch to remove rte_eal_mbuf_default_mempool_ops()
which is deprecated and remove experimental tag from
rte_eal_mbuf_user_pool_ops().
Thomas Monjalon July 26, 2018, 9:39 p.m. UTC | #5 
25/06/2018 17:27, Olivier Matz:
> On Mon, Jun 11, 2018 at 07:49:37PM +0530, santosh wrote:
> > On Monday 11 June 2018 07:37 PM, Jerin Jacob wrote:
> > >> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> > 
> > Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> 
> Shouldn't we add something in doc/guides/rel_notes/release_18_08.rst,
> like it's done for instance in 60df5711972e ("service: remove experimental
> tags")?

No update for release notes. I guess it is not so important.

> Apart from this,
> Acked-by: Olivier Matz <olivier.matz@6wind.com>

Applied, thanks
diff mbox

Patch

diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c
index fca580e..e714c5a 100644
--- a/lib/librte_mbuf/rte_mbuf.c
+++ b/lib/librte_mbuf/rte_mbuf.c
@@ -107,7 +107,7 @@  rte_pktmbuf_init(struct rte_mempool *mp,
 }
 
 /* Helper to create a mbuf pool with given mempool ops name*/
-struct rte_mempool * __rte_experimental
+struct rte_mempool *
 rte_pktmbuf_pool_create_by_ops(const char *name, unsigned int n,
 	unsigned int cache_size, uint16_t priv_size, uint16_t data_room_size,
 	int socket_id, const char *ops_name)
diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
index 8e6b4d2..5233d57 100644
--- a/lib/librte_mbuf/rte_mbuf.h
+++ b/lib/librte_mbuf/rte_mbuf.h
@@ -1146,7 +1146,7 @@  rte_pktmbuf_pool_create(const char *name, unsigned n,
  *    - EEXIST - a memzone with the same name already exists
  *    - ENOMEM - no appropriate memory area found in which to create memzone
  */
-struct rte_mempool * __rte_experimental
+struct rte_mempool *
 rte_pktmbuf_pool_create_by_ops(const char *name, unsigned int n,
 	unsigned int cache_size, uint16_t priv_size, uint16_t data_room_size,
 	int socket_id, const char *ops_name);
diff --git a/lib/librte_mbuf/rte_mbuf_pool_ops.c b/lib/librte_mbuf/rte_mbuf_pool_ops.c
index a1d4699..5722976 100644
--- a/lib/librte_mbuf/rte_mbuf_pool_ops.c
+++ b/lib/librte_mbuf/rte_mbuf_pool_ops.c
@@ -9,7 +9,7 @@ 
 #include <rte_errno.h>
 #include <rte_mbuf_pool_ops.h>
 
-int __rte_experimental
+int
 rte_mbuf_set_platform_mempool_ops(const char *ops_name)
 {
 	const struct rte_memzone *mz;
@@ -35,7 +35,7 @@  rte_mbuf_set_platform_mempool_ops(const char *ops_name)
 	return -EEXIST;
 }
 
-const char * __rte_experimental
+const char *
 rte_mbuf_platform_mempool_ops(void)
 {
 	const struct rte_memzone *mz;
@@ -46,7 +46,7 @@  rte_mbuf_platform_mempool_ops(void)
 	return mz->addr;
 }
 
-int __rte_experimental
+int
 rte_mbuf_set_user_mempool_ops(const char *ops_name)
 {
 	const struct rte_memzone *mz;
@@ -67,7 +67,7 @@  rte_mbuf_set_user_mempool_ops(const char *ops_name)
 
 }
 
-const char * __rte_experimental
+const char *
 rte_mbuf_user_mempool_ops(void)
 {
 	const struct rte_memzone *mz;
@@ -79,7 +79,7 @@  rte_mbuf_user_mempool_ops(void)
 }
 
 /* Return mbuf pool ops name */
-const char * __rte_experimental
+const char *
 rte_mbuf_best_mempool_ops(void)
 {
 	/* User defined mempool ops takes the priority */
diff --git a/lib/librte_mbuf/rte_mbuf_pool_ops.h b/lib/librte_mbuf/rte_mbuf_pool_ops.h
index ebf5bf0..7ed95a4 100644
--- a/lib/librte_mbuf/rte_mbuf_pool_ops.h
+++ b/lib/librte_mbuf/rte_mbuf_pool_ops.h
@@ -12,9 +12,6 @@ 
  * These APIs are for configuring the mbuf pool ops names to be largely used by
  * rte_pktmbuf_pool_create(). However, this can also be used to set and inquire
  * the best mempool ops available.
- *
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
  */
 
 #include <rte_compat.h>
@@ -34,7 +31,7 @@  extern "C" {
  *   - On success, zero.
  *   - On failure, a negative value.
  */
-int __rte_experimental
+int
 rte_mbuf_set_platform_mempool_ops(const char *ops_name);
 
 /**
@@ -46,7 +43,7 @@  rte_mbuf_set_platform_mempool_ops(const char *ops_name);
  *   - On success, platform pool ops name.
  *   - On failure, NULL.
  */
-const char * __rte_experimental
+const char *
 rte_mbuf_platform_mempool_ops(void);
 
 /**
@@ -60,7 +57,7 @@  rte_mbuf_platform_mempool_ops(void);
  *   - On success, zero.
  *   - On failure, a negative value.
  */
-int __rte_experimental
+int
 rte_mbuf_set_user_mempool_ops(const char *ops_name);
 
 /**
@@ -72,7 +69,7 @@  rte_mbuf_set_user_mempool_ops(const char *ops_name);
  *   - On success, user pool ops name..
  *   - On failure, NULL.
  */
-const char * __rte_experimental
+const char *
 rte_mbuf_user_mempool_ops(void);
 
 /**
@@ -87,7 +84,7 @@  rte_mbuf_user_mempool_ops(void);
  * @return
  *   returns preferred mbuf pool ops name
  */
-const char * __rte_experimental
+const char *
 rte_mbuf_best_mempool_ops(void);
 
 
diff --git a/lib/librte_mbuf/rte_mbuf_version.map b/lib/librte_mbuf/rte_mbuf_version.map
index 1bb9538..cae68db 100644
--- a/lib/librte_mbuf/rte_mbuf_version.map
+++ b/lib/librte_mbuf/rte_mbuf_version.map
@@ -35,7 +35,7 @@  DPDK_16.11 {
 
 } DPDK_2.1;
 
-EXPERIMENTAL {
+DPDK_18.08 {
 	global:
 
 	rte_mbuf_best_mempool_ops;
@@ -44,4 +44,4 @@  EXPERIMENTAL {
 	rte_mbuf_set_user_mempool_ops;
 	rte_mbuf_user_mempool_ops;
 	rte_pktmbuf_pool_create_by_ops;
-};
+} DPDK_16.11;