diff mbox series

[dpdk-dev,v3,01/27] net/ena: change version number to 1.1.0

Message ID 20180607094322.14312-1-mk@semihalf.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series net/ena: new features and fixes |

Checks

Context Check Description
ci/Intel-compilation fail Compilation issues
ci/checkpatch success coding style OK

Commit Message

Michal Krawczyk June 7, 2018, 9:42 a.m. UTC 
  The upcoming patches for the ENA PMD are part of 1.1.0 update of the PMD
and the version number is updated accordingly.

Signed-off-by: Michal Krawczyk <mk@semihalf.com>
---
 drivers/net/ena/ena_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ferruh Yigit June 8, 2018, 7:45 p.m. UTC | #1 
On 6/7/2018 10:42 AM, Michal Krawczyk wrote:
> The upcoming patches for the ENA PMD are part of 1.1.0 update of the PMD
> and the version number is updated accordingly.

Does it make sense to add a release notes update to announce driver update?

> 
> Signed-off-by: Michal Krawczyk <mk@semihalf.com>
<...>
Michal Krawczyk June 11, 2018, 8:45 a.m. UTC | #2 
2018-06-08 21:45 GMT+02:00 Ferruh Yigit <ferruh.yigit@intel.com>:
> On 6/7/2018 10:42 AM, Michal Krawczyk wrote:
>> The upcoming patches for the ENA PMD are part of 1.1.0 update of the PMD
>> and the version number is updated accordingly.
>
> Does it make sense to add a release notes update to announce driver update?

Is it possible to move the patch at the end of the uploaded patches,
so there won't be need to reupload everything?
The new commit message could be:


net/ena: change version number to 1.1.0

ENA PMD version 1.1.0 introduces:
* Update of the ena_com to the newer version
* Remove support of legacy LLQ
* Watchdog and device reset
* LSC interrupt
* Rx out of order completion
* Linearization of mbufs with too many fragments
* Information about maximum number of Tx and Rx descriptors
* Validation of requested id on Tx (for Tx OOO completion)
* Likely/unlikely statements
* Link speed is now set as none
* Other minor bug fixes and changes
>
>>
>> Signed-off-by: Michal Krawczyk <mk@semihalf.com>
> <...>
Ferruh Yigit June 11, 2018, 9:26 a.m. UTC | #3 
On 6/11/2018 9:45 AM, Michał Krawczyk wrote:
> 2018-06-08 21:45 GMT+02:00 Ferruh Yigit <ferruh.yigit@intel.com>:
>> On 6/7/2018 10:42 AM, Michal Krawczyk wrote:
>>> The upcoming patches for the ENA PMD are part of 1.1.0 update of the PMD
>>> and the version number is updated accordingly.
>>
>> Does it make sense to add a release notes update to announce driver update?
> 
> Is it possible to move the patch at the end of the uploaded patches,
> so there won't be need to reupload everything?

Yes release notes update can separate patch, to prevent a new version of all
set, if you are asking this.
Or is there any existing documentation patch I am missing?

> The new commit message could be:
> 
> 
> net/ena: change version number to 1.1.0
> 
> ENA PMD version 1.1.0 introduces:
> * Update of the ena_com to the newer version
> * Remove support of legacy LLQ
> * Watchdog and device reset
> * LSC interrupt
> * Rx out of order completion
> * Linearization of mbufs with too many fragments
> * Information about maximum number of Tx and Rx descriptors
> * Validation of requested id on Tx (for Tx OOO completion)
> * Likely/unlikely statements
> * Link speed is now set as none
> * Other minor bug fixes and changes
>>
>>>
>>> Signed-off-by: Michal Krawczyk <mk@semihalf.com>
>> <...>
Michal Krawczyk June 11, 2018, 9:33 a.m. UTC | #4 
2018-06-11 11:26 GMT+02:00 Ferruh Yigit <ferruh.yigit@intel.com>:
> On 6/11/2018 9:45 AM, Michał Krawczyk wrote:
>> 2018-06-08 21:45 GMT+02:00 Ferruh Yigit <ferruh.yigit@intel.com>:
>>> On 6/7/2018 10:42 AM, Michal Krawczyk wrote:
>>>> The upcoming patches for the ENA PMD are part of 1.1.0 update of the PMD
>>>> and the version number is updated accordingly.
>>>
>>> Does it make sense to add a release notes update to announce driver update?
>>
>> Is it possible to move the patch at the end of the uploaded patches,
>> so there won't be need to reupload everything?
>
> Yes release notes update can separate patch, to prevent a new version of all
> set, if you are asking this.

That would be great, thanks.

> Or is there any existing documentation patch I am missing?

No, there was no documentation patch.

>
>> The new commit message could be:
>>
>>
>> net/ena: change version number to 1.1.0
>>
>> ENA PMD version 1.1.0 introduces:
>> * Update of the ena_com to the newer version
>> * Remove support of legacy LLQ
>> * Watchdog and device reset
>> * LSC interrupt
>> * Rx out of order completion
>> * Linearization of mbufs with too many fragments
>> * Information about maximum number of Tx and Rx descriptors
>> * Validation of requested id on Tx (for Tx OOO completion)
>> * Likely/unlikely statements
>> * Link speed is now set as none
>> * Other minor bug fixes and changes
>>>
>>>>
>>>> Signed-off-by: Michal Krawczyk <mk@semihalf.com>
>>> <...>
>
Ferruh Yigit June 11, 2018, 9:50 a.m. UTC | #5 
On 6/11/2018 10:33 AM, Michał Krawczyk wrote:
> 2018-06-11 11:26 GMT+02:00 Ferruh Yigit <ferruh.yigit@intel.com>:
>> On 6/11/2018 9:45 AM, Michał Krawczyk wrote:
>>> 2018-06-08 21:45 GMT+02:00 Ferruh Yigit <ferruh.yigit@intel.com>:
>>>> On 6/7/2018 10:42 AM, Michal Krawczyk wrote:
>>>>> The upcoming patches for the ENA PMD are part of 1.1.0 update of the PMD
>>>>> and the version number is updated accordingly.
>>>>
>>>> Does it make sense to add a release notes update to announce driver update?
>>>
>>> Is it possible to move the patch at the end of the uploaded patches,
>>> so there won't be need to reupload everything?
>>
>> Yes release notes update can separate patch, to prevent a new version of all
>> set, if you are asking this.
> 
> That would be great, thanks.

Just recognized that you will already need to send a new version of the set,
please check the build error on 2/27.

If you confirm you are OK with it, I can fix it while applying via:
s/(u64)/(unsigned long long)

> 
>> Or is there any existing documentation patch I am missing?
> 
> No, there was no documentation patch.
> 
>>
>>> The new commit message could be:
>>>
>>>
>>> net/ena: change version number to 1.1.0
>>>
>>> ENA PMD version 1.1.0 introduces:
>>> * Update of the ena_com to the newer version
>>> * Remove support of legacy LLQ
>>> * Watchdog and device reset
>>> * LSC interrupt
>>> * Rx out of order completion
>>> * Linearization of mbufs with too many fragments
>>> * Information about maximum number of Tx and Rx descriptors
>>> * Validation of requested id on Tx (for Tx OOO completion)
>>> * Likely/unlikely statements
>>> * Link speed is now set as none
>>> * Other minor bug fixes and changes
>>>>
>>>>>
>>>>> Signed-off-by: Michal Krawczyk <mk@semihalf.com>
>>>> <...>
>>
Michal Krawczyk June 11, 2018, 9:52 a.m. UTC | #6 
2018-06-11 11:50 GMT+02:00 Ferruh Yigit <ferruh.yigit@intel.com>:
> On 6/11/2018 10:33 AM, Michał Krawczyk wrote:
>> 2018-06-11 11:26 GMT+02:00 Ferruh Yigit <ferruh.yigit@intel.com>:
>>> On 6/11/2018 9:45 AM, Michał Krawczyk wrote:
>>>> 2018-06-08 21:45 GMT+02:00 Ferruh Yigit <ferruh.yigit@intel.com>:
>>>>> On 6/7/2018 10:42 AM, Michal Krawczyk wrote:
>>>>>> The upcoming patches for the ENA PMD are part of 1.1.0 update of the PMD
>>>>>> and the version number is updated accordingly.
>>>>>
>>>>> Does it make sense to add a release notes update to announce driver update?
>>>>
>>>> Is it possible to move the patch at the end of the uploaded patches,
>>>> so there won't be need to reupload everything?
>>>
>>> Yes release notes update can separate patch, to prevent a new version of all
>>> set, if you are asking this.
>>
>> That would be great, thanks.
>
> Just recognized that you will already need to send a new version of the set,
> please check the build error on 2/27.
>
> If you confirm you are OK with it, I can fix it while applying via:
> s/(u64)/(unsigned long long)

I just prepared patch for this issue and I will send it right away.

>
>>
>>> Or is there any existing documentation patch I am missing?
>>
>> No, there was no documentation patch.
>>
>>>
>>>> The new commit message could be:
>>>>
>>>>
>>>> net/ena: change version number to 1.1.0
>>>>
>>>> ENA PMD version 1.1.0 introduces:
>>>> * Update of the ena_com to the newer version
>>>> * Remove support of legacy LLQ
>>>> * Watchdog and device reset
>>>> * LSC interrupt
>>>> * Rx out of order completion
>>>> * Linearization of mbufs with too many fragments
>>>> * Information about maximum number of Tx and Rx descriptors
>>>> * Validation of requested id on Tx (for Tx OOO completion)
>>>> * Likely/unlikely statements
>>>> * Link speed is now set as none
>>>> * Other minor bug fixes and changes
>>>>>
>>>>>>
>>>>>> Signed-off-by: Michal Krawczyk <mk@semihalf.com>
>>>>> <...>
>>>
>
Ferruh Yigit June 11, 2018, 12:34 p.m. UTC | #7 
On 6/7/2018 10:42 AM, Michal Krawczyk wrote:
> The upcoming patches for the ENA PMD are part of 1.1.0 update of the PMD
> and the version number is updated accordingly.
> 
> Signed-off-by: Michal Krawczyk <mk@semihalf.com>

Series applied to dpdk-next-net/master, thanks.

(02/27 replaced with https://dpdk.org/dev/patchwork/patch/40976/)
(will get release notes update later)
diff mbox series

Patch

diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index c595cc7e6..190ed40d1 100644
--- a/drivers/net/ena/ena_ethdev.c
+++ b/drivers/net/ena/ena_ethdev.c
@@ -54,7 +54,7 @@ 
 #include <ena_eth_io_defs.h>
 
 #define DRV_MODULE_VER_MAJOR	1
-#define DRV_MODULE_VER_MINOR	0
+#define DRV_MODULE_VER_MINOR	1
 #define DRV_MODULE_VER_SUBMINOR	0
 
 #define ENA_IO_TXQ_IDX(q)	(2 * (q))