[dpdk-dev,v2] crypto/aesni_mb: fix capabilities
Checks
Commit Message
Missing AES-CMAC supported parameters
in PMD capabilities.
Fixes: 6491dbbecebb ("crypto/aesni_mb: support AES CMAC")
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
Changes in v2:
- Fixed structure type from aead to auth
.../crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 23 +++++++++++++++++--
1 file changed, 21 insertions(+), 2 deletions(-)
Comments
> Missing AES-CMAC supported parameters
> in PMD capabilities.
>
> Fixes: 6491dbbecebb ("crypto/aesni_mb: support AES CMAC")
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>
> Changes in v2:
> - Fixed structure type from aead to auth
>
> .../crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 23 +++++++++++++++++--
> 1 file changed, 21 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
> b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
> index 9d685a09f..01530523f 100644
> --- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
> +++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
> @@ -289,8 +289,27 @@ static const struct rte_cryptodev_capabilities
> aesni_mb_pmd_capabilities[] = {
> }, }
> }, }
> },
> -
> -
> + { /* AES CMAC */
> + .op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
> + {.sym = {
> + .xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,
> + {.auth = {
> + .algo = RTE_CRYPTO_AUTH_AES_CMAC,
> + .block_size = 16,
> + .key_size = {
> + .min = 16,
> + .max = 16,
> + .increment = 0
> + },
> + .digest_size = {
> + .min = 12,
> + .max = 16,
> + .increment = 4
> + },
> + .iv_size = { 0 }
> + }, }
> + }, }
> + },
> RTE_CRYPTODEV_END_OF_CAPABILITIES_LIST()
> };
>
Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
> -----Original Message-----
> From: Kovacevic, Marko
> Sent: Wednesday, May 16, 2018 9:28 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH v2] crypto/aesni_mb: fix capabilities
>
> > Missing AES-CMAC supported parameters
> > in PMD capabilities.
> >
> > Fixes: 6491dbbecebb ("crypto/aesni_mb: support AES CMAC")
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
...
>
> Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
Applied to dpdk-next-crypto.
Pablo
@@ -289,8 +289,27 @@ static const struct rte_cryptodev_capabilities aesni_mb_pmd_capabilities[] = {
}, }
}, }
},
-
-
+ { /* AES CMAC */
+ .op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+ {.sym = {
+ .xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,
+ {.auth = {
+ .algo = RTE_CRYPTO_AUTH_AES_CMAC,
+ .block_size = 16,
+ .key_size = {
+ .min = 16,
+ .max = 16,
+ .increment = 0
+ },
+ .digest_size = {
+ .min = 12,
+ .max = 16,
+ .increment = 4
+ },
+ .iv_size = { 0 }
+ }, }
+ }, }
+ },
RTE_CRYPTODEV_END_OF_CAPABILITIES_LIST()
};