[dpdk-dev] net/enic: fix missing offload capabilities

Message ID 20180514141126.3732-1-hyonkim@cisco.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Hyong Youb Kim (hyonkim) May 14, 2018, 2:11 p.m. UTC
  Add the following missing flags to the advertised offloads.
- DEV_RX_OFFLOAD_CRC_STRIP
  CRC is always stripped.
- DEV_RX_OFFLOAD_JUMBO_FRAME
  Jumbo support is always enabled on the NIC.
- DEV_RX_OFFLOAD_SCATTER
  Scatter Rx is currently supported.
- DEV_TX_OFFLOAD_MULTI_SEGS
  Multiple-segment transmit has always been supported.

Fixes: 93fb21fdbe23 ("net/enic: enable overlay offload for VXLAN and GENEVE")

Signed-off-by: Hyong Youb Kim <hyonkim@cisco.com>
---
 drivers/net/enic/enic_res.c | 4 ++++
 1 file changed, 4 insertions(+)
  

Comments

Ferruh Yigit May 14, 2018, 2:35 p.m. UTC | #1
On 5/14/2018 3:11 PM, Hyong Youb Kim wrote:
> Add the following missing flags to the advertised offloads.
> - DEV_RX_OFFLOAD_CRC_STRIP
>   CRC is always stripped.
> - DEV_RX_OFFLOAD_JUMBO_FRAME
>   Jumbo support is always enabled on the NIC.
> - DEV_RX_OFFLOAD_SCATTER
>   Scatter Rx is currently supported.
> - DEV_TX_OFFLOAD_MULTI_SEGS
>   Multiple-segment transmit has always been supported.
> 
> Fixes: 93fb21fdbe23 ("net/enic: enable overlay offload for VXLAN and GENEVE")
> 
> Signed-off-by: Hyong Youb Kim <hyonkim@cisco.com>

Applied to dpdk-next-net/master, thanks.
  

Patch

diff --git a/drivers/net/enic/enic_res.c b/drivers/net/enic/enic_res.c
index a504de5d5..6b404c3c0 100644
--- a/drivers/net/enic/enic_res.c
+++ b/drivers/net/enic/enic_res.c
@@ -182,12 +182,16 @@  int enic_get_vnic_config(struct enic *enic)
 	 * flags if it enables overlay offloads.
 	 */
 	enic->tx_offload_capa =
+		DEV_TX_OFFLOAD_MULTI_SEGS |
 		DEV_TX_OFFLOAD_VLAN_INSERT |
 		DEV_TX_OFFLOAD_IPV4_CKSUM |
 		DEV_TX_OFFLOAD_UDP_CKSUM |
 		DEV_TX_OFFLOAD_TCP_CKSUM |
 		DEV_TX_OFFLOAD_TCP_TSO;
 	enic->rx_offload_capa =
+		DEV_RX_OFFLOAD_SCATTER |
+		DEV_RX_OFFLOAD_JUMBO_FRAME |
+		DEV_RX_OFFLOAD_CRC_STRIP |
 		DEV_RX_OFFLOAD_VLAN_STRIP |
 		DEV_RX_OFFLOAD_IPV4_CKSUM |
 		DEV_RX_OFFLOAD_UDP_CKSUM |