[dpdk-dev] net/nfp: fix possible resource leak
Checks
Commit Message
Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
---
drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Comments
Acked-by: Alejandro Lucero <alejandro.lucero@netronome.com>
On Tue, Apr 17, 2018 at 6:59 AM, Yangchao Zhou <zhouyates@gmail.com> wrote:
> Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
> ---
> drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> index ad6ce72..f2fcc4a 100644
> --- a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> +++ b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> @@ -816,6 +816,7 @@ struct nfp6000_area_priv {
>
> if (fscanf(fp, "0x%lx 0x%lx 0x%lx", &start, &end, &flags) == 0) {
> printf("error reading resource file for bar size\n");
> + fclose(fp);
> return -1;
> }
>
> --
> 1.7.1
>
>
On 4/17/2018 10:07 AM, Alejandro Lucero wrote:
>
> On Tue, Apr 17, 2018 at 6:59 AM, Yangchao Zhou <zhouyates@gmail.com> wrote:
Fixes: c7e9729da6b5 ("net/nfp: support CPP")
>> Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
> Acked-by: Alejandro Lucero <alejandro.lucero@netronome.com>
Applied to dpdk-next-net/master, thanks.
@@ -816,6 +816,7 @@ struct nfp6000_area_priv {
if (fscanf(fp, "0x%lx 0x%lx 0x%lx", &start, &end, &flags) == 0) {
printf("error reading resource file for bar size\n");
+ fclose(fp);
return -1;
}