[dpdk-dev,v4,1/2] drivers: add common folder
Checks
Commit Message
Add driver/common folder and skeleton makefile for adding commonly used
functions across mempool, event and net devices.
Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---
v4 Changes:
- modified dependency order i.e common before bus.
- updated MAINTAINERS file.
- moved linking common lib in rte.app.mk above bus.
v3 Changes:
- Fix common lib naming scheme.
v2 Changes:
- Removed dependency on bus.
Based on discussion on ml
http://dpdk.org/ml/archives/dev/2018-March/092822.html
http://dpdk.org/ml/archives/dev/2018-March/093271.html
drivers/Makefile | 13 +++++++------
drivers/common/Makefile | 7 +++++++
drivers/common/meson.build | 6 ++++++
drivers/meson.build | 11 ++++++-----
4 files changed, 26 insertions(+), 11 deletions(-)
create mode 100644 drivers/common/Makefile
create mode 100644 drivers/common/meson.build
--
2.16.2
Comments
On 4/2/2018 2:39 PM, Pavan Nikhilesh wrote:
> Add driver/common folder and skeleton makefile for adding commonly used
> functions across mempool, event and net devices.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
-----Original Message-----
> Date: Tue, 3 Apr 2018 12:27:53 +0530
> From: Hemant Agrawal <hemant.agrawal@nxp.com>
> To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>,
> jerin.jacob@caviumnetworks.com, santosh.shukla@caviumnetworks.com,
> thomas@monjalon.net, anatoly.burakov@intel.com, lironh@marvell.com,
> bruce.richardson@intel.com, fiona.trahe@intel.com, shreyansh.jain@nxp.com,
> hemant.agrawal@nxp.com
> CC: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4 1/2] drivers: add common folder
> User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
> Thunderbird/52.6.0
>
>
> On 4/2/2018 2:39 PM, Pavan Nikhilesh wrote:
> > Add driver/common folder and skeleton makefile for adding commonly used
> > functions across mempool, event and net devices.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > ---
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
On Monday 02 April 2018 02:39 PM, Pavan Nikhilesh wrote:
> Add driver/common folder and skeleton makefile for adding commonly used
> functions across mempool, event and net devices.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
@@ -3,18 +3,19 @@
include $(RTE_SDK)/mk/rte.vars.mk
+DIRS-y += common
DIRS-y += bus
DIRS-y += mempool
-DEPDIRS-mempool := bus
+DEPDIRS-mempool := common bus
DIRS-y += net
-DEPDIRS-net := bus mempool
+DEPDIRS-net := common bus mempool
DIRS-$(CONFIG_RTE_LIBRTE_BBDEV) += baseband
-DEPDIRS-baseband := bus mempool
+DEPDIRS-baseband := common bus mempool
DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += crypto
-DEPDIRS-crypto := bus mempool
+DEPDIRS-crypto := common bus mempool
DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += event
-DEPDIRS-event := bus mempool net
+DEPDIRS-event := common bus mempool net
DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += raw
-DEPDIRS-raw := bus mempool net event
+DEPDIRS-raw := common bus mempool net event
include $(RTE_SDK)/mk/rte.subdir.mk
new file mode 100644
@@ -0,0 +1,7 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Cavium, Inc
+#
+
+include $(RTE_SDK)/mk/rte.vars.mk
+
+include $(RTE_SDK)/mk/rte.subdir.mk
new file mode 100644
@@ -0,0 +1,6 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Cavium, Inc
+
+std_deps = ['eal']
+config_flag_fmt = 'RTE_LIBRTE_@0@_COMMON'
+driver_name_fmt = 'rte_common_@0@'
@@ -2,11 +2,12 @@
# Copyright(c) 2017 Intel Corporation
# Defines the order in which the drivers are buit.
-driver_classes = ['bus',
- 'mempool', # depends on bus.
- 'net', # depends on bus and mempool.
- 'crypto', # depenss on bus, mempool (net in future).
- 'event'] # depends on bus, mempool and net.
+driver_classes = ['common',
+ 'bus',
+ 'mempool', # depends on common and bus.
+ 'net', # depends on common, bus and mempool.
+ 'crypto', # depends on common, bus and mempool (net in future).
+ 'event'] # depends on common, bus, mempool and net.
foreach class:driver_classes
drivers = []