Message ID | 1424180839-24483-2-git-send-email-danny.zhou@intel.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id BB9C3B65F; Tue, 17 Feb 2015 14:47:38 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id B49A9B480 for <dev@dpdk.org>; Tue, 17 Feb 2015 14:47:32 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 17 Feb 2015 05:43:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,594,1418112000"; d="scan'208";a="667488852" Received: from shvmail01.sh.intel.com ([10.239.29.42]) by fmsmga001.fm.intel.com with ESMTP; 17 Feb 2015 05:47:29 -0800 Received: from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com [10.239.29.89]) by shvmail01.sh.intel.com with ESMTP id t1HDlSEK001125; Tue, 17 Feb 2015 21:47:28 +0800 Received: from shecgisg004.sh.intel.com (localhost [127.0.0.1]) by shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP id t1HDlOFn024526; Tue, 17 Feb 2015 21:47:26 +0800 Received: (from dyzhou@localhost) by shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t1HDlODP024522; Tue, 17 Feb 2015 21:47:24 +0800 From: Zhou Danny <danny.zhou@intel.com> To: dev@dpdk.org Date: Tue, 17 Feb 2015 21:47:15 +0800 Message-Id: <1424180839-24483-2-git-send-email-danny.zhou@intel.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1424180839-24483-1-git-send-email-danny.zhou@intel.com> References: <1424180839-24483-1-git-send-email-danny.zhou@intel.com> Subject: [dpdk-dev] [PATCH v3 1/5] ethdev: add rx interrupt enable/disable functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Zhou, Danny
Feb. 17, 2015, 1:47 p.m. UTC
v3 changes - Add return value for interrupt enable/disable functions Add two dev_ops functions to enable and disable rx queue interrupts Signed-off-by: Danny Zhou <danny.zhou@intel.com> Tested-by: Yong Liu <yong.liu@intel.com> --- lib/librte_ether/rte_ethdev.c | 43 ++++++++++++++++++++++++++++++++ lib/librte_ether/rte_ethdev.h | 57 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 100 insertions(+)
Comments
On Tue, Feb 17, 2015 at 09:47:15PM +0800, Zhou Danny wrote: > v3 changes > - Add return value for interrupt enable/disable functions > > Add two dev_ops functions to enable and disable rx queue interrupts > > Signed-off-by: Danny Zhou <danny.zhou@intel.com> > Tested-by: Yong Liu <yong.liu@intel.com> > --- > lib/librte_ether/rte_ethdev.c | 43 ++++++++++++++++++++++++++++++++ > lib/librte_ether/rte_ethdev.h | 57 +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 100 insertions(+) > > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c > index ea3a1fb..d27469a 100644 > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c > @@ -2825,6 +2825,49 @@ _rte_eth_dev_callback_process(struct rte_eth_dev *dev, > } > rte_spinlock_unlock(&rte_eth_dev_cb_lock); > } > + > +int > +rte_eth_dev_rx_queue_intr_enable(uint8_t port_id, > + uint16_t queue_id) > +{ > + struct rte_eth_dev *dev; > + > + if (port_id >= nb_ports) { > + PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id); > + return (-ENODEV); > + } > + > + dev = &rte_eth_devices[port_id]; > + if (dev == NULL) { > + PMD_DEBUG_TRACE("Invalid port device\n"); > + return (-ENODEV); > + } > + > + FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_intr_enable, -ENOTSUP); > + return (*dev->dev_ops->rx_queue_intr_enable)(dev, queue_id); > +} > + > +int > +rte_eth_dev_rx_queue_intr_disable(uint8_t port_id, > + uint16_t queue_id) > +{ > + struct rte_eth_dev *dev; > + > + if (port_id >= nb_ports) { > + PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id); > + return (-ENODEV); > + } > + > + dev = &rte_eth_devices[port_id]; > + if (dev == NULL) { > + PMD_DEBUG_TRACE("Invalid port device\n"); > + return (-ENODEV); > + } > + > + FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_intr_disable, -ENOTSUP); > + return (*dev->dev_ops->rx_queue_intr_disable)(dev, queue_id); > +} > + > #ifdef RTE_NIC_BYPASS > int rte_eth_dev_bypass_init(uint8_t port_id) > { > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h > index 84160c3..0f320a9 100644 > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -848,6 +848,8 @@ struct rte_eth_fdir { > struct rte_intr_conf { > /** enable/disable lsc interrupt. 0 (default) - disable, 1 enable */ > uint16_t lsc; > + /** enable/disable rxq interrupt. 0 (default) - disable, 1 enable */ > + uint16_t rxq; > }; > > /** > @@ -1109,6 +1111,14 @@ typedef int (*eth_tx_queue_setup_t)(struct rte_eth_dev *dev, > const struct rte_eth_txconf *tx_conf); > /**< @internal Setup a transmit queue of an Ethernet device. */ > > +typedef int (*eth_rx_enable_intr_t)(struct rte_eth_dev *dev, > + uint16_t rx_queue_id); > +/**< @internal Enable interrupt of a receive queue of an Ethernet device. */ > + > +typedef int (*eth_rx_disable_intr_t)(struct rte_eth_dev *dev, > + uint16_t rx_queue_id); > +/**< @internal Disable interrupt of a receive queue of an Ethernet device. */ > + > typedef void (*eth_queue_release_t)(void *queue); > /**< @internal Release memory resources allocated by given RX/TX queue. */ > > @@ -1445,6 +1455,8 @@ struct eth_dev_ops { > eth_queue_start_t tx_queue_start;/**< Start TX for a queue.*/ > eth_queue_stop_t tx_queue_stop;/**< Stop TX for a queue.*/ > eth_rx_queue_setup_t rx_queue_setup;/**< Set up device RX queue.*/ > + eth_rx_enable_intr_t rx_queue_intr_enable; /**< Enable Rx queue interrupt. */ > + eth_rx_disable_intr_t rx_queue_intr_disable; /**< Disable Rx queue interrupt.*/ > eth_queue_release_t rx_queue_release;/**< Release RX queue.*/ > eth_rx_queue_count_t rx_queue_count; /**< Get Rx queue count. */ > eth_rx_descriptor_done_t rx_descriptor_done; /**< Check rxd DD bit */ > @@ -2811,6 +2823,51 @@ void _rte_eth_dev_callback_process(struct rte_eth_dev *dev, > enum rte_eth_event_type event); > > /** > + * When there is no rx packet coming in Rx Queue for a long time, we can > + * sleep lcore related to RX Queue for power saving, and enable rx interrupt > + * to be triggered when rx packect arrives. > + * > + * The rte_eth_dev_rx_queue_intr_enable() function enables rx queue > + * interrupt on specific rx queue of a port. > + * > + * @param port_id > + * The port identifier of the Ethernet device. > + * @param queue_id > + * The index of the receive queue from which to retrieve input packets. > + * The value must be in the range [0, nb_rx_queue - 1] previously supplied > + * to rte_eth_dev_configure(). > + * @return > + * - (0) if successful. > + * - (-ENOTSUP) if underlying hardware OR driver doesn't support > + * that operation. > + * - (-ENODEV) if *port_id* invalid. > + */ > +int rte_eth_dev_rx_queue_intr_enable(uint8_t port_id, > + uint16_t queue_id); > + > +/** > + * When lcore wakes up from rx interrupt indicating packet coming, disable rx > + * interrupt and returns to polling mode. > + * > + * The rte_eth_dev_rx_queue_intr_disable() function disables rx queue > + * interrupt on specific rx queue of a port. > + * > + * @param port_id > + * The port identifier of the Ethernet device. > + * @param queue_id > + * The index of the receive queue from which to retrieve input packets. > + * The value must be in the range [0, nb_rx_queue - 1] previously supplied > + * to rte_eth_dev_configure(). > + * @return > + * - (0) if successful. > + * - (-ENOTSUP) if underlying hardware OR driver doesn't support > + * that operation. > + * - (-ENODEV) if *port_id* invalid. > + */ > +int rte_eth_dev_rx_queue_intr_disable(uint8_t port_id, > + uint16_t queue_id); > + > +/** > * Turn on the LED on the Ethernet device. > * This function turns on the LED on the Ethernet device. > * > -- > 1.8.1.4 > > Need to export these functions Neil
On Tue, Feb 17, 2015 at 09:47:15PM +0800, Zhou Danny wrote: > v3 changes > - Add return value for interrupt enable/disable functions > > Add two dev_ops functions to enable and disable rx queue interrupts > > Signed-off-by: Danny Zhou <danny.zhou@intel.com> > Tested-by: Yong Liu <yong.liu@intel.com> > --- > lib/librte_ether/rte_ethdev.c | 43 ++++++++++++++++++++++++++++++++ > lib/librte_ether/rte_ethdev.h | 57 +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 100 insertions(+) > > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c > index ea3a1fb..d27469a 100644 > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c > @@ -2825,6 +2825,49 @@ _rte_eth_dev_callback_process(struct rte_eth_dev *dev, > } > rte_spinlock_unlock(&rte_eth_dev_cb_lock); > } > + > +int > +rte_eth_dev_rx_queue_intr_enable(uint8_t port_id, > + uint16_t queue_id) > +{ > + struct rte_eth_dev *dev; > + > + if (port_id >= nb_ports) { > + PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id); > + return (-ENODEV); > + } > + > + dev = &rte_eth_devices[port_id]; > + if (dev == NULL) { > + PMD_DEBUG_TRACE("Invalid port device\n"); > + return (-ENODEV); > + } > + > + FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_intr_enable, -ENOTSUP); > + return (*dev->dev_ops->rx_queue_intr_enable)(dev, queue_id); > +} > + > +int > +rte_eth_dev_rx_queue_intr_disable(uint8_t port_id, > + uint16_t queue_id) > +{ > + struct rte_eth_dev *dev; > + > + if (port_id >= nb_ports) { > + PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id); > + return (-ENODEV); > + } > + > + dev = &rte_eth_devices[port_id]; > + if (dev == NULL) { > + PMD_DEBUG_TRACE("Invalid port device\n"); > + return (-ENODEV); > + } > + > + FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_intr_disable, -ENOTSUP); > + return (*dev->dev_ops->rx_queue_intr_disable)(dev, queue_id); > +} > + > #ifdef RTE_NIC_BYPASS > int rte_eth_dev_bypass_init(uint8_t port_id) > { > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h > index 84160c3..0f320a9 100644 > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -848,6 +848,8 @@ struct rte_eth_fdir { > struct rte_intr_conf { > /** enable/disable lsc interrupt. 0 (default) - disable, 1 enable */ > uint16_t lsc; > + /** enable/disable rxq interrupt. 0 (default) - disable, 1 enable */ > + uint16_t rxq; > }; > > /** > @@ -1109,6 +1111,14 @@ typedef int (*eth_tx_queue_setup_t)(struct rte_eth_dev *dev, > const struct rte_eth_txconf *tx_conf); > /**< @internal Setup a transmit queue of an Ethernet device. */ > > +typedef int (*eth_rx_enable_intr_t)(struct rte_eth_dev *dev, > + uint16_t rx_queue_id); > +/**< @internal Enable interrupt of a receive queue of an Ethernet device. */ > + > +typedef int (*eth_rx_disable_intr_t)(struct rte_eth_dev *dev, > + uint16_t rx_queue_id); > +/**< @internal Disable interrupt of a receive queue of an Ethernet device. */ > + > typedef void (*eth_queue_release_t)(void *queue); > /**< @internal Release memory resources allocated by given RX/TX queue. */ > > @@ -1445,6 +1455,8 @@ struct eth_dev_ops { > eth_queue_start_t tx_queue_start;/**< Start TX for a queue.*/ > eth_queue_stop_t tx_queue_stop;/**< Stop TX for a queue.*/ > eth_rx_queue_setup_t rx_queue_setup;/**< Set up device RX queue.*/ > + eth_rx_enable_intr_t rx_queue_intr_enable; /**< Enable Rx queue interrupt. */ > + eth_rx_disable_intr_t rx_queue_intr_disable; /**< Disable Rx queue interrupt.*/ Put these at the end of eth_dev_ops if you want to avoid breaking ABI > eth_queue_release_t rx_queue_release;/**< Release RX queue.*/ > eth_rx_queue_count_t rx_queue_count; /**< Get Rx queue count. */ > eth_rx_descriptor_done_t rx_descriptor_done; /**< Check rxd DD bit */ > @@ -2811,6 +2823,51 @@ void _rte_eth_dev_callback_process(struct rte_eth_dev *dev, > enum rte_eth_event_type event); > > /** > + * When there is no rx packet coming in Rx Queue for a long time, we can > + * sleep lcore related to RX Queue for power saving, and enable rx interrupt > + * to be triggered when rx packect arrives. > + * > + * The rte_eth_dev_rx_queue_intr_enable() function enables rx queue > + * interrupt on specific rx queue of a port. > + * > + * @param port_id > + * The port identifier of the Ethernet device. > + * @param queue_id > + * The index of the receive queue from which to retrieve input packets. > + * The value must be in the range [0, nb_rx_queue - 1] previously supplied > + * to rte_eth_dev_configure(). > + * @return > + * - (0) if successful. > + * - (-ENOTSUP) if underlying hardware OR driver doesn't support > + * that operation. > + * - (-ENODEV) if *port_id* invalid. > + */ > +int rte_eth_dev_rx_queue_intr_enable(uint8_t port_id, > + uint16_t queue_id); > + > +/** > + * When lcore wakes up from rx interrupt indicating packet coming, disable rx > + * interrupt and returns to polling mode. > + * > + * The rte_eth_dev_rx_queue_intr_disable() function disables rx queue > + * interrupt on specific rx queue of a port. > + * > + * @param port_id > + * The port identifier of the Ethernet device. > + * @param queue_id > + * The index of the receive queue from which to retrieve input packets. > + * The value must be in the range [0, nb_rx_queue - 1] previously supplied > + * to rte_eth_dev_configure(). > + * @return > + * - (0) if successful. > + * - (-ENOTSUP) if underlying hardware OR driver doesn't support > + * that operation. > + * - (-ENODEV) if *port_id* invalid. > + */ > +int rte_eth_dev_rx_queue_intr_disable(uint8_t port_id, > + uint16_t queue_id); > + > +/** > * Turn on the LED on the Ethernet device. > * This function turns on the LED on the Ethernet device. > * > -- > 1.8.1.4 > >
> -----Original Message----- > From: Neil Horman [mailto:nhorman@tuxdriver.com] > Sent: Tuesday, February 17, 2015 11:55 PM > To: Zhou, Danny > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add rx interrupt enable/disable functions > > On Tue, Feb 17, 2015 at 09:47:15PM +0800, Zhou Danny wrote: > > v3 changes > > - Add return value for interrupt enable/disable functions > > > > Add two dev_ops functions to enable and disable rx queue interrupts > > > > Signed-off-by: Danny Zhou <danny.zhou@intel.com> > > Tested-by: Yong Liu <yong.liu@intel.com> > > --- > > lib/librte_ether/rte_ethdev.c | 43 ++++++++++++++++++++++++++++++++ > > lib/librte_ether/rte_ethdev.h | 57 +++++++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 100 insertions(+) > > > > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c > > index ea3a1fb..d27469a 100644 > > --- a/lib/librte_ether/rte_ethdev.c > > +++ b/lib/librte_ether/rte_ethdev.c > > @@ -2825,6 +2825,49 @@ _rte_eth_dev_callback_process(struct rte_eth_dev *dev, > > } > > rte_spinlock_unlock(&rte_eth_dev_cb_lock); > > } > > + > > +int > > +rte_eth_dev_rx_queue_intr_enable(uint8_t port_id, > > + uint16_t queue_id) > > +{ > > + struct rte_eth_dev *dev; > > + > > + if (port_id >= nb_ports) { > > + PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id); > > + return (-ENODEV); > > + } > > + > > + dev = &rte_eth_devices[port_id]; > > + if (dev == NULL) { > > + PMD_DEBUG_TRACE("Invalid port device\n"); > > + return (-ENODEV); > > + } > > + > > + FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_intr_enable, -ENOTSUP); > > + return (*dev->dev_ops->rx_queue_intr_enable)(dev, queue_id); > > +} > > + > > +int > > +rte_eth_dev_rx_queue_intr_disable(uint8_t port_id, > > + uint16_t queue_id) > > +{ > > + struct rte_eth_dev *dev; > > + > > + if (port_id >= nb_ports) { > > + PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id); > > + return (-ENODEV); > > + } > > + > > + dev = &rte_eth_devices[port_id]; > > + if (dev == NULL) { > > + PMD_DEBUG_TRACE("Invalid port device\n"); > > + return (-ENODEV); > > + } > > + > > + FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_intr_disable, -ENOTSUP); > > + return (*dev->dev_ops->rx_queue_intr_disable)(dev, queue_id); > > +} > > + > > #ifdef RTE_NIC_BYPASS > > int rte_eth_dev_bypass_init(uint8_t port_id) > > { > > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h > > index 84160c3..0f320a9 100644 > > --- a/lib/librte_ether/rte_ethdev.h > > +++ b/lib/librte_ether/rte_ethdev.h > > @@ -848,6 +848,8 @@ struct rte_eth_fdir { > > struct rte_intr_conf { > > /** enable/disable lsc interrupt. 0 (default) - disable, 1 enable */ > > uint16_t lsc; > > + /** enable/disable rxq interrupt. 0 (default) - disable, 1 enable */ > > + uint16_t rxq; > > }; > > > > /** > > @@ -1109,6 +1111,14 @@ typedef int (*eth_tx_queue_setup_t)(struct rte_eth_dev *dev, > > const struct rte_eth_txconf *tx_conf); > > /**< @internal Setup a transmit queue of an Ethernet device. */ > > > > +typedef int (*eth_rx_enable_intr_t)(struct rte_eth_dev *dev, > > + uint16_t rx_queue_id); > > +/**< @internal Enable interrupt of a receive queue of an Ethernet device. */ > > + > > +typedef int (*eth_rx_disable_intr_t)(struct rte_eth_dev *dev, > > + uint16_t rx_queue_id); > > +/**< @internal Disable interrupt of a receive queue of an Ethernet device. */ > > + > > typedef void (*eth_queue_release_t)(void *queue); > > /**< @internal Release memory resources allocated by given RX/TX queue. */ > > > > @@ -1445,6 +1455,8 @@ struct eth_dev_ops { > > eth_queue_start_t tx_queue_start;/**< Start TX for a queue.*/ > > eth_queue_stop_t tx_queue_stop;/**< Stop TX for a queue.*/ > > eth_rx_queue_setup_t rx_queue_setup;/**< Set up device RX queue.*/ > > + eth_rx_enable_intr_t rx_queue_intr_enable; /**< Enable Rx queue interrupt. */ > > + eth_rx_disable_intr_t rx_queue_intr_disable; /**< Disable Rx queue interrupt.*/ > Put these at the end of eth_dev_ops if you want to avoid breaking ABI I purposely add those two APIs at current position to ensure all rxq related APIs are declared together in eth_dev_ops. Anyway, moving them to the end is ok to me for the reason of ABI, though the code looks a little bit ugly. > > > eth_queue_release_t rx_queue_release;/**< Release RX queue.*/ > > eth_rx_queue_count_t rx_queue_count; /**< Get Rx queue count. */ > > eth_rx_descriptor_done_t rx_descriptor_done; /**< Check rxd DD bit */ > > @@ -2811,6 +2823,51 @@ void _rte_eth_dev_callback_process(struct rte_eth_dev *dev, > > enum rte_eth_event_type event); > > > > /** > > + * When there is no rx packet coming in Rx Queue for a long time, we can > > + * sleep lcore related to RX Queue for power saving, and enable rx interrupt > > + * to be triggered when rx packect arrives. > > + * > > + * The rte_eth_dev_rx_queue_intr_enable() function enables rx queue > > + * interrupt on specific rx queue of a port. > > + * > > + * @param port_id > > + * The port identifier of the Ethernet device. > > + * @param queue_id > > + * The index of the receive queue from which to retrieve input packets. > > + * The value must be in the range [0, nb_rx_queue - 1] previously supplied > > + * to rte_eth_dev_configure(). > > + * @return > > + * - (0) if successful. > > + * - (-ENOTSUP) if underlying hardware OR driver doesn't support > > + * that operation. > > + * - (-ENODEV) if *port_id* invalid. > > + */ > > +int rte_eth_dev_rx_queue_intr_enable(uint8_t port_id, > > + uint16_t queue_id); > > + > > +/** > > + * When lcore wakes up from rx interrupt indicating packet coming, disable rx > > + * interrupt and returns to polling mode. > > + * > > + * The rte_eth_dev_rx_queue_intr_disable() function disables rx queue > > + * interrupt on specific rx queue of a port. > > + * > > + * @param port_id > > + * The port identifier of the Ethernet device. > > + * @param queue_id > > + * The index of the receive queue from which to retrieve input packets. > > + * The value must be in the range [0, nb_rx_queue - 1] previously supplied > > + * to rte_eth_dev_configure(). > > + * @return > > + * - (0) if successful. > > + * - (-ENOTSUP) if underlying hardware OR driver doesn't support > > + * that operation. > > + * - (-ENODEV) if *port_id* invalid. > > + */ > > +int rte_eth_dev_rx_queue_intr_disable(uint8_t port_id, > > + uint16_t queue_id); > > + > > +/** > > * Turn on the LED on the Ethernet device. > > * This function turns on the LED on the Ethernet device. > > * > > -- > > 1.8.1.4 > > > >
> -----Original Message----- > From: Neil Horman [mailto:nhorman@tuxdriver.com] > Sent: Tuesday, February 17, 2015 11:53 PM > To: Zhou, Danny > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add rx interrupt enable/disable functions > > On Tue, Feb 17, 2015 at 09:47:15PM +0800, Zhou Danny wrote: > > v3 changes > > - Add return value for interrupt enable/disable functions > > > > Add two dev_ops functions to enable and disable rx queue interrupts > > > > Signed-off-by: Danny Zhou <danny.zhou@intel.com> > > Tested-by: Yong Liu <yong.liu@intel.com> > > --- > > lib/librte_ether/rte_ethdev.c | 43 ++++++++++++++++++++++++++++++++ > > lib/librte_ether/rte_ethdev.h | 57 +++++++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 100 insertions(+) > > > > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c > > index ea3a1fb..d27469a 100644 > > --- a/lib/librte_ether/rte_ethdev.c > > +++ b/lib/librte_ether/rte_ethdev.c > > @@ -2825,6 +2825,49 @@ _rte_eth_dev_callback_process(struct rte_eth_dev *dev, > > } > > rte_spinlock_unlock(&rte_eth_dev_cb_lock); > > } > > + > > +int > > +rte_eth_dev_rx_queue_intr_enable(uint8_t port_id, > > + uint16_t queue_id) > > +{ > > + struct rte_eth_dev *dev; > > + > > + if (port_id >= nb_ports) { > > + PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id); > > + return (-ENODEV); > > + } > > + > > + dev = &rte_eth_devices[port_id]; > > + if (dev == NULL) { > > + PMD_DEBUG_TRACE("Invalid port device\n"); > > + return (-ENODEV); > > + } > > + > > + FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_intr_enable, -ENOTSUP); > > + return (*dev->dev_ops->rx_queue_intr_enable)(dev, queue_id); > > +} > > + > > +int > > +rte_eth_dev_rx_queue_intr_disable(uint8_t port_id, > > + uint16_t queue_id) > > +{ > > + struct rte_eth_dev *dev; > > + > > + if (port_id >= nb_ports) { > > + PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id); > > + return (-ENODEV); > > + } > > + > > + dev = &rte_eth_devices[port_id]; > > + if (dev == NULL) { > > + PMD_DEBUG_TRACE("Invalid port device\n"); > > + return (-ENODEV); > > + } > > + > > + FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_intr_disable, -ENOTSUP); > > + return (*dev->dev_ops->rx_queue_intr_disable)(dev, queue_id); > > +} > > + > > #ifdef RTE_NIC_BYPASS > > int rte_eth_dev_bypass_init(uint8_t port_id) > > { > > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h > > index 84160c3..0f320a9 100644 > > --- a/lib/librte_ether/rte_ethdev.h > > +++ b/lib/librte_ether/rte_ethdev.h > > @@ -848,6 +848,8 @@ struct rte_eth_fdir { > > struct rte_intr_conf { > > /** enable/disable lsc interrupt. 0 (default) - disable, 1 enable */ > > uint16_t lsc; > > + /** enable/disable rxq interrupt. 0 (default) - disable, 1 enable */ > > + uint16_t rxq; > > }; > > > > /** > > @@ -1109,6 +1111,14 @@ typedef int (*eth_tx_queue_setup_t)(struct rte_eth_dev *dev, > > const struct rte_eth_txconf *tx_conf); > > /**< @internal Setup a transmit queue of an Ethernet device. */ > > > > +typedef int (*eth_rx_enable_intr_t)(struct rte_eth_dev *dev, > > + uint16_t rx_queue_id); > > +/**< @internal Enable interrupt of a receive queue of an Ethernet device. */ > > + > > +typedef int (*eth_rx_disable_intr_t)(struct rte_eth_dev *dev, > > + uint16_t rx_queue_id); > > +/**< @internal Disable interrupt of a receive queue of an Ethernet device. */ > > + > > typedef void (*eth_queue_release_t)(void *queue); > > /**< @internal Release memory resources allocated by given RX/TX queue. */ > > > > @@ -1445,6 +1455,8 @@ struct eth_dev_ops { > > eth_queue_start_t tx_queue_start;/**< Start TX for a queue.*/ > > eth_queue_stop_t tx_queue_stop;/**< Stop TX for a queue.*/ > > eth_rx_queue_setup_t rx_queue_setup;/**< Set up device RX queue.*/ > > + eth_rx_enable_intr_t rx_queue_intr_enable; /**< Enable Rx queue interrupt. */ > > + eth_rx_disable_intr_t rx_queue_intr_disable; /**< Disable Rx queue interrupt.*/ > > eth_queue_release_t rx_queue_release;/**< Release RX queue.*/ > > eth_rx_queue_count_t rx_queue_count; /**< Get Rx queue count. */ > > eth_rx_descriptor_done_t rx_descriptor_done; /**< Check rxd DD bit */ > > @@ -2811,6 +2823,51 @@ void _rte_eth_dev_callback_process(struct rte_eth_dev *dev, > > enum rte_eth_event_type event); > > > > /** > > + * When there is no rx packet coming in Rx Queue for a long time, we can > > + * sleep lcore related to RX Queue for power saving, and enable rx interrupt > > + * to be triggered when rx packect arrives. > > + * > > + * The rte_eth_dev_rx_queue_intr_enable() function enables rx queue > > + * interrupt on specific rx queue of a port. > > + * > > + * @param port_id > > + * The port identifier of the Ethernet device. > > + * @param queue_id > > + * The index of the receive queue from which to retrieve input packets. > > + * The value must be in the range [0, nb_rx_queue - 1] previously supplied > > + * to rte_eth_dev_configure(). > > + * @return > > + * - (0) if successful. > > + * - (-ENOTSUP) if underlying hardware OR driver doesn't support > > + * that operation. > > + * - (-ENODEV) if *port_id* invalid. > > + */ > > +int rte_eth_dev_rx_queue_intr_enable(uint8_t port_id, > > + uint16_t queue_id); > > + > > +/** > > + * When lcore wakes up from rx interrupt indicating packet coming, disable rx > > + * interrupt and returns to polling mode. > > + * > > + * The rte_eth_dev_rx_queue_intr_disable() function disables rx queue > > + * interrupt on specific rx queue of a port. > > + * > > + * @param port_id > > + * The port identifier of the Ethernet device. > > + * @param queue_id > > + * The index of the receive queue from which to retrieve input packets. > > + * The value must be in the range [0, nb_rx_queue - 1] previously supplied > > + * to rte_eth_dev_configure(). > > + * @return > > + * - (0) if successful. > > + * - (-ENOTSUP) if underlying hardware OR driver doesn't support > > + * that operation. > > + * - (-ENODEV) if *port_id* invalid. > > + */ > > +int rte_eth_dev_rx_queue_intr_disable(uint8_t port_id, > > + uint16_t queue_id); > > + > > +/** > > * Turn on the LED on the Ethernet device. > > * This function turns on the LED on the Ethernet device. > > * > > -- > > 1.8.1.4 > > > > > Need to export these functions > Neil Sorry, I do not get it. What do you mean export these functions? They have been declared in rte_ethdev.h and defined here in rte_ethdev.c. And caller in L3fwd-power example is able to link those two functions in the library.
On 19/02/2015 08:06, Zhou, Danny wrote: > >> -----Original Message----- >> From: Neil Horman [mailto:nhorman@tuxdriver.com] >> Sent: Tuesday, February 17, 2015 11:53 PM >> To: Zhou, Danny >> Cc: dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add rx interrupt enable/disable functions >> >> On Tue, Feb 17, 2015 at 09:47:15PM +0800, Zhou Danny wrote: >>> v3 changes >>> - Add return value for interrupt enable/disable functions >>> >>> Add two dev_ops functions to enable and disable rx queue interrupts >>> >>> Signed-off-by: Danny Zhou <danny.zhou@intel.com> >>> Tested-by: Yong Liu <yong.liu@intel.com> >>> --- >>> lib/librte_ether/rte_ethdev.c | 43 ++++++++++++++++++++++++++++++++ >>> lib/librte_ether/rte_ethdev.h | 57 +++++++++++++++++++++++++++++++++++++++++++ >>> 2 files changed, 100 insertions(+) >>> >>> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c >>> index ea3a1fb..d27469a 100644 >>> --- a/lib/librte_ether/rte_ethdev.c >>> +++ b/lib/librte_ether/rte_ethdev.c >>> @@ -2825,6 +2825,49 @@ _rte_eth_dev_callback_process(struct rte_eth_dev *dev, >>> } >>> rte_spinlock_unlock(&rte_eth_dev_cb_lock); >>> } >>> + >>> +int >>> +rte_eth_dev_rx_queue_intr_enable(uint8_t port_id, >>> + uint16_t queue_id) >>> +{ >>> + struct rte_eth_dev *dev; >>> + >>> + if (port_id >= nb_ports) { >>> + PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id); >>> + return (-ENODEV); >>> + } >>> + >>> + dev = &rte_eth_devices[port_id]; >>> + if (dev == NULL) { >>> + PMD_DEBUG_TRACE("Invalid port device\n"); >>> + return (-ENODEV); >>> + } >>> + >>> + FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_intr_enable, -ENOTSUP); >>> + return (*dev->dev_ops->rx_queue_intr_enable)(dev, queue_id); >>> +} >>> + >>> +int >>> +rte_eth_dev_rx_queue_intr_disable(uint8_t port_id, >>> + uint16_t queue_id) >>> +{ >>> + struct rte_eth_dev *dev; >>> + >>> + if (port_id >= nb_ports) { >>> + PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id); >>> + return (-ENODEV); >>> + } >>> + >>> + dev = &rte_eth_devices[port_id]; >>> + if (dev == NULL) { >>> + PMD_DEBUG_TRACE("Invalid port device\n"); >>> + return (-ENODEV); >>> + } >>> + >>> + FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_intr_disable, -ENOTSUP); >>> + return (*dev->dev_ops->rx_queue_intr_disable)(dev, queue_id); >>> +} >>> + >>> #ifdef RTE_NIC_BYPASS >>> int rte_eth_dev_bypass_init(uint8_t port_id) >>> { >>> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h >>> index 84160c3..0f320a9 100644 >>> --- a/lib/librte_ether/rte_ethdev.h >>> +++ b/lib/librte_ether/rte_ethdev.h >>> @@ -848,6 +848,8 @@ struct rte_eth_fdir { >>> struct rte_intr_conf { >>> /** enable/disable lsc interrupt. 0 (default) - disable, 1 enable */ >>> uint16_t lsc; >>> + /** enable/disable rxq interrupt. 0 (default) - disable, 1 enable */ >>> + uint16_t rxq; >>> }; >>> >>> /** >>> @@ -1109,6 +1111,14 @@ typedef int (*eth_tx_queue_setup_t)(struct rte_eth_dev *dev, >>> const struct rte_eth_txconf *tx_conf); >>> /**< @internal Setup a transmit queue of an Ethernet device. */ >>> >>> +typedef int (*eth_rx_enable_intr_t)(struct rte_eth_dev *dev, >>> + uint16_t rx_queue_id); >>> +/**< @internal Enable interrupt of a receive queue of an Ethernet device. */ >>> + >>> +typedef int (*eth_rx_disable_intr_t)(struct rte_eth_dev *dev, >>> + uint16_t rx_queue_id); >>> +/**< @internal Disable interrupt of a receive queue of an Ethernet device. */ >>> + >>> typedef void (*eth_queue_release_t)(void *queue); >>> /**< @internal Release memory resources allocated by given RX/TX queue. */ >>> >>> @@ -1445,6 +1455,8 @@ struct eth_dev_ops { >>> eth_queue_start_t tx_queue_start;/**< Start TX for a queue.*/ >>> eth_queue_stop_t tx_queue_stop;/**< Stop TX for a queue.*/ >>> eth_rx_queue_setup_t rx_queue_setup;/**< Set up device RX queue.*/ >>> + eth_rx_enable_intr_t rx_queue_intr_enable; /**< Enable Rx queue interrupt. */ >>> + eth_rx_disable_intr_t rx_queue_intr_disable; /**< Disable Rx queue interrupt.*/ >>> eth_queue_release_t rx_queue_release;/**< Release RX queue.*/ >>> eth_rx_queue_count_t rx_queue_count; /**< Get Rx queue count. */ >>> eth_rx_descriptor_done_t rx_descriptor_done; /**< Check rxd DD bit */ >>> @@ -2811,6 +2823,51 @@ void _rte_eth_dev_callback_process(struct rte_eth_dev *dev, >>> enum rte_eth_event_type event); >>> >>> /** >>> + * When there is no rx packet coming in Rx Queue for a long time, we can >>> + * sleep lcore related to RX Queue for power saving, and enable rx interrupt >>> + * to be triggered when rx packect arrives. >>> + * >>> + * The rte_eth_dev_rx_queue_intr_enable() function enables rx queue >>> + * interrupt on specific rx queue of a port. >>> + * >>> + * @param port_id >>> + * The port identifier of the Ethernet device. >>> + * @param queue_id >>> + * The index of the receive queue from which to retrieve input packets. >>> + * The value must be in the range [0, nb_rx_queue - 1] previously supplied >>> + * to rte_eth_dev_configure(). >>> + * @return >>> + * - (0) if successful. >>> + * - (-ENOTSUP) if underlying hardware OR driver doesn't support >>> + * that operation. >>> + * - (-ENODEV) if *port_id* invalid. >>> + */ >>> +int rte_eth_dev_rx_queue_intr_enable(uint8_t port_id, >>> + uint16_t queue_id); >>> + >>> +/** >>> + * When lcore wakes up from rx interrupt indicating packet coming, disable rx >>> + * interrupt and returns to polling mode. >>> + * >>> + * The rte_eth_dev_rx_queue_intr_disable() function disables rx queue >>> + * interrupt on specific rx queue of a port. >>> + * >>> + * @param port_id >>> + * The port identifier of the Ethernet device. >>> + * @param queue_id >>> + * The index of the receive queue from which to retrieve input packets. >>> + * The value must be in the range [0, nb_rx_queue - 1] previously supplied >>> + * to rte_eth_dev_configure(). >>> + * @return >>> + * - (0) if successful. >>> + * - (-ENOTSUP) if underlying hardware OR driver doesn't support >>> + * that operation. >>> + * - (-ENODEV) if *port_id* invalid. >>> + */ >>> +int rte_eth_dev_rx_queue_intr_disable(uint8_t port_id, >>> + uint16_t queue_id); >>> + >>> +/** >>> * Turn on the LED on the Ethernet device. >>> * This function turns on the LED on the Ethernet device. >>> * >>> -- >>> 1.8.1.4 >>> >>> >> Need to export these functions >> Neil > Sorry, I do not get it. What do you mean export these functions? They have been > declared in rte_ethdev.h and defined here in rte_ethdev.c. And caller in > L3fwd-power example is able to link those two functions in the library. Hi Danny, I think what he meant is that you need to add them to the version map file so they are accessible when building shared libraries. Sergio
> -----Original Message----- > From: Gonzalez Monroy, Sergio > Sent: Thursday, February 19, 2015 4:22 PM > To: Zhou, Danny; Neil Horman > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add rx interrupt enable/disable functions > > On 19/02/2015 08:06, Zhou, Danny wrote: > > > >> -----Original Message----- > >> From: Neil Horman [mailto:nhorman@tuxdriver.com] > >> Sent: Tuesday, February 17, 2015 11:53 PM > >> To: Zhou, Danny > >> Cc: dev@dpdk.org > >> Subject: Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add rx interrupt enable/disable functions > >> > >> On Tue, Feb 17, 2015 at 09:47:15PM +0800, Zhou Danny wrote: > >>> v3 changes > >>> - Add return value for interrupt enable/disable functions > >>> > >>> Add two dev_ops functions to enable and disable rx queue interrupts > >>> > >>> Signed-off-by: Danny Zhou <danny.zhou@intel.com> > >>> Tested-by: Yong Liu <yong.liu@intel.com> > >>> --- > >>> lib/librte_ether/rte_ethdev.c | 43 ++++++++++++++++++++++++++++++++ > >>> lib/librte_ether/rte_ethdev.h | 57 +++++++++++++++++++++++++++++++++++++++++++ > >>> 2 files changed, 100 insertions(+) > >>> > >>> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c > >>> index ea3a1fb..d27469a 100644 > >>> --- a/lib/librte_ether/rte_ethdev.c > >>> +++ b/lib/librte_ether/rte_ethdev.c > >>> @@ -2825,6 +2825,49 @@ _rte_eth_dev_callback_process(struct rte_eth_dev *dev, > >>> } > >>> rte_spinlock_unlock(&rte_eth_dev_cb_lock); > >>> } > >>> + > >>> +int > >>> +rte_eth_dev_rx_queue_intr_enable(uint8_t port_id, > >>> + uint16_t queue_id) > >>> +{ > >>> + struct rte_eth_dev *dev; > >>> + > >>> + if (port_id >= nb_ports) { > >>> + PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id); > >>> + return (-ENODEV); > >>> + } > >>> + > >>> + dev = &rte_eth_devices[port_id]; > >>> + if (dev == NULL) { > >>> + PMD_DEBUG_TRACE("Invalid port device\n"); > >>> + return (-ENODEV); > >>> + } > >>> + > >>> + FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_intr_enable, -ENOTSUP); > >>> + return (*dev->dev_ops->rx_queue_intr_enable)(dev, queue_id); > >>> +} > >>> + > >>> +int > >>> +rte_eth_dev_rx_queue_intr_disable(uint8_t port_id, > >>> + uint16_t queue_id) > >>> +{ > >>> + struct rte_eth_dev *dev; > >>> + > >>> + if (port_id >= nb_ports) { > >>> + PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id); > >>> + return (-ENODEV); > >>> + } > >>> + > >>> + dev = &rte_eth_devices[port_id]; > >>> + if (dev == NULL) { > >>> + PMD_DEBUG_TRACE("Invalid port device\n"); > >>> + return (-ENODEV); > >>> + } > >>> + > >>> + FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_intr_disable, -ENOTSUP); > >>> + return (*dev->dev_ops->rx_queue_intr_disable)(dev, queue_id); > >>> +} > >>> + > >>> #ifdef RTE_NIC_BYPASS > >>> int rte_eth_dev_bypass_init(uint8_t port_id) > >>> { > >>> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h > >>> index 84160c3..0f320a9 100644 > >>> --- a/lib/librte_ether/rte_ethdev.h > >>> +++ b/lib/librte_ether/rte_ethdev.h > >>> @@ -848,6 +848,8 @@ struct rte_eth_fdir { > >>> struct rte_intr_conf { > >>> /** enable/disable lsc interrupt. 0 (default) - disable, 1 enable */ > >>> uint16_t lsc; > >>> + /** enable/disable rxq interrupt. 0 (default) - disable, 1 enable */ > >>> + uint16_t rxq; > >>> }; > >>> > >>> /** > >>> @@ -1109,6 +1111,14 @@ typedef int (*eth_tx_queue_setup_t)(struct rte_eth_dev *dev, > >>> const struct rte_eth_txconf *tx_conf); > >>> /**< @internal Setup a transmit queue of an Ethernet device. */ > >>> > >>> +typedef int (*eth_rx_enable_intr_t)(struct rte_eth_dev *dev, > >>> + uint16_t rx_queue_id); > >>> +/**< @internal Enable interrupt of a receive queue of an Ethernet device. */ > >>> + > >>> +typedef int (*eth_rx_disable_intr_t)(struct rte_eth_dev *dev, > >>> + uint16_t rx_queue_id); > >>> +/**< @internal Disable interrupt of a receive queue of an Ethernet device. */ > >>> + > >>> typedef void (*eth_queue_release_t)(void *queue); > >>> /**< @internal Release memory resources allocated by given RX/TX queue. */ > >>> > >>> @@ -1445,6 +1455,8 @@ struct eth_dev_ops { > >>> eth_queue_start_t tx_queue_start;/**< Start TX for a queue.*/ > >>> eth_queue_stop_t tx_queue_stop;/**< Stop TX for a queue.*/ > >>> eth_rx_queue_setup_t rx_queue_setup;/**< Set up device RX queue.*/ > >>> + eth_rx_enable_intr_t rx_queue_intr_enable; /**< Enable Rx queue interrupt. */ > >>> + eth_rx_disable_intr_t rx_queue_intr_disable; /**< Disable Rx queue interrupt.*/ > >>> eth_queue_release_t rx_queue_release;/**< Release RX queue.*/ > >>> eth_rx_queue_count_t rx_queue_count; /**< Get Rx queue count. */ > >>> eth_rx_descriptor_done_t rx_descriptor_done; /**< Check rxd DD bit */ > >>> @@ -2811,6 +2823,51 @@ void _rte_eth_dev_callback_process(struct rte_eth_dev *dev, > >>> enum rte_eth_event_type event); > >>> > >>> /** > >>> + * When there is no rx packet coming in Rx Queue for a long time, we can > >>> + * sleep lcore related to RX Queue for power saving, and enable rx interrupt > >>> + * to be triggered when rx packect arrives. > >>> + * > >>> + * The rte_eth_dev_rx_queue_intr_enable() function enables rx queue > >>> + * interrupt on specific rx queue of a port. > >>> + * > >>> + * @param port_id > >>> + * The port identifier of the Ethernet device. > >>> + * @param queue_id > >>> + * The index of the receive queue from which to retrieve input packets. > >>> + * The value must be in the range [0, nb_rx_queue - 1] previously supplied > >>> + * to rte_eth_dev_configure(). > >>> + * @return > >>> + * - (0) if successful. > >>> + * - (-ENOTSUP) if underlying hardware OR driver doesn't support > >>> + * that operation. > >>> + * - (-ENODEV) if *port_id* invalid. > >>> + */ > >>> +int rte_eth_dev_rx_queue_intr_enable(uint8_t port_id, > >>> + uint16_t queue_id); > >>> + > >>> +/** > >>> + * When lcore wakes up from rx interrupt indicating packet coming, disable rx > >>> + * interrupt and returns to polling mode. > >>> + * > >>> + * The rte_eth_dev_rx_queue_intr_disable() function disables rx queue > >>> + * interrupt on specific rx queue of a port. > >>> + * > >>> + * @param port_id > >>> + * The port identifier of the Ethernet device. > >>> + * @param queue_id > >>> + * The index of the receive queue from which to retrieve input packets. > >>> + * The value must be in the range [0, nb_rx_queue - 1] previously supplied > >>> + * to rte_eth_dev_configure(). > >>> + * @return > >>> + * - (0) if successful. > >>> + * - (-ENOTSUP) if underlying hardware OR driver doesn't support > >>> + * that operation. > >>> + * - (-ENODEV) if *port_id* invalid. > >>> + */ > >>> +int rte_eth_dev_rx_queue_intr_disable(uint8_t port_id, > >>> + uint16_t queue_id); > >>> + > >>> +/** > >>> * Turn on the LED on the Ethernet device. > >>> * This function turns on the LED on the Ethernet device. > >>> * > >>> -- > >>> 1.8.1.4 > >>> > >>> > >> Need to export these functions > >> Neil > > Sorry, I do not get it. What do you mean export these functions? They have been > > declared in rte_ethdev.h and defined here in rte_ethdev.c. And caller in > > L3fwd-power example is able to link those two functions in the library. > Hi Danny, > > I think what he meant is that you need to add them to the version map > file so they are accessible when building shared libraries. > > Sergio Thanks Sergio for pointing this out, I will add them to the version map file in V4 patch.
On Thu, Feb 19, 2015 at 07:58:38AM +0000, Zhou, Danny wrote: > > > > -----Original Message----- > > From: Neil Horman [mailto:nhorman@tuxdriver.com] > > Sent: Tuesday, February 17, 2015 11:55 PM > > To: Zhou, Danny > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add rx interrupt enable/disable functions > > > > On Tue, Feb 17, 2015 at 09:47:15PM +0800, Zhou Danny wrote: > > > v3 changes > > > - Add return value for interrupt enable/disable functions > > > > > > Add two dev_ops functions to enable and disable rx queue interrupts > > > > > > Signed-off-by: Danny Zhou <danny.zhou@intel.com> > > > Tested-by: Yong Liu <yong.liu@intel.com> > > > --- > > > lib/librte_ether/rte_ethdev.c | 43 ++++++++++++++++++++++++++++++++ > > > lib/librte_ether/rte_ethdev.h | 57 +++++++++++++++++++++++++++++++++++++++++++ > > > 2 files changed, 100 insertions(+) > > > > > > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c > > > index ea3a1fb..d27469a 100644 > > > --- a/lib/librte_ether/rte_ethdev.c > > > +++ b/lib/librte_ether/rte_ethdev.c > > > @@ -2825,6 +2825,49 @@ _rte_eth_dev_callback_process(struct rte_eth_dev *dev, > > > } > > > rte_spinlock_unlock(&rte_eth_dev_cb_lock); > > > } > > > + > > > +int > > > +rte_eth_dev_rx_queue_intr_enable(uint8_t port_id, > > > + uint16_t queue_id) > > > +{ > > > + struct rte_eth_dev *dev; > > > + > > > + if (port_id >= nb_ports) { > > > + PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id); > > > + return (-ENODEV); > > > + } > > > + > > > + dev = &rte_eth_devices[port_id]; > > > + if (dev == NULL) { > > > + PMD_DEBUG_TRACE("Invalid port device\n"); > > > + return (-ENODEV); > > > + } > > > + > > > + FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_intr_enable, -ENOTSUP); > > > + return (*dev->dev_ops->rx_queue_intr_enable)(dev, queue_id); > > > +} > > > + > > > +int > > > +rte_eth_dev_rx_queue_intr_disable(uint8_t port_id, > > > + uint16_t queue_id) > > > +{ > > > + struct rte_eth_dev *dev; > > > + > > > + if (port_id >= nb_ports) { > > > + PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id); > > > + return (-ENODEV); > > > + } > > > + > > > + dev = &rte_eth_devices[port_id]; > > > + if (dev == NULL) { > > > + PMD_DEBUG_TRACE("Invalid port device\n"); > > > + return (-ENODEV); > > > + } > > > + > > > + FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_intr_disable, -ENOTSUP); > > > + return (*dev->dev_ops->rx_queue_intr_disable)(dev, queue_id); > > > +} > > > + > > > #ifdef RTE_NIC_BYPASS > > > int rte_eth_dev_bypass_init(uint8_t port_id) > > > { > > > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h > > > index 84160c3..0f320a9 100644 > > > --- a/lib/librte_ether/rte_ethdev.h > > > +++ b/lib/librte_ether/rte_ethdev.h > > > @@ -848,6 +848,8 @@ struct rte_eth_fdir { > > > struct rte_intr_conf { > > > /** enable/disable lsc interrupt. 0 (default) - disable, 1 enable */ > > > uint16_t lsc; > > > + /** enable/disable rxq interrupt. 0 (default) - disable, 1 enable */ > > > + uint16_t rxq; > > > }; > > > > > > /** > > > @@ -1109,6 +1111,14 @@ typedef int (*eth_tx_queue_setup_t)(struct rte_eth_dev *dev, > > > const struct rte_eth_txconf *tx_conf); > > > /**< @internal Setup a transmit queue of an Ethernet device. */ > > > > > > +typedef int (*eth_rx_enable_intr_t)(struct rte_eth_dev *dev, > > > + uint16_t rx_queue_id); > > > +/**< @internal Enable interrupt of a receive queue of an Ethernet device. */ > > > + > > > +typedef int (*eth_rx_disable_intr_t)(struct rte_eth_dev *dev, > > > + uint16_t rx_queue_id); > > > +/**< @internal Disable interrupt of a receive queue of an Ethernet device. */ > > > + > > > typedef void (*eth_queue_release_t)(void *queue); > > > /**< @internal Release memory resources allocated by given RX/TX queue. */ > > > > > > @@ -1445,6 +1455,8 @@ struct eth_dev_ops { > > > eth_queue_start_t tx_queue_start;/**< Start TX for a queue.*/ > > > eth_queue_stop_t tx_queue_stop;/**< Stop TX for a queue.*/ > > > eth_rx_queue_setup_t rx_queue_setup;/**< Set up device RX queue.*/ > > > + eth_rx_enable_intr_t rx_queue_intr_enable; /**< Enable Rx queue interrupt. */ > > > + eth_rx_disable_intr_t rx_queue_intr_disable; /**< Disable Rx queue interrupt.*/ > > Put these at the end of eth_dev_ops if you want to avoid breaking ABI > > I purposely add those two APIs at current position to ensure all rxq related APIs are declared together > in eth_dev_ops. Anyway, moving them to the end is ok to me for the reason of ABI, though the code looks > a little bit ugly. > Right, pretty isn't a reason to break ABI as noted in the release notes doc Neil > > > > > eth_queue_release_t rx_queue_release;/**< Release RX queue.*/ > > > eth_rx_queue_count_t rx_queue_count; /**< Get Rx queue count. */ > > > eth_rx_descriptor_done_t rx_descriptor_done; /**< Check rxd DD bit */ > > > @@ -2811,6 +2823,51 @@ void _rte_eth_dev_callback_process(struct rte_eth_dev *dev, > > > enum rte_eth_event_type event); > > > > > > /** > > > + * When there is no rx packet coming in Rx Queue for a long time, we can > > > + * sleep lcore related to RX Queue for power saving, and enable rx interrupt > > > + * to be triggered when rx packect arrives. > > > + * > > > + * The rte_eth_dev_rx_queue_intr_enable() function enables rx queue > > > + * interrupt on specific rx queue of a port. > > > + * > > > + * @param port_id > > > + * The port identifier of the Ethernet device. > > > + * @param queue_id > > > + * The index of the receive queue from which to retrieve input packets. > > > + * The value must be in the range [0, nb_rx_queue - 1] previously supplied > > > + * to rte_eth_dev_configure(). > > > + * @return > > > + * - (0) if successful. > > > + * - (-ENOTSUP) if underlying hardware OR driver doesn't support > > > + * that operation. > > > + * - (-ENODEV) if *port_id* invalid. > > > + */ > > > +int rte_eth_dev_rx_queue_intr_enable(uint8_t port_id, > > > + uint16_t queue_id); > > > + > > > +/** > > > + * When lcore wakes up from rx interrupt indicating packet coming, disable rx > > > + * interrupt and returns to polling mode. > > > + * > > > + * The rte_eth_dev_rx_queue_intr_disable() function disables rx queue > > > + * interrupt on specific rx queue of a port. > > > + * > > > + * @param port_id > > > + * The port identifier of the Ethernet device. > > > + * @param queue_id > > > + * The index of the receive queue from which to retrieve input packets. > > > + * The value must be in the range [0, nb_rx_queue - 1] previously supplied > > > + * to rte_eth_dev_configure(). > > > + * @return > > > + * - (0) if successful. > > > + * - (-ENOTSUP) if underlying hardware OR driver doesn't support > > > + * that operation. > > > + * - (-ENODEV) if *port_id* invalid. > > > + */ > > > +int rte_eth_dev_rx_queue_intr_disable(uint8_t port_id, > > > + uint16_t queue_id); > > > + > > > +/** > > > * Turn on the LED on the Ethernet device. > > > * This function turns on the LED on the Ethernet device. > > > * > > > -- > > > 1.8.1.4 > > > > > > >
On Thu, Feb 19, 2015 at 08:34:22AM +0000, Zhou, Danny wrote: > > > > -----Original Message----- > > From: Gonzalez Monroy, Sergio > > Sent: Thursday, February 19, 2015 4:22 PM > > To: Zhou, Danny; Neil Horman > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add rx interrupt enable/disable functions > > > > On 19/02/2015 08:06, Zhou, Danny wrote: > > > > > >> -----Original Message----- > > >> From: Neil Horman [mailto:nhorman@tuxdriver.com] > > >> Sent: Tuesday, February 17, 2015 11:53 PM > > >> To: Zhou, Danny > > >> Cc: dev@dpdk.org > > >> Subject: Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add rx interrupt enable/disable functions > > >> > > >> On Tue, Feb 17, 2015 at 09:47:15PM +0800, Zhou Danny wrote: > > >>> v3 changes > > >>> - Add return value for interrupt enable/disable functions > > >>> > > >>> Add two dev_ops functions to enable and disable rx queue interrupts > > >>> > > >>> Signed-off-by: Danny Zhou <danny.zhou@intel.com> > > >>> Tested-by: Yong Liu <yong.liu@intel.com> > > >>> --- > > >>> lib/librte_ether/rte_ethdev.c | 43 ++++++++++++++++++++++++++++++++ > > >>> lib/librte_ether/rte_ethdev.h | 57 +++++++++++++++++++++++++++++++++++++++++++ > > >>> 2 files changed, 100 insertions(+) > > >>> > > >>> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c > > >>> index ea3a1fb..d27469a 100644 > > >>> --- a/lib/librte_ether/rte_ethdev.c > > >>> +++ b/lib/librte_ether/rte_ethdev.c > > >>> @@ -2825,6 +2825,49 @@ _rte_eth_dev_callback_process(struct rte_eth_dev *dev, > > >>> } > > >>> rte_spinlock_unlock(&rte_eth_dev_cb_lock); > > >>> } > > >>> + > > >>> +int > > >>> +rte_eth_dev_rx_queue_intr_enable(uint8_t port_id, > > >>> + uint16_t queue_id) > > >>> +{ > > >>> + struct rte_eth_dev *dev; > > >>> + > > >>> + if (port_id >= nb_ports) { > > >>> + PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id); > > >>> + return (-ENODEV); > > >>> + } > > >>> + > > >>> + dev = &rte_eth_devices[port_id]; > > >>> + if (dev == NULL) { > > >>> + PMD_DEBUG_TRACE("Invalid port device\n"); > > >>> + return (-ENODEV); > > >>> + } > > >>> + > > >>> + FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_intr_enable, -ENOTSUP); > > >>> + return (*dev->dev_ops->rx_queue_intr_enable)(dev, queue_id); > > >>> +} > > >>> + > > >>> +int > > >>> +rte_eth_dev_rx_queue_intr_disable(uint8_t port_id, > > >>> + uint16_t queue_id) > > >>> +{ > > >>> + struct rte_eth_dev *dev; > > >>> + > > >>> + if (port_id >= nb_ports) { > > >>> + PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id); > > >>> + return (-ENODEV); > > >>> + } > > >>> + > > >>> + dev = &rte_eth_devices[port_id]; > > >>> + if (dev == NULL) { > > >>> + PMD_DEBUG_TRACE("Invalid port device\n"); > > >>> + return (-ENODEV); > > >>> + } > > >>> + > > >>> + FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_intr_disable, -ENOTSUP); > > >>> + return (*dev->dev_ops->rx_queue_intr_disable)(dev, queue_id); > > >>> +} > > >>> + > > >>> #ifdef RTE_NIC_BYPASS > > >>> int rte_eth_dev_bypass_init(uint8_t port_id) > > >>> { > > >>> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h > > >>> index 84160c3..0f320a9 100644 > > >>> --- a/lib/librte_ether/rte_ethdev.h > > >>> +++ b/lib/librte_ether/rte_ethdev.h > > >>> @@ -848,6 +848,8 @@ struct rte_eth_fdir { > > >>> struct rte_intr_conf { > > >>> /** enable/disable lsc interrupt. 0 (default) - disable, 1 enable */ > > >>> uint16_t lsc; > > >>> + /** enable/disable rxq interrupt. 0 (default) - disable, 1 enable */ > > >>> + uint16_t rxq; > > >>> }; > > >>> > > >>> /** > > >>> @@ -1109,6 +1111,14 @@ typedef int (*eth_tx_queue_setup_t)(struct rte_eth_dev *dev, > > >>> const struct rte_eth_txconf *tx_conf); > > >>> /**< @internal Setup a transmit queue of an Ethernet device. */ > > >>> > > >>> +typedef int (*eth_rx_enable_intr_t)(struct rte_eth_dev *dev, > > >>> + uint16_t rx_queue_id); > > >>> +/**< @internal Enable interrupt of a receive queue of an Ethernet device. */ > > >>> + > > >>> +typedef int (*eth_rx_disable_intr_t)(struct rte_eth_dev *dev, > > >>> + uint16_t rx_queue_id); > > >>> +/**< @internal Disable interrupt of a receive queue of an Ethernet device. */ > > >>> + > > >>> typedef void (*eth_queue_release_t)(void *queue); > > >>> /**< @internal Release memory resources allocated by given RX/TX queue. */ > > >>> > > >>> @@ -1445,6 +1455,8 @@ struct eth_dev_ops { > > >>> eth_queue_start_t tx_queue_start;/**< Start TX for a queue.*/ > > >>> eth_queue_stop_t tx_queue_stop;/**< Stop TX for a queue.*/ > > >>> eth_rx_queue_setup_t rx_queue_setup;/**< Set up device RX queue.*/ > > >>> + eth_rx_enable_intr_t rx_queue_intr_enable; /**< Enable Rx queue interrupt. */ > > >>> + eth_rx_disable_intr_t rx_queue_intr_disable; /**< Disable Rx queue interrupt.*/ > > >>> eth_queue_release_t rx_queue_release;/**< Release RX queue.*/ > > >>> eth_rx_queue_count_t rx_queue_count; /**< Get Rx queue count. */ > > >>> eth_rx_descriptor_done_t rx_descriptor_done; /**< Check rxd DD bit */ > > >>> @@ -2811,6 +2823,51 @@ void _rte_eth_dev_callback_process(struct rte_eth_dev *dev, > > >>> enum rte_eth_event_type event); > > >>> > > >>> /** > > >>> + * When there is no rx packet coming in Rx Queue for a long time, we can > > >>> + * sleep lcore related to RX Queue for power saving, and enable rx interrupt > > >>> + * to be triggered when rx packect arrives. > > >>> + * > > >>> + * The rte_eth_dev_rx_queue_intr_enable() function enables rx queue > > >>> + * interrupt on specific rx queue of a port. > > >>> + * > > >>> + * @param port_id > > >>> + * The port identifier of the Ethernet device. > > >>> + * @param queue_id > > >>> + * The index of the receive queue from which to retrieve input packets. > > >>> + * The value must be in the range [0, nb_rx_queue - 1] previously supplied > > >>> + * to rte_eth_dev_configure(). > > >>> + * @return > > >>> + * - (0) if successful. > > >>> + * - (-ENOTSUP) if underlying hardware OR driver doesn't support > > >>> + * that operation. > > >>> + * - (-ENODEV) if *port_id* invalid. > > >>> + */ > > >>> +int rte_eth_dev_rx_queue_intr_enable(uint8_t port_id, > > >>> + uint16_t queue_id); > > >>> + > > >>> +/** > > >>> + * When lcore wakes up from rx interrupt indicating packet coming, disable rx > > >>> + * interrupt and returns to polling mode. > > >>> + * > > >>> + * The rte_eth_dev_rx_queue_intr_disable() function disables rx queue > > >>> + * interrupt on specific rx queue of a port. > > >>> + * > > >>> + * @param port_id > > >>> + * The port identifier of the Ethernet device. > > >>> + * @param queue_id > > >>> + * The index of the receive queue from which to retrieve input packets. > > >>> + * The value must be in the range [0, nb_rx_queue - 1] previously supplied > > >>> + * to rte_eth_dev_configure(). > > >>> + * @return > > >>> + * - (0) if successful. > > >>> + * - (-ENOTSUP) if underlying hardware OR driver doesn't support > > >>> + * that operation. > > >>> + * - (-ENODEV) if *port_id* invalid. > > >>> + */ > > >>> +int rte_eth_dev_rx_queue_intr_disable(uint8_t port_id, > > >>> + uint16_t queue_id); > > >>> + > > >>> +/** > > >>> * Turn on the LED on the Ethernet device. > > >>> * This function turns on the LED on the Ethernet device. > > >>> * > > >>> -- > > >>> 1.8.1.4 > > >>> > > >>> > > >> Need to export these functions > > >> Neil > > > Sorry, I do not get it. What do you mean export these functions? They have been > > > declared in rte_ethdev.h and defined here in rte_ethdev.c. And caller in > > > L3fwd-power example is able to link those two functions in the library. > > Hi Danny, > > > > I think what he meant is that you need to add them to the version map > > file so they are accessible when building shared libraries. > > > > Sergio > > Thanks Sergio for pointing this out, I will add them to the version map file in V4 patch. > Also, since you sort of called yourself out on this, maybe try building and testing with shared libraries as well as statically linked ones :) Neil
> -----Original Message----- > From: Neil Horman [mailto:nhorman@tuxdriver.com] > Sent: Thursday, February 19, 2015 9:10 PM > To: Zhou, Danny > Cc: Gonzalez Monroy, Sergio; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add rx interrupt enable/disable functions > > On Thu, Feb 19, 2015 at 08:34:22AM +0000, Zhou, Danny wrote: > > > > > > > -----Original Message----- > > > From: Gonzalez Monroy, Sergio > > > Sent: Thursday, February 19, 2015 4:22 PM > > > To: Zhou, Danny; Neil Horman > > > Cc: dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add rx interrupt enable/disable functions > > > > > > On 19/02/2015 08:06, Zhou, Danny wrote: > > > > > > > >> -----Original Message----- > > > >> From: Neil Horman [mailto:nhorman@tuxdriver.com] > > > >> Sent: Tuesday, February 17, 2015 11:53 PM > > > >> To: Zhou, Danny > > > >> Cc: dev@dpdk.org > > > >> Subject: Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add rx interrupt enable/disable functions > > > >> > > > >> On Tue, Feb 17, 2015 at 09:47:15PM +0800, Zhou Danny wrote: > > > >>> v3 changes > > > >>> - Add return value for interrupt enable/disable functions > > > >>> > > > >>> Add two dev_ops functions to enable and disable rx queue interrupts > > > >>> > > > >>> Signed-off-by: Danny Zhou <danny.zhou@intel.com> > > > >>> Tested-by: Yong Liu <yong.liu@intel.com> > > > >>> --- > > > >>> lib/librte_ether/rte_ethdev.c | 43 ++++++++++++++++++++++++++++++++ > > > >>> lib/librte_ether/rte_ethdev.h | 57 +++++++++++++++++++++++++++++++++++++++++++ > > > >>> 2 files changed, 100 insertions(+) > > > >>> > > > >>> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c > > > >>> index ea3a1fb..d27469a 100644 > > > >>> --- a/lib/librte_ether/rte_ethdev.c > > > >>> +++ b/lib/librte_ether/rte_ethdev.c > > > >>> @@ -2825,6 +2825,49 @@ _rte_eth_dev_callback_process(struct rte_eth_dev *dev, > > > >>> } > > > >>> rte_spinlock_unlock(&rte_eth_dev_cb_lock); > > > >>> } > > > >>> + > > > >>> +int > > > >>> +rte_eth_dev_rx_queue_intr_enable(uint8_t port_id, > > > >>> + uint16_t queue_id) > > > >>> +{ > > > >>> + struct rte_eth_dev *dev; > > > >>> + > > > >>> + if (port_id >= nb_ports) { > > > >>> + PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id); > > > >>> + return (-ENODEV); > > > >>> + } > > > >>> + > > > >>> + dev = &rte_eth_devices[port_id]; > > > >>> + if (dev == NULL) { > > > >>> + PMD_DEBUG_TRACE("Invalid port device\n"); > > > >>> + return (-ENODEV); > > > >>> + } > > > >>> + > > > >>> + FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_intr_enable, -ENOTSUP); > > > >>> + return (*dev->dev_ops->rx_queue_intr_enable)(dev, queue_id); > > > >>> +} > > > >>> + > > > >>> +int > > > >>> +rte_eth_dev_rx_queue_intr_disable(uint8_t port_id, > > > >>> + uint16_t queue_id) > > > >>> +{ > > > >>> + struct rte_eth_dev *dev; > > > >>> + > > > >>> + if (port_id >= nb_ports) { > > > >>> + PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id); > > > >>> + return (-ENODEV); > > > >>> + } > > > >>> + > > > >>> + dev = &rte_eth_devices[port_id]; > > > >>> + if (dev == NULL) { > > > >>> + PMD_DEBUG_TRACE("Invalid port device\n"); > > > >>> + return (-ENODEV); > > > >>> + } > > > >>> + > > > >>> + FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_intr_disable, -ENOTSUP); > > > >>> + return (*dev->dev_ops->rx_queue_intr_disable)(dev, queue_id); > > > >>> +} > > > >>> + > > > >>> #ifdef RTE_NIC_BYPASS > > > >>> int rte_eth_dev_bypass_init(uint8_t port_id) > > > >>> { > > > >>> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h > > > >>> index 84160c3..0f320a9 100644 > > > >>> --- a/lib/librte_ether/rte_ethdev.h > > > >>> +++ b/lib/librte_ether/rte_ethdev.h > > > >>> @@ -848,6 +848,8 @@ struct rte_eth_fdir { > > > >>> struct rte_intr_conf { > > > >>> /** enable/disable lsc interrupt. 0 (default) - disable, 1 enable */ > > > >>> uint16_t lsc; > > > >>> + /** enable/disable rxq interrupt. 0 (default) - disable, 1 enable */ > > > >>> + uint16_t rxq; > > > >>> }; > > > >>> > > > >>> /** > > > >>> @@ -1109,6 +1111,14 @@ typedef int (*eth_tx_queue_setup_t)(struct rte_eth_dev *dev, > > > >>> const struct rte_eth_txconf *tx_conf); > > > >>> /**< @internal Setup a transmit queue of an Ethernet device. */ > > > >>> > > > >>> +typedef int (*eth_rx_enable_intr_t)(struct rte_eth_dev *dev, > > > >>> + uint16_t rx_queue_id); > > > >>> +/**< @internal Enable interrupt of a receive queue of an Ethernet device. */ > > > >>> + > > > >>> +typedef int (*eth_rx_disable_intr_t)(struct rte_eth_dev *dev, > > > >>> + uint16_t rx_queue_id); > > > >>> +/**< @internal Disable interrupt of a receive queue of an Ethernet device. */ > > > >>> + > > > >>> typedef void (*eth_queue_release_t)(void *queue); > > > >>> /**< @internal Release memory resources allocated by given RX/TX queue. */ > > > >>> > > > >>> @@ -1445,6 +1455,8 @@ struct eth_dev_ops { > > > >>> eth_queue_start_t tx_queue_start;/**< Start TX for a queue.*/ > > > >>> eth_queue_stop_t tx_queue_stop;/**< Stop TX for a queue.*/ > > > >>> eth_rx_queue_setup_t rx_queue_setup;/**< Set up device RX queue.*/ > > > >>> + eth_rx_enable_intr_t rx_queue_intr_enable; /**< Enable Rx queue interrupt. */ > > > >>> + eth_rx_disable_intr_t rx_queue_intr_disable; /**< Disable Rx queue interrupt.*/ > > > >>> eth_queue_release_t rx_queue_release;/**< Release RX queue.*/ > > > >>> eth_rx_queue_count_t rx_queue_count; /**< Get Rx queue count. */ > > > >>> eth_rx_descriptor_done_t rx_descriptor_done; /**< Check rxd DD bit */ > > > >>> @@ -2811,6 +2823,51 @@ void _rte_eth_dev_callback_process(struct rte_eth_dev *dev, > > > >>> enum rte_eth_event_type event); > > > >>> > > > >>> /** > > > >>> + * When there is no rx packet coming in Rx Queue for a long time, we can > > > >>> + * sleep lcore related to RX Queue for power saving, and enable rx interrupt > > > >>> + * to be triggered when rx packect arrives. > > > >>> + * > > > >>> + * The rte_eth_dev_rx_queue_intr_enable() function enables rx queue > > > >>> + * interrupt on specific rx queue of a port. > > > >>> + * > > > >>> + * @param port_id > > > >>> + * The port identifier of the Ethernet device. > > > >>> + * @param queue_id > > > >>> + * The index of the receive queue from which to retrieve input packets. > > > >>> + * The value must be in the range [0, nb_rx_queue - 1] previously supplied > > > >>> + * to rte_eth_dev_configure(). > > > >>> + * @return > > > >>> + * - (0) if successful. > > > >>> + * - (-ENOTSUP) if underlying hardware OR driver doesn't support > > > >>> + * that operation. > > > >>> + * - (-ENODEV) if *port_id* invalid. > > > >>> + */ > > > >>> +int rte_eth_dev_rx_queue_intr_enable(uint8_t port_id, > > > >>> + uint16_t queue_id); > > > >>> + > > > >>> +/** > > > >>> + * When lcore wakes up from rx interrupt indicating packet coming, disable rx > > > >>> + * interrupt and returns to polling mode. > > > >>> + * > > > >>> + * The rte_eth_dev_rx_queue_intr_disable() function disables rx queue > > > >>> + * interrupt on specific rx queue of a port. > > > >>> + * > > > >>> + * @param port_id > > > >>> + * The port identifier of the Ethernet device. > > > >>> + * @param queue_id > > > >>> + * The index of the receive queue from which to retrieve input packets. > > > >>> + * The value must be in the range [0, nb_rx_queue - 1] previously supplied > > > >>> + * to rte_eth_dev_configure(). > > > >>> + * @return > > > >>> + * - (0) if successful. > > > >>> + * - (-ENOTSUP) if underlying hardware OR driver doesn't support > > > >>> + * that operation. > > > >>> + * - (-ENODEV) if *port_id* invalid. > > > >>> + */ > > > >>> +int rte_eth_dev_rx_queue_intr_disable(uint8_t port_id, > > > >>> + uint16_t queue_id); > > > >>> + > > > >>> +/** > > > >>> * Turn on the LED on the Ethernet device. > > > >>> * This function turns on the LED on the Ethernet device. > > > >>> * > > > >>> -- > > > >>> 1.8.1.4 > > > >>> > > > >>> > > > >> Need to export these functions > > > >> Neil > > > > Sorry, I do not get it. What do you mean export these functions? They have been > > > > declared in rte_ethdev.h and defined here in rte_ethdev.c. And caller in > > > > L3fwd-power example is able to link those two functions in the library. > > > Hi Danny, > > > > > > I think what he meant is that you need to add them to the version map > > > file so they are accessible when building shared libraries. > > > > > > Sergio > > > > Thanks Sergio for pointing this out, I will add them to the version map file in V4 patch. > > > Also, since you sort of called yourself out on this, maybe try building and testing > with shared libraries as well as statically linked ones :) > > Neil Well, I have try to build with shared libraries and send out V4 patch which Yong could test.
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index ea3a1fb..d27469a 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -2825,6 +2825,49 @@ _rte_eth_dev_callback_process(struct rte_eth_dev *dev, } rte_spinlock_unlock(&rte_eth_dev_cb_lock); } + +int +rte_eth_dev_rx_queue_intr_enable(uint8_t port_id, + uint16_t queue_id) +{ + struct rte_eth_dev *dev; + + if (port_id >= nb_ports) { + PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id); + return (-ENODEV); + } + + dev = &rte_eth_devices[port_id]; + if (dev == NULL) { + PMD_DEBUG_TRACE("Invalid port device\n"); + return (-ENODEV); + } + + FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_intr_enable, -ENOTSUP); + return (*dev->dev_ops->rx_queue_intr_enable)(dev, queue_id); +} + +int +rte_eth_dev_rx_queue_intr_disable(uint8_t port_id, + uint16_t queue_id) +{ + struct rte_eth_dev *dev; + + if (port_id >= nb_ports) { + PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id); + return (-ENODEV); + } + + dev = &rte_eth_devices[port_id]; + if (dev == NULL) { + PMD_DEBUG_TRACE("Invalid port device\n"); + return (-ENODEV); + } + + FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_intr_disable, -ENOTSUP); + return (*dev->dev_ops->rx_queue_intr_disable)(dev, queue_id); +} + #ifdef RTE_NIC_BYPASS int rte_eth_dev_bypass_init(uint8_t port_id) { diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index 84160c3..0f320a9 100644 --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librte_ether/rte_ethdev.h @@ -848,6 +848,8 @@ struct rte_eth_fdir { struct rte_intr_conf { /** enable/disable lsc interrupt. 0 (default) - disable, 1 enable */ uint16_t lsc; + /** enable/disable rxq interrupt. 0 (default) - disable, 1 enable */ + uint16_t rxq; }; /** @@ -1109,6 +1111,14 @@ typedef int (*eth_tx_queue_setup_t)(struct rte_eth_dev *dev, const struct rte_eth_txconf *tx_conf); /**< @internal Setup a transmit queue of an Ethernet device. */ +typedef int (*eth_rx_enable_intr_t)(struct rte_eth_dev *dev, + uint16_t rx_queue_id); +/**< @internal Enable interrupt of a receive queue of an Ethernet device. */ + +typedef int (*eth_rx_disable_intr_t)(struct rte_eth_dev *dev, + uint16_t rx_queue_id); +/**< @internal Disable interrupt of a receive queue of an Ethernet device. */ + typedef void (*eth_queue_release_t)(void *queue); /**< @internal Release memory resources allocated by given RX/TX queue. */ @@ -1445,6 +1455,8 @@ struct eth_dev_ops { eth_queue_start_t tx_queue_start;/**< Start TX for a queue.*/ eth_queue_stop_t tx_queue_stop;/**< Stop TX for a queue.*/ eth_rx_queue_setup_t rx_queue_setup;/**< Set up device RX queue.*/ + eth_rx_enable_intr_t rx_queue_intr_enable; /**< Enable Rx queue interrupt. */ + eth_rx_disable_intr_t rx_queue_intr_disable; /**< Disable Rx queue interrupt.*/ eth_queue_release_t rx_queue_release;/**< Release RX queue.*/ eth_rx_queue_count_t rx_queue_count; /**< Get Rx queue count. */ eth_rx_descriptor_done_t rx_descriptor_done; /**< Check rxd DD bit */ @@ -2811,6 +2823,51 @@ void _rte_eth_dev_callback_process(struct rte_eth_dev *dev, enum rte_eth_event_type event); /** + * When there is no rx packet coming in Rx Queue for a long time, we can + * sleep lcore related to RX Queue for power saving, and enable rx interrupt + * to be triggered when rx packect arrives. + * + * The rte_eth_dev_rx_queue_intr_enable() function enables rx queue + * interrupt on specific rx queue of a port. + * + * @param port_id + * The port identifier of the Ethernet device. + * @param queue_id + * The index of the receive queue from which to retrieve input packets. + * The value must be in the range [0, nb_rx_queue - 1] previously supplied + * to rte_eth_dev_configure(). + * @return + * - (0) if successful. + * - (-ENOTSUP) if underlying hardware OR driver doesn't support + * that operation. + * - (-ENODEV) if *port_id* invalid. + */ +int rte_eth_dev_rx_queue_intr_enable(uint8_t port_id, + uint16_t queue_id); + +/** + * When lcore wakes up from rx interrupt indicating packet coming, disable rx + * interrupt and returns to polling mode. + * + * The rte_eth_dev_rx_queue_intr_disable() function disables rx queue + * interrupt on specific rx queue of a port. + * + * @param port_id + * The port identifier of the Ethernet device. + * @param queue_id + * The index of the receive queue from which to retrieve input packets. + * The value must be in the range [0, nb_rx_queue - 1] previously supplied + * to rte_eth_dev_configure(). + * @return + * - (0) if successful. + * - (-ENOTSUP) if underlying hardware OR driver doesn't support + * that operation. + * - (-ENODEV) if *port_id* invalid. + */ +int rte_eth_dev_rx_queue_intr_disable(uint8_t port_id, + uint16_t queue_id); + +/** * Turn on the LED on the Ethernet device. * This function turns on the LED on the Ethernet device. *