[dpdk-dev] net/mlx5: fix all multi verification code position
Checks
Commit Message
All multi code should not be handled in exit part of the code but in the
mainline of the function.
Fixes: 4241d84c0a32 ("net/mlx5: fix flow type for allmulti rules")
Cc: rasland@mellanox.com
Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
---
drivers/net/mlx5/mlx5_flow.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
Comments
> On Jan 11, 2018, at 1:25 AM, Nelio Laranjeiro <nelio.laranjeiro@6wind.com> wrote:
>
> All multi code should not be handled in exit part of the code but in the
> mainline of the function.
>
> Fixes: 4241d84c0a32 ("net/mlx5: fix flow type for allmulti rules")
> Cc: rasland@mellanox.com
>
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> ---
Acked-by: Yongseok Koh <yskoh@mellanox.com>
Thanks
Thursday, January 18, 2018 1:03 AM, Yongseok Koh:
> > On Jan 11, 2018, at 1:25 AM, Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> wrote:
> >
> > All multi code should not be handled in exit part of the code but in
> > the mainline of the function.
> >
> > Fixes: 4241d84c0a32 ("net/mlx5: fix flow type for allmulti rules")
> > Cc: rasland@mellanox.com
> >
> > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> > ---
> Acked-by: Yongseok Koh <yskoh@mellanox.com>
Applied to next-net-mlx, thanks.
>
> Thanks
@@ -1156,16 +1156,6 @@ priv_flow_convert(struct priv *priv,
attr->priority +
hash_rxq_init[parser->layer].flow_priority;
}
-exit_free:
- /* Only verification is expected, all resources should be released. */
- if (!parser->create) {
- for (i = 0; i != hash_rxq_init_n; ++i) {
- if (parser->queue[i].ibv_attr) {
- rte_free(parser->queue[i].ibv_attr);
- parser->queue[i].ibv_attr = NULL;
- }
- }
- }
if (parser->allmulti &&
parser->layer == HASH_RXQ_ETH) {
for (i = 0; i != hash_rxq_init_n; ++i) {
@@ -1177,6 +1167,16 @@ priv_flow_convert(struct priv *priv,
IBV_FLOW_ATTR_MC_DEFAULT;
}
}
+exit_free:
+ /* Only verification is expected, all resources should be released. */
+ if (!parser->create) {
+ for (i = 0; i != hash_rxq_init_n; ++i) {
+ if (parser->queue[i].ibv_attr) {
+ rte_free(parser->queue[i].ibv_attr);
+ parser->queue[i].ibv_attr = NULL;
+ }
+ }
+ }
return ret;
exit_enomem:
for (i = 0; i != hash_rxq_init_n; ++i) {