Message ID | 20171213195538.14290-4-pbhagavatula@caviumnetworks.com (mailing list archive) |
---|---|
State | Superseded, archived |
Delegated to: | Thomas Monjalon |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0D67D1B01F; Wed, 13 Dec 2017 20:56:28 +0100 (CET) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0055.outbound.protection.outlook.com [104.47.36.55]) by dpdk.org (Postfix) with ESMTP id 34A4F1B01F for <dev@dpdk.org>; Wed, 13 Dec 2017 20:56:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=10SY4Vg4NpobTNZFIEaQvRfwWh9Fd+5vi46UxVhZklQ=; b=TdoOH3BEqc4U7Fz5WJtgqblvNviditXjRwBlYhicPMb9pRNsDlV+c0zcS0Cf+m8A6kDQJYF89q8QpN/K7aW/igfrGEOFkWXbFRxczpii2XqXZ1Ku1i1GUDOMxFw2BhRzckmdkDJQgPdWI9Bh4V6k+5UFtX3nrbWqu6Vpe8JWzNA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from localhost.localdomain (111.93.218.67) by DM5PR07MB3466.namprd07.prod.outlook.com (10.164.153.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Wed, 13 Dec 2017 19:56:22 +0000 From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com> To: jerin.jacob@caviumnetworks.com, jingjing.wu@intel.com, bruce.richardson@intel.com, hemant.agrawal@nxp.com, ferruh.yigit@intel.com, thomas@monjalon.net, olivier.matz@6wind.com Cc: dev@dpdk.org, Pavan Nikhilesh <pbhagavatula@caviumnetworks.com> Date: Thu, 14 Dec 2017 01:25:38 +0530 Message-Id: <20171213195538.14290-4-pbhagavatula@caviumnetworks.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20171213195538.14290-1-pbhagavatula@caviumnetworks.com> References: <20171213195538.14290-1-pbhagavatula@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: HK2PR02CA0186.apcprd02.prod.outlook.com (10.171.31.22) To DM5PR07MB3466.namprd07.prod.outlook.com (10.164.153.21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6ca9c9f3-8042-4b1f-ece6-08d54263975b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307); SRVR:DM5PR07MB3466; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3466; 3:1i2i2mVEK0c7mS/T9bNe9e07pQRKJdCB6kGD9M8Oew3t5ZErzzbNRp0jBNcwWuyFp5f+jSpevx1jxoFeUlPhjUwCdbpJGRzo9YjLECg2Dn0kifE7d9aR1bVziR7xAUAXOZShWcuBbGClSuFTk4QvtNSPcP682NXuZfky5FQ/uo/IAfJ1/Yem1jxRv6OaqELztwi/GMIxn6iNbzgZ4r2cqVk/jj1S8lWPHXjkP7MOhU9h7My6zcGRq8WOvebm/L55; 25:wLiVqkYU91nWlTSpJ+Lo8zxaiH+Ka9hTaU4BCsA6q4HZl54I5gQzk2Z2gVS/nuVspHrbZ5O+/0Ii4eqZotHMnTE1+oIjGcy3aCgRd6qlXMIae5i++Sn0VQJiuiK3eerTQ1gICmW0SD2su363EuVZc/F7lxeGBDrRW+vqnbkjMTt/lincoz4dtw29YHCQdVkpkGRiB8/kLrrBPQEA3V7WS09a1HwYGYJ15fiSAfVYXT6WKGX9DFN3Y2QcN+EAw8dtUf/PZA4zrmUEWZLRl7Mtt8GU1NYPoKaLWblPe4dEtvlxscWT2gy2A8s/NEGmY2aAVacXao83DZ73vMZr24wMLw==; 31:HYZEUZJMxGdlPiBREAgBccPwLuFIqvFp/5M0PWDHcip0X77EUbTQfZgaScS1LyaRwFqvbjqtoMxlF4IbY9GYOM3054crS/9c6HvLitZmwc7d+nauFFZ5HGKXa9ZhwC8dMJ81DHS0IVxTXyqoSFT/5i8jrV7jDDpiMwLjM4PW3MbMeDrP6PQUb091SH2/vEw37xh9IuNmpvdVbyCtM9E/xGXo1DGcuzqEczSfNfSZV00= X-MS-TrafficTypeDiagnostic: DM5PR07MB3466: X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3466; 20:TY/BNASAxi8UnHIYMCqr4ykFqtiIPw/Z5aIALFmQF5hMYBhujLbS2bhx7G0kvBQCF6eKd6n8n7eQDEIpKC4kBOV6MJ0uYbXcUw95g4nTWAtuvRdkl3QmNMvCChhydz5PahL03jnqr7RbIJsA4ZA73nuCy0SfpiCOMI1XEntNPYA19Fzurn0d2nOzbiUMxFPTJGwMQkI5XGWycl61tJcPAS5HpyAEkoh3ll5pjIlNYnhNzLOOvPI36m0ESynmpUL0/PFPS7EDuU+niQYqqyeeZu+nxFx5a4TUNVpdJoq3aitDa4oSUUXoQRkf4DRqBdC/CQA4h2+rA30v/ja6CymOuJNgfeg3p2QXSSvr8i0f8tNkxM8eDozZhf+0iisPkb3RFQGpbbYKOoppsFHOocY1rZ2zaB27qn20qqVkn6Tc+FXTG5S0PPOHNVfP8j2aF800EiUTi3iSYrD5eIgjFFDiNz2izEpRrb7wGSBUPjsTi14yjNfm79XZyjO4KJNmk5qDKoV81TyK7PJ+r+t4tVu7r0c4JUEwkOBeiP7GUUY6ymIBQCLCDNBf9HJpDbJMpLfLDRu5V+BPmHjBk7GHK2Yg+Ys/Y2L0ptLgF89YugD8gGY=; 4:L2cCpt4o3OYldFzC8HpOKRbNim7T6EWf72XbRrPL2f9nvERoAP3wjRj/f2lR2wzyLrtLqlbs0/RYQQijcl2loTBP2yFcESfE6Hn0mE4s9Ym9mhynLKiIjCQq6fqUA7GfbioGr2tDiU+XC0V6PB5BzUCK7p5L/C+nHmMAAw8qUUfZcpU7C4iyhrkQ6rMhHo4YGZ/BTCudnCb8SG+M9gw3Jt1UTcqEEiidJYIwTEFIuxsdGbeF+shmLSk4EuybpFtk1v4LkJK6mACLtt+Og+3PkQ== X-Microsoft-Antispam-PRVS: <DM5PR07MB34661813E3731C864B85246880350@DM5PR07MB3466.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(3231023)(6041248)(20161123555025)(20161123562025)(20161123560025)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:DM5PR07MB3466; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:DM5PR07MB3466; X-Forefront-PRVS: 052017CAF1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(366004)(39860400002)(346002)(376002)(189003)(199004)(97736004)(2950100002)(6512007)(47776003)(2906002)(36756003)(1076002)(5660300001)(52116002)(6116002)(105586002)(305945005)(7736002)(3846002)(66066001)(6486002)(72206003)(50466002)(50226002)(25786009)(48376002)(8676002)(81166006)(81156014)(478600001)(4326008)(316002)(8936002)(68736007)(16586007)(53936002)(6666003)(8656006)(107886003)(51416003)(106356001)(76176011)(16526018)(6506007)(42882006)(5009440100003)(386003)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB3466; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR07MB3466; 23:aw3v8DfKE7ykbGY1ZReYGKrONE+jMmzY8S8YAXhOF?= IHbILpwD0E9W7YQ3IBPBmZh3jheFaXHENzC17swzv0zfnXa6kwr40RkNy7b4UBOrsbYn+ozhixJev1NOJCdBfXn11KbMiokItAUApehws1JQs/NxKWPGW5vhH8/WXqV2F60EUm3PXOR4nQoisTpD38S26ruYcrJQFnD58OU7j+JT2OXMQIIp3n1r7szMxf0cklhHM5V6MkxGwIZksgm3TT/n59jJ+ZUnvvHB7iB3x1Qv7x4Lq1OnBVVOlnzEya0J0r2aSp7EKwFsp8YJxW0676sYO3oBPRDmncSHGo/dvaFHoWiJlsaMuNep/YnDzujXw1xPY4MOp5ChAEsBHZ3W5LMlx+uNMh5UxVvern4X/2rPd0/kG66E/Byud615QLOsMYjuQ/D+kIubtwhICYpU/0oYT+awa3fWcv40ZNOV33JhFdb9eeqRM6VUUCJsTXvnRZAhhnvtxNpJNUu1SJpSn2W0CXN6hoCTYWKOKTUJS/UvaAI+k0FsFq52LTLM78ivFyqWdQdyEa/DaZCz8IoueGhGC7oF+hZ//Sr6Jaiqj0p4pPaqtoVPiTxFCzu+JnanHS9DlwdT25t9VIwzSMYG6kZrhjc12gBnq8GK+Yau5QDas4OjuV1cjNT9gk8pNhL3slSalrkGXtCvZim6s0nZq52SSuOCfY8lQFdF/KNUymMvbfUvhyB/EZUWIXZ806YE8hLuSgUWhc8RwhO1MQEVFKR5UVu9dmkBIRg4AIKQ2UdTVTlO9O0VnlLUIafDfnNan3ZUkiaUYiDnN1xiTINP1rE5qA8u5zfNuRqnXTJDm2BvCxPa3luV6bRLTTEna7/6Fg8MztWNg2kzXavdadZFLIZtIJbyx0KbVYCScdFZ4btopR2OUFbtTCp0UCKPriBy1+LdqJLjoydntCTzM+5epnUz1DTYEeifL0Bt52O1djmmv6UbQao18qzs9Ll9MmuH6YHw5vUUyN5MES6Zz/zfj26FKWp14HFN7q/69gf/b8BVC0aNdacYadkMHEs51dBIsP7QmCm0lV7b/tIU2iRX00qYhpfRIpFljfLpkYcqOrXqWJEBRZxGQ9kfgFiRy61efUDYLd2ByL0cVx33T2I5HQhEmGbpXs4OjiwPrXgav8RHA== X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3466; 6:6Ef3iwF+zXTWTG4FNPc/LA1isiwNPAC2qpha5CT7k/CXzZRRtMfHJdlm8CU6oVZLQoKUMruBFlb2U6LLQHu/NN+54YXvlCRPTRPKdk3/XEJsJBxdqfGylmsDf1PqOSm1WV/CGAPZrPD/ERMIqMdBevZo1weI3lTm0ZeX9P/2u54UDj4K1xz/o/ih8g4uVOQjDtS8LBhO8rTGtKQ/6qLHZKk6kVourlBosoBpEMQZxMJu/ag1i3N0NMgdQhA7WlW4GqJ8hWx20Bfm1187PBMy1Bz1hJtE3slQoNXCn/dtPAXOov+r45wFWnp2bGXXHCi4T1BdFIgGkRkuXuK/9ygzFwW7ptsAFZyjloWPTl51wKI=; 5:iIQbXGEtlOGnIm5JvL2plMIY+02X633H79Wb+NsSzE9mZUicSN5EMgJ6Yp7KvOgpHCk2+RA53TGugt6c85XDIGJx8XU8c5BJnaXBeIyosRN1IATMoN7ztRQQHphBjVvzoky1mePhA4TNjwQX7E049Tts119xkqtF27ONg/r9wTY=; 24:xNrbXGSphGBws5yXA4sVeYSqYm4qgOb4lECQ5ljImT9vrIF99b52/izU7d+RwqJ1k9X77qvblCb9FV2esgcHLR5FvsZ98brSfaIx0w4KqjI=; 7:Or0XW4bKlGoH2r7dcgcdJDQowVm3+xiREmN6Rs47xiOuLmM0nudNcXsO32JCyXDFtQgNh2s/Waa7+LPFS7EUJyjbUVIv7ESt8Px3YYOHd3pWioyCuJipLooPJPcJIHaIrzkv6ceyzffdJi95cjig1FFmlai4avEFwVloKAbWBEEXUEPFn4sj2s2Y7rFM2fogm9SajQ3Y5xgTTmt56NFep4c8k4+RT9W9hVACKafp55OD4uhhjlBw7gia9hUMJVet SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2017 19:56:22.0747 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6ca9c9f3-8042-4b1f-ece6-08d54263975b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3466 Subject: [dpdk-dev] [PATCH 3/3] app/testpmd: set preferred mempool as default pktpool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/Intel-compilation | success | Compilation OK |
Commit Message
Pavan Nikhilesh
Dec. 13, 2017, 7:55 p.m. UTC
Set the mempool preferred by the ethernet devices as default mbuf
mempool before creating the pktpool.
Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---
app/test-pmd/testpmd.c | 2 ++
1 file changed, 2 insertions(+)
Comments
Hi Pavan, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pavan Nikhilesh > Sent: Thursday, December 14, 2017 3:56 AM > To: jerin.jacob@caviumnetworks.com; Wu, Jingjing <jingjing.wu@intel.com>; > Richardson, Bruce <bruce.richardson@intel.com>; hemant.agrawal@nxp.com; > Yigit, Ferruh <ferruh.yigit@intel.com>; thomas@monjalon.net; > olivier.matz@6wind.com > Cc: dev@dpdk.org; Pavan Nikhilesh <pbhagavatula@caviumnetworks.com> > Subject: [dpdk-dev] [PATCH 3/3] app/testpmd: set preferred mempool as > default pktpool > > Set the mempool preferred by the ethernet devices as default mbuf > mempool before creating the pktpool. > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com> > --- > app/test-pmd/testpmd.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > c3ab44849..bfea35613 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -533,6 +533,8 @@ mbuf_pool_create(uint16_t mbuf_seg_size, unsigned > nb_mbuf, > rte_mempool_obj_iter(rte_mp, rte_pktmbuf_init, NULL); > } else { > /* wrapper to rte_mempool_create() */ > + RTE_LOG(INFO, USER1, "preferred mempool ops %s > selected\n", > + rte_eth_dev_get_preferred_pool_name(1)); This '1' looks like hardcode. May I suggest to change it to 'true'?
Hi Lu, On Tue, Jan 16, 2018 at 06:06:50AM +0000, Lu, Wenzhuo wrote: > Hi Pavan, > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pavan Nikhilesh > > Sent: Thursday, December 14, 2017 3:56 AM > > To: jerin.jacob@caviumnetworks.com; Wu, Jingjing <jingjing.wu@intel.com>; > > Richardson, Bruce <bruce.richardson@intel.com>; hemant.agrawal@nxp.com; > > Yigit, Ferruh <ferruh.yigit@intel.com>; thomas@monjalon.net; > > olivier.matz@6wind.com > > Cc: dev@dpdk.org; Pavan Nikhilesh <pbhagavatula@caviumnetworks.com> > > Subject: [dpdk-dev] [PATCH 3/3] app/testpmd: set preferred mempool as > > default pktpool > > > > Set the mempool preferred by the ethernet devices as default mbuf > > mempool before creating the pktpool. > > > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com> > > --- > > app/test-pmd/testpmd.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > > c3ab44849..bfea35613 100644 > > --- a/app/test-pmd/testpmd.c > > +++ b/app/test-pmd/testpmd.c > > @@ -533,6 +533,8 @@ mbuf_pool_create(uint16_t mbuf_seg_size, unsigned > > nb_mbuf, > > rte_mempool_obj_iter(rte_mp, rte_pktmbuf_init, NULL); > > } else { > > /* wrapper to rte_mempool_create() */ > > + RTE_LOG(INFO, USER1, "preferred mempool ops %s > > selected\n", > > + rte_eth_dev_get_preferred_pool_name(1)); > This '1' looks like hardcode. May I suggest to change it to 'true'? This patchset will be superseeded by http://dpdk.org/dev/patchwork/patch/33716/ I will mark the same. Thanks, Pavan.
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index c3ab44849..bfea35613 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -533,6 +533,8 @@ mbuf_pool_create(uint16_t mbuf_seg_size, unsigned nb_mbuf, rte_mempool_obj_iter(rte_mp, rte_pktmbuf_init, NULL); } else { /* wrapper to rte_mempool_create() */ + RTE_LOG(INFO, USER1, "preferred mempool ops %s selected\n", + rte_eth_dev_get_preferred_pool_name(1)); rte_mp = rte_pktmbuf_pool_create(pool_name, nb_mbuf, mb_mempool_cache, 0, mbuf_seg_size, socket_id); }