[dpdk-dev,v3] net/i40e: fix flag sent to mac_address_write
Checks
Commit Message
Current flag is in wrong byte order.
Use defined macro as it is done in Linux driver.
Fixes: e18e01e92c29 ("i40e: support default MAC address setting")
Cc: stable@dpdk.org
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
---
v3:
* fix commit message
v2:
* fix checkpatch warning (long line)
* fix commit subject
* add Fixes line
* CC to stable
---
drivers/net/i40e/i40e_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Igor Ryzhov
> Sent: Monday, January 15, 2018 4:32 PM
> To: dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v3] net/i40e: fix flag sent to mac_address_write
>
> Current flag is in wrong byte order.
> Use defined macro as it is done in Linux driver.
>
> Fixes: e18e01e92c29 ("i40e: support default MAC address setting")
> Cc: stable@dpdk.org
>
> Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
Acked-by: Beilei Xing <beilei.xing@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xing, Beilei
> Sent: Monday, January 15, 2018 6:19 PM
> To: Igor Ryzhov; dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix flag sent to mac_address_write
>
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Igor Ryzhov
> > Sent: Monday, January 15, 2018 4:32 PM
> > To: dev@dpdk.org
> > Cc: Xing, Beilei <beilei.xing@intel.com>; stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH v3] net/i40e: fix flag sent to mac_address_write
> >
> > Current flag is in wrong byte order.
> > Use defined macro as it is done in Linux driver.
> >
> > Fixes: e18e01e92c29 ("i40e: support default MAC address setting")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
> Acked-by: Beilei Xing <beilei.xing@intel.com>
Applied to dpdk-next-net-intel, with minor commit log changes. Thanks!
/Helin
@@ -10795,8 +10795,8 @@ static void i40e_set_default_mac_addr(struct rte_eth_dev *dev,
return;
}
- /* Flags: 0x3 updates port address */
- i40e_aq_mac_address_write(hw, 0x3, mac_addr->addr_bytes, NULL);
+ i40e_aq_mac_address_write(hw, I40E_AQC_WRITE_TYPE_LAA_WOL,
+ mac_addr->addr_bytes, NULL);
}
static int