[dpdk-dev,1/2] i40e:advertise TSO capability

Message ID 1423463570-12947-2-git-send-email-jijiang.liu@intel.com (mailing list archive)
State Superseded, archived
Headers

Commit Message

Jijiang Liu Feb. 9, 2015, 6:32 a.m. UTC
  Advertise the DEV_TX_OFFLOAD_TCP_TSO flag in the PMD features. It means that the i40e PMD supports the offload of TSO.

Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
Signed-off-by: Miroslaw Walukiewicz <miroslaw.walukiewicz@intel.com>
---
 lib/librte_pmd_i40e/i40e_ethdev.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
  

Comments

David Marchand Feb. 9, 2015, 9:09 a.m. UTC | #1
Hello,

On Mon, Feb 9, 2015 at 7:32 AM, Jijiang Liu <jijiang.liu@intel.com> wrote:

> Advertise the DEV_TX_OFFLOAD_TCP_TSO flag in the PMD features. It means
> that the i40e PMD supports the offload of TSO.
>
> Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
> Signed-off-by: Miroslaw Walukiewicz <miroslaw.walukiewicz@intel.com>
> ---
>  lib/librte_pmd_i40e/i40e_ethdev.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c
> b/lib/librte_pmd_i40e/i40e_ethdev.c
> index 6f385d2..fd625f9 100644
> --- a/lib/librte_pmd_i40e/i40e_ethdev.c
> +++ b/lib/librte_pmd_i40e/i40e_ethdev.c
> @@ -1530,7 +1530,8 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct
> rte_eth_dev_info *dev_info)
>                 DEV_TX_OFFLOAD_UDP_CKSUM |
>                 DEV_TX_OFFLOAD_TCP_CKSUM |
>                 DEV_TX_OFFLOAD_SCTP_CKSUM |
> -               DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM;
> +               DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM |
> +               DEV_TX_OFFLOAD_TCP_TSO;
>         dev_info->reta_size = pf->hash_lut_size;
>
>         dev_info->default_rxconf = (struct rte_eth_rxconf) {
>


Correct me if I am wrong, but this patch introduces a feature implemented
in the following commit.
Those patches should be submitted in the opposite order.
  

Patch

diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c
index 6f385d2..fd625f9 100644
--- a/lib/librte_pmd_i40e/i40e_ethdev.c
+++ b/lib/librte_pmd_i40e/i40e_ethdev.c
@@ -1530,7 +1530,8 @@  i40e_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 		DEV_TX_OFFLOAD_UDP_CKSUM |
 		DEV_TX_OFFLOAD_TCP_CKSUM |
 		DEV_TX_OFFLOAD_SCTP_CKSUM |
-		DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM;
+		DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM |
+		DEV_TX_OFFLOAD_TCP_TSO;
 	dev_info->reta_size = pf->hash_lut_size;
 
 	dev_info->default_rxconf = (struct rte_eth_rxconf) {