| Message ID | 20171012130726.4332-4-alok.makhariya@nxp.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Pablo de Lara Guarch |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B7C271B300; Thu, 12 Oct 2017 15:10:44 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0065.outbound.protection.outlook.com [104.47.36.65]) by dpdk.org (Postfix) with ESMTP id 3D1E11B2EA; Thu, 12 Oct 2017 15:10:42 +0200 (CEST) Received: from BN6PR03CA0096.namprd03.prod.outlook.com (10.164.122.162) by CO2PR03MB2359.namprd03.prod.outlook.com (10.166.93.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Thu, 12 Oct 2017 13:10:40 +0000 Received: from BN1BFFO11FD037.protection.gbl (2a01:111:f400:7c10::1:104) by BN6PR03CA0096.outlook.office365.com (2603:10b6:405:6f::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.56.11 via Frontend Transport; Thu, 12 Oct 2017 13:10:40 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; NXP1.onmicrosoft.com; dkim=none (message not signed) header.d=none;NXP1.onmicrosoft.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BN1BFFO11FD037.mail.protection.outlook.com (10.58.144.100) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.77.10 via Frontend Transport; Thu, 12 Oct 2017 13:10:39 +0000 Received: from netperf2.ap.freescale.net ([10.232.133.164]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v9CDAKSN008029; Thu, 12 Oct 2017 06:10:36 -0700 From: <alok.makhariya@nxp.com> To: <dev@dpdk.org> CC: <akhil.goyal@nxp.com>, <pablo.de.lara.guarch@intel.com>, <hemant.agrawal@nxp.com>, Alok Makhariya <alok.makhariya@nxp.com>, <stable@dpdk.org> Date: Thu, 12 Oct 2017 18:37:24 +0530 Message-ID: <20171012130726.4332-4-alok.makhariya@nxp.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20171012130726.4332-1-alok.makhariya@nxp.com> References: <20171012130726.4332-1-alok.makhariya@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131522874405403743; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(7966004)(346002)(39860400002)(39380400002)(376002)(2980300002)(1110001)(1109001)(339900001)(189002)(199003)(106466001)(105606002)(36756003)(76176999)(2351001)(50986999)(189998001)(5660300001)(50466002)(356003)(69596002)(16586007)(48376002)(1076002)(4326008)(305945005)(33646002)(53936002)(86152003)(316002)(77096006)(498600001)(97736004)(47776003)(85426001)(86362001)(8656003)(5003940100001)(50226002)(54906003)(8936002)(6916009)(2876002)(2950100002)(81166006)(6666003)(2906002)(81156014)(8676002)(104016004)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR03MB2359; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD037; 1:TiTCclEhRwEOna8aAX+lufzIWkjQhhqDGzKECZk/rLeSM29g5+AUAM6Q82GW8ghWTxq16inCtVd9ZHaecRmZwSyoZSsEzGw7chp790Qir5ePVA0rzca+J5Ol5vliGQaE MIME-Version: 1.0 Content-Type: text/plain X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: eb23446b-0b07-4165-b15f-08d51172a329 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:CO2PR03MB2359; X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2359; 3:XHidVyazBAqK+5TMO0FiDgDIe3HINw7Bmt0jJq2cXpk0Keckj1bf771tkRSaaHh7O+6aeE3c4detP3foKi0oMF6Vw0O2g/sHNmEvfkMaSGUnE7JA89vk7dihImxDDyiG0OKjquDf/aYCtH8YJosQEGNmPIsqS9M5yETMLmGNWpyycbIQWwr8XpOAP2LWrKJqwVZ4ktq4UAXOZRQ3HT+btxOIGe/x5XrNk1VTPNdmO5k6j59irb8RUovX1nolNK1ZeovkMpbczB+OUZG2h7NWh5gd5/ap5q03jfMKcsRd+b18DfHs3px1XqEfE0hqfVJZmGVH3nsMknBmwdLq46P3a1gC5KKyCaq1YJaIsS8uRS0=; 25:JCxp2MkKL5E7UJvriTo3CKK5o6bFCsvENETjPbdwDZ32enWtHXuJn/7ILuTsZ2nCZCAqZvre3gTqMBZMLQbNdn5sJQ+2Kxq5oYexh2fAzfhk7dJgflvzyT7xGnvktRNiwlJCFp7TVUdFkcjDYUYBcWo2Ocnz2R6F0IQwNXjzIYntzzsXjNrkgLLJybW9FmYTuIBNF52QHfD08kd+1gSHXysWkW3CIzGsi7HcGMLgoFy8OWrXYQw7U+cyqs/ny049w4GUrEyp9jhd6bHOyJ3nTXcDExPFFR+8tFWIVY6TKmvQdaTf86eoPevBKnsevAOtCBUonnrzyaDE+dnbVZemqg== X-MS-TrafficTypeDiagnostic: CO2PR03MB2359: X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2359; 31:2cH5bObchSJjUd8M/7AMhTLlEZNBGXRYb+tm4HCfCTpBVX54bktfhhVUC8y3B9s4J6eWFtmYfYBi/b2rt1zGLsunUX/wg0r+C7QP9jSXGV8V040fCzFlmr2VRafRu4rDqDNcXEpAybxAeD56HPgKoIRTEhjMKTRvKfjT4/a3locfJ4JLYjrlxhgA7po2nSuUWwkgMOUF0MQ+rJ9q1Vdbr3UJ+Bhh/UsL2k8YmfHjKPM=; 4:zds6JRJPf4Lns8dImGveI+gBWO5HABjHl2jHBfIyVfXN0ZorQsvT9IeMzgrVULzbkfwNwxZYm3Q4nCYPBv/eONxrkm8c7UO4yC3z/cqpn9cEfQCLDz9O2ZCKv8dcdYsaHn/TNT5cOJzeegCtWlEDs5C8DeOZkH8T0NBQp+fq6Ea1wwHZ3Y4NCk/xmZv/Z5iQEseoHdlZg+wqMQrIK7xpv9nyFu96U2V6scAlw3HEQKN44ebpRSqRTeIjFoRuDeUlEJQUJ0HhR2mWpO0OPcnoqoSuQayM5gIGKXWfEb56A8E= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: <CO2PR03MB23592200D23206FFF4806772994B0@CO2PR03MB2359.namprd03.prod.outlook.com> X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6055026)(6096035)(201703131430075)(201703131441075)(201703131448075)(201703131433075)(201703161259150)(20161123559100)(20161123563025)(20161123561025)(20161123556025)(20161123565025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CO2PR03MB2359; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CO2PR03MB2359; X-Forefront-PRVS: 04583CED1A X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CO2PR03MB2359; 23:caLv0hbGjDGcqanAT9GP2lZRIX1xt16KKGcMcF7eG?= +oSEVqQKjNVJ6++tJDZEtgmKXyRyZ6JJBV+Drp6Y2r493gUuh5IBG+Vi4l3O4NOcrCGc+sSdIikOOkVvxt+Vy/liteE6a1/iOdNW0EbTabwCaQSU5dIowD4m7A1IOywt5v4QxZ165aHP4ieg9TwacNIwcbZhl81RiYrTVA2uzqtdKSxhA19aZFfBCdbR53e5UHlOS+btgQdJlS+AXKh3NHRq9jf98xEGzd+8ClcNwQZbwUNVWndGgUmkTEv07G9eRpKQNUkMBMUX7jyxS+/xwGWBj2p+WHU40u4LnqVxwzilRv0k/X3p2aDA3E2Fi1CauZFYO7HTwX7y2isKTuqfLVlMMONnK/DZjl3uSA2CbgbclTR9mtMhqEFQef9gx3EJBJcDnOYhgxDSyRIh/KP7es/157c5/RLHiX+Oh8TFVGymt8+LaJXptzzJwSyTnYEpSN+hKaytCdrb7FVzh7hKVDb4/8ng0CDj3QR3mT7foEVTuk7XUpMkTiWg/QWyfq6h49PiJiP7sR+kduzkHVCo7SeUB+tqAEVP4zhIFm3Qle2eqlA+r9voJMqieMAMRUxR0E+/FtySikrI6+boJSmt0y8UikW/O3D0SOG0As+xBRffPBvCG2eA/UEXvK+UcGeG6dmmJ+XqLDilCtHvWAlh9mbcU+2R7XCLRLkKXJ4BSuzSxl9nyAX2NAZvydGrLBrWJeogQccVQEqjg+zVhpholZ1v5z6JOBlEmKnNlWg5yXLAmywswFxevXvgDSK1+RaVsrx5HhUlZ+erFEV4h50ZUNjmDjyxv8G2ceNNUdfQ3KO8zl3n6kqm0AOUL2C3GNXhjrWvn08ZxfJBqJI047IL6A41dRg2zvjZ4VZMKrhjFAvGYE44SmSKtlobU4HedFFX+ZyURTl9JeSdWI8fP/4P3lDbP7gO8CX8X0uuY0RS4j1vqi2VDNLbuRitZICrelXOPRbbajkt5HYs0zL38faeai0PMS7Ce2Z7xXApw0VoyTdg4XFmNQDS6NmOu/CHzbfS2mF5rtRSa6abL+E09DELclKdV19ZviAHNIpoNyGwNnpe/wmVbAxPb0yUR8tHB53ADIqSXIl88lXxfJ2g03wg4VekiCkwBN/EOEmwdn9Lg8wWPvAXDUhUTpg6SdSOv1lPUmqeR1VO/WmMZDaF8bsQvGOpmXfkEUR+wzxnn7+Yu62f3McETPoCoda2jMcXqoswkmAh+UvG0rskNAt49HHAOg6 X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2359; 6:qlO5DZxwzgktehYIivE+ywvT17qo57Bh6U+enTxyuR+lIMgcn/ZLAlkwftEEl+JNc87v5hIf6yCkfPe4mdO9i3JOqmhPI2AUwJEBr2VZmi3lBv1Ygovlf6PFc3Pbm3GF/zAwMmYb6wWOm9+9P8Hp/G59Q9cT3BCoaSNCSHF/AC0z36HthE4eKOS/BXwUf7TQhfLwxchdunPcOccGxapwqaa92jt+GOSPbzOeYGRDTuCtnaFDzndgPzMlu4kV8g4wS1OsqaapttaYCVSHCs6UfwaofuiARx8u8lAM17o1f2fGwWz3tud72C4yN3cbz1TzgWzK367aM2KRA7eWqQu4Zw==; 5:/QhhXfrSrFtS629THiKvxvMlb2VjHjnnNjb48Ah5ONIXyxm7JOi9/2t9j+Nj2XRVg9qCyx1oqfkrG8Er9M7Ysb0SrYrP+Ux4pkp7581bvtJoF8OkVR3/tCw8fL2ICtJU7ujEdyXwZViGnpkbRLSzyw==; 24:yx8tXhC4Ev2+iZfcJ5NM7nd2luxSFLDv/BjD1SCgrtyI8Fufq5cQcbgrq1TFDWnk5sYE+5fzi0q70n9amATq32K+9SgcSvUHqdaXoVYI70U=; 7:hnbYDBF/An0SK3QriGLzewHLxxLmJY5Xy5g7IOaP29UprYigSPmS/FKfNOnUK9wHZkVz4pprXYOshiw9knUMB4QqEnQl/OGrh2aAU434r3pkxTIGjoFqMRB1B0Xj10z93iUwB/VTvmcAuRwBExgOwPPBRwNGRogDpz+zpt19DNGuj5B/RC2QGDqmRslmyqtyszLuUagvH/gVrfws0kwm4A7SPsByhSx+VbLVw6GGhWw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2017 13:10:39.4171 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR03MB2359 Subject: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove memset of icv on decryption side X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Checks
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
Commit Message
alok.makhariya@nxp.com
Oct. 12, 2017, 1:07 p.m. UTC
From: Alok Makhariya <alok.makhariya@nxp.com> Since the packet lengths are modified. It is not required to explicitly reset the icv. Fixes: 13273250eec5 ("crypto/dpaa2_sec: support AES-GCM and CTR") Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation") Cc: stable@dpdk.org Signed-off-by: Alok Makhariya <alok.makhariya@nxp.com> --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 3 --- 1 file changed, 3 deletions(-)
Comments
On 10/12/2017 6:37 PM, alok.makhariya@nxp.com wrote: > From: Alok Makhariya <alok.makhariya@nxp.com> > > Since the packet lengths are modified. It is not required to > explicitly reset the icv. > > Fixes: 13273250eec5 ("crypto/dpaa2_sec: support AES-GCM and CTR") > Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation") > Cc: stable@dpdk.org > > Signed-off-by: Alok Makhariya <alok.makhariya@nxp.com> > --- > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > index 9895300..62b9203 100644 > --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > @@ -203,7 +203,6 @@ build_authenc_gcm_fd(dpaa2_sec_session *sess, > old_icv = (uint8_t *)(sge + 1); > memcpy(old_icv, sym_op->aead.digest.data, > sess->digest_length); > - memset(sym_op->aead.digest.data, 0, sess->digest_length); > DPAA2_SET_FLE_ADDR(sge, DPAA2_VADDR_TO_IOVA(old_icv)); > sge->length = sess->digest_length; > DPAA2_SET_FD_LEN(fd, (sym_op->aead.data.length + > @@ -342,7 +341,6 @@ build_authenc_fd(dpaa2_sec_session *sess, > old_icv = (uint8_t *)(sge + 1); > memcpy(old_icv, sym_op->auth.digest.data, > sess->digest_length); > - memset(sym_op->auth.digest.data, 0, sess->digest_length); > DPAA2_SET_FLE_ADDR(sge, DPAA2_VADDR_TO_IOVA(old_icv)); > sge->length = sess->digest_length; > DPAA2_SET_FD_LEN(fd, (sym_op->auth.data.length + > @@ -436,7 +434,6 @@ build_auth_fd(dpaa2_sec_session *sess, struct rte_crypto_op *op, > old_digest = (uint8_t *)(sge + 1); > rte_memcpy(old_digest, sym_op->auth.digest.data, > sess->digest_length); > - memset(sym_op->auth.digest.data, 0, sess->digest_length); > DPAA2_SET_FLE_ADDR(sge, DPAA2_VADDR_TO_IOVA(old_digest)); > sge->length = sess->digest_length; > fle->length = sym_op->auth.data.length + > > Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
> -----Original Message----- > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > Sent: Friday, October 13, 2017 3:24 PM > To: alok.makhariya@nxp.com; dev@dpdk.org > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; > hemant.agrawal@nxp.com; stable@dpdk.org > Subject: Re: [PATCH] crypto/dpaa2_sec: remove memset of icv on > decryption side > > On 10/12/2017 6:37 PM, alok.makhariya@nxp.com wrote: > > From: Alok Makhariya <alok.makhariya@nxp.com> > > > > Since the packet lengths are modified. It is not required to > > explicitly reset the icv. > > > > Fixes: 13273250eec5 ("crypto/dpaa2_sec: support AES-GCM and CTR") > > Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation") > > Cc: stable@dpdk.org > > > > Signed-off-by: Alok Makhariya <alok.makhariya@nxp.com> ... > Acked-by: Akhil Goyal <akhil.goyal@nxp.com> Applied to dpdk-next-crypto. Thanks, Pablo
diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c index 9895300..62b9203 100644 --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c @@ -203,7 +203,6 @@ build_authenc_gcm_fd(dpaa2_sec_session *sess, old_icv = (uint8_t *)(sge + 1); memcpy(old_icv, sym_op->aead.digest.data, sess->digest_length); - memset(sym_op->aead.digest.data, 0, sess->digest_length); DPAA2_SET_FLE_ADDR(sge, DPAA2_VADDR_TO_IOVA(old_icv)); sge->length = sess->digest_length; DPAA2_SET_FD_LEN(fd, (sym_op->aead.data.length + @@ -342,7 +341,6 @@ build_authenc_fd(dpaa2_sec_session *sess, old_icv = (uint8_t *)(sge + 1); memcpy(old_icv, sym_op->auth.digest.data, sess->digest_length); - memset(sym_op->auth.digest.data, 0, sess->digest_length); DPAA2_SET_FLE_ADDR(sge, DPAA2_VADDR_TO_IOVA(old_icv)); sge->length = sess->digest_length; DPAA2_SET_FD_LEN(fd, (sym_op->auth.data.length + @@ -436,7 +434,6 @@ build_auth_fd(dpaa2_sec_session *sess, struct rte_crypto_op *op, old_digest = (uint8_t *)(sge + 1); rte_memcpy(old_digest, sym_op->auth.digest.data, sess->digest_length); - memset(sym_op->auth.digest.data, 0, sess->digest_length); DPAA2_SET_FLE_ADDR(sge, DPAA2_VADDR_TO_IOVA(old_digest)); sge->length = sess->digest_length; fle->length = sym_op->auth.data.length +