diff mbox

[dpdk-dev,v2] config: make AVX and AVX512 configurable

Message ID 1493334014-69488-1-git-send-email-zhihong.wang@intel.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Zhihong Wang April 27, 2017, 11 p.m. UTC 
  Making AVX and AVX512 configurable is useful for performance and power
testing.

The similar kernel patch at https://patchwork.kernel.org/patch/9618883/.

AVX512 support like in rte_memcpy has been in DPDK since 16.04, but it's
still unproven in rich use cases in hardware. Therefore it's marked as
experimental for now, will enable it after enough field test and possible
optimization.

Signed-off-by: Zhihong Wang <zhihong.wang@intel.com>
---
Changes in v2:

 1. Add comments and explanation.

---
 config/common_base | 8 ++++++++
 mk/rte.cpuflags.mk | 6 ++++++
 2 files changed, 14 insertions(+)

Comments

Yang, Zhiyong April 28, 2017, 2:08 a.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhihong Wang
> Sent: Friday, April 28, 2017 7:00 AM
> To: dev@dpdk.org
> Cc: yuanhan.liu@linux.intel.com; thomas@monjalon.net; Richardson, Bruce
> <bruce.richardson@intel.com>; Wang, Zhihong <zhihong.wang@intel.com>
> Subject: [dpdk-dev] [PATCH v2] config: make AVX and AVX512 configurable
> 
> Making AVX and AVX512 configurable is useful for performance and power
> testing.
> 
> The similar kernel patch at https://patchwork.kernel.org/patch/9618883/.
> 
> AVX512 support like in rte_memcpy has been in DPDK since 16.04, but it's still
> unproven in rich use cases in hardware. Therefore it's marked as experimental
> for now, will enable it after enough field test and possible optimization.
> 
> Signed-off-by: Zhihong Wang <zhihong.wang@intel.com>
> ---

Reviewed-by: Zhiyong Yang <zhiyong.yang@intel.com>

Thanks
Zhiyong
Yuanhan Liu April 28, 2017, 5:07 a.m. UTC | #2 
On Thu, Apr 27, 2017 at 07:00:14PM -0400, Zhihong Wang wrote:
> Making AVX and AVX512 configurable is useful for performance and power
> testing.
> 
> The similar kernel patch at https://patchwork.kernel.org/patch/9618883/.
> 
> AVX512 support like in rte_memcpy has been in DPDK since 16.04, but it's
> still unproven in rich use cases in hardware. Therefore it's marked as
> experimental for now, will enable it after enough field test and possible
> optimization.
> 
> Signed-off-by: Zhihong Wang <zhihong.wang@intel.com>

Reviewed-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>

	--yliu
Thomas Monjalon April 30, 2017, 9:19 p.m. UTC | #3 
28/04/2017 04:08, Yang, Zhiyong:
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhihong Wang
> > 
> > Making AVX and AVX512 configurable is useful for performance and power
> > testing.
> > 
> > The similar kernel patch at https://patchwork.kernel.org/patch/9618883/.
> > 
> > AVX512 support like in rte_memcpy has been in DPDK since 16.04, but it's still
> > unproven in rich use cases in hardware. Therefore it's marked as experimental
> > for now, will enable it after enough field test and possible optimization.
> > 
> > Signed-off-by: Zhihong Wang <zhihong.wang@intel.com>
> 
> Reviewed-by: Zhiyong Yang <zhiyong.yang@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/config/common_base b/config/common_base
index 0b4297c..93e9235 100644
--- a/config/common_base
+++ b/config/common_base
@@ -103,6 +103,14 @@  CONFIG_RTE_EAL_IGB_UIO=n
 CONFIG_RTE_EAL_VFIO=n
 CONFIG_RTE_MALLOC_DEBUG=n
 
+#
+# Recognize/ignore the AVX/AVX512 CPU flags for performance/power testing.
+# AVX512 is marked as experimental for now, will enable it after enough
+# field test and possible optimization.
+#
+CONFIG_RTE_ENABLE_AVX=y
+CONFIG_RTE_ENABLE_AVX512=n
+
 # Default driver path (or "" to disable)
 CONFIG_RTE_EAL_PMD_PATH=""
 
diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk
index e634abc..4288c14 100644
--- a/mk/rte.cpuflags.mk
+++ b/mk/rte.cpuflags.mk
@@ -70,8 +70,10 @@  CPUFLAGS += PCLMULQDQ
 endif
 
 ifneq ($(filter $(AUTO_CPUFLAGS),__AVX__),)
+ifeq ($(CONFIG_RTE_ENABLE_AVX),y)
 CPUFLAGS += AVX
 endif
+endif
 
 ifneq ($(filter $(AUTO_CPUFLAGS),__RDRND__),)
 CPUFLAGS += RDRAND
@@ -86,12 +88,16 @@  CPUFLAGS += F16C
 endif
 
 ifneq ($(filter $(AUTO_CPUFLAGS),__AVX2__),)
+ifeq ($(CONFIG_RTE_ENABLE_AVX),y)
 CPUFLAGS += AVX2
 endif
+endif
 
 ifneq ($(filter $(AUTO_CPUFLAGS),__AVX512F__),)
+ifeq ($(CONFIG_RTE_ENABLE_AVX512),y)
 CPUFLAGS += AVX512F
 endif
+endif
 
 # IBM Power CPU flags
 ifneq ($(filter $(AUTO_CPUFLAGS),__PPC64__),)