Message ID | 20231222171820.8778-1-stephen@networkplumber.org (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E862643760; Fri, 22 Dec 2023 18:18:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D727A402B9; Fri, 22 Dec 2023 18:18:32 +0100 (CET) Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by mails.dpdk.org (Postfix) with ESMTP id A6AA5402A6 for <dev@dpdk.org>; Fri, 22 Dec 2023 18:18:31 +0100 (CET) Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-6d77c6437f0so1042909b3a.2 for <dev@dpdk.org>; Fri, 22 Dec 2023 09:18:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1703265511; x=1703870311; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SZOm6926KW7Q4JA+1JY55TFNQ/cfiLOVzG7kDqd+EWQ=; b=xHc1H2f0Ff9yat6CbLn1uTZNqHcrFUduaaWM7Dfc1C+r36fryJErLH4yHwlXNRWWjk 5q0N0jHoqsIUOAdr5kfBN7r5wrXjlxj4OAHt7HBnblmTZNC57SHXA8BFP/ijGmcFB6/9 n1CopYwD9+1KdypefyGedkmSrD0qFEBhAisIjRwqrWUGUE7qPyML+ml+KVrcIUlq9r56 N7pyQby3A1TjTQK3kTBPAs4RQHgomZKeCJs6fPiE2WEnfS4Ctc9EkL3WV6LcA7UCE+Oc vU9ONNNfDm0CvZSOGCEha3jbjIHti9NpihhjnQ3vRXA6BJFcVpVvKb2IfXwe3s2GnX9c lO2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703265511; x=1703870311; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SZOm6926KW7Q4JA+1JY55TFNQ/cfiLOVzG7kDqd+EWQ=; b=daHeBfNKG/l8wY1Rd4g7ZDjGG0bRyHclcFdeEXwILDPfsu3372CL1PoJiIeKmc2dk9 bqtiZ0NfHeidjjTQ0LwQMKJUiwyVaiVt0CEYCD2m9AfzD4NEUHp+Anm3r3tDi3YjMnaR 6D/TIIb+6KODWx7qcRQ3L67FvXbrN5BjzW4pvnpItRjJQigrvg3aYwmG+6D5IiHXtdB0 17eBmr8IXKoEtydywZLaf4cNJWzrDJzLQ6XugD4mvJkHy1iyIL+v5hPCNiGmXStDKzIk aXZeulspuWboKl5aCDEPWm1lHIVvIsDPjvlGkz6rrZOkR5qypOAm9qaAkzTzlTAkT6cb h28Q== X-Gm-Message-State: AOJu0Ywtv6ybkkdWUhy8CWttz5qvt7YkdPUASjnNmNm8n42hCPL29Q9f J7XkNwsu3oo+w+wXfxINBYmkMigLx3ittS/AsJGVA2MzHg4Qaw== X-Google-Smtp-Source: AGHT+IHTtBiwrLC45eLuokxGtV236pQWNCjL3708DpinI93oD/xfAt/q5N8T6W+ppM6V/KD7SU5QJQ== X-Received: by 2002:a05:6a00:13a1:b0:6d9:98ea:e8ad with SMTP id t33-20020a056a0013a100b006d998eae8admr330969pfg.47.1703265510755; Fri, 22 Dec 2023 09:18:30 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id h19-20020a62b413000000b006d7d454e58asm372024pfn.117.2023.12.22.09.18.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Dec 2023 09:18:30 -0800 (PST) From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Cc: Stephen Hemminger <stephen@networkplumber.org> Subject: [PATCH v6 00/20] Remove uses of PMD logtype Date: Fri, 22 Dec 2023 09:11:33 -0800 Message-ID: <20231222171820.8778-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213014408.612051-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
Remove uses of PMD logtype
|
|
Message
Stephen Hemminger
Dec. 22, 2023, 5:11 p.m. UTC
The generic RTE_LOGTYPE_PMD is a leftover and should be removed. This replaces all uses in current tree. It leaves PMD logtype as deprecated because there maybe other uses in external projects leftover. This version does not use Depends-on: because CI system can't handle that and want to make sure no PMD left behind v6 - add a couple of more places remove PMD logtype in last patch David Marchand (1): drivers: use dedicated logtypes Stephen Hemminger (19): common/sfc_efx: remove use of PMD logtype mempool/dpaa2: use driver logtype not PMD net/dpaa: use dedicated logtype not PMD net/dpaa2: used dedicated logtype not PMD net/mrvl: do not use PMD logtype net/mvpp2: use dedicated logtype net/nfb: use dynamic logtype net/vmxnet3: used dedicated logtype not PMD raw/cnxk: replace PMD logtype with dynamic type crypto/scheduler: replace use of logtype PMD crypto/armv8: do not use PMD logtype crypto/ccp: do not use PMD logtype crypto/caam_jr: use dedicated logtype crypto/dpaa_sec, crypto/dpaa2_sec: use dedicated logtype event/dlb2: use dedicated logtype event/dpaa, event/dpaa2: use dedicated logtype event/skeleton: replace logtype PMD with dynamic type examples/fips_validation: replace use of PMD logtype log: remove PMD log type .../baseband/la12xx/bbdev_la12xx_pmd_logs.h | 3 +- drivers/bus/cdx/cdx_logs.h | 3 +- drivers/bus/fslmc/fslmc_logs.h | 3 +- drivers/common/cnxk/roc_platform.h | 16 +- drivers/common/cpt/cpt_pmd_logs.h | 6 +- drivers/common/dpaax/caamflib/compat.h | 4 +- drivers/common/dpaax/dpaax_logs.h | 3 +- drivers/common/dpaax/version.map | 1 + drivers/common/idpf/idpf_common_logs.h | 5 +- drivers/common/sfc_efx/sfc_efx.c | 11 +- drivers/common/sfc_efx/sfc_efx_log.h | 2 +- drivers/crypto/armv8/rte_armv8_pmd.c | 4 +- drivers/crypto/caam_jr/caam_jr.c | 46 ++- drivers/crypto/caam_jr/caam_jr_log.h | 15 +- drivers/crypto/caam_jr/caam_jr_uio.c | 4 +- drivers/crypto/ccp/rte_ccp_pmd.c | 13 +- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 6 +- drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h | 3 +- drivers/crypto/dpaa_sec/dpaa_sec.c | 30 +- drivers/crypto/dpaa_sec/dpaa_sec_log.h | 3 +- drivers/crypto/scheduler/scheduler_pmd.c | 4 +- drivers/dma/dpaa/dpaa_qdma_logs.h | 3 +- drivers/dma/dpaa2/dpaa2_qdma_logs.h | 3 +- drivers/event/dlb2/dlb2.c | 275 +++++++++--------- drivers/event/dlb2/dlb2_log.h | 3 +- drivers/event/dpaa/dpaa_eventdev.c | 2 +- drivers/event/dpaa2/dpaa2_eventdev.c | 4 +- drivers/event/dpaa2/dpaa2_eventdev_logs.h | 3 +- drivers/event/dpaa2/dpaa2_eventdev_selftest.c | 6 +- drivers/event/skeleton/skeleton_eventdev.c | 4 +- drivers/event/skeleton/skeleton_eventdev.h | 8 +- drivers/mempool/dpaa/dpaa_mempool.c | 1 + drivers/mempool/dpaa/dpaa_mempool.h | 2 +- drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 4 +- drivers/mempool/dpaa2/dpaa2_hw_mempool_logs.h | 3 +- drivers/net/atlantic/atl_logs.h | 5 +- drivers/net/avp/avp_logs.h | 5 +- drivers/net/bnxt/bnxt.h | 1 + drivers/net/bnxt/bnxt_rxtx_vec_neon.c | 2 +- drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 2 +- drivers/net/bnxt/bnxt_txr.c | 2 +- drivers/net/dpaa/dpaa_ethdev.c | 8 +- drivers/net/dpaa/dpaa_ethdev.h | 3 +- drivers/net/dpaa2/dpaa2_ethdev.c | 2 +- drivers/net/dpaa2/dpaa2_pmd_logs.h | 3 +- drivers/net/dpaa2/dpaa2_sparser.c | 4 +- drivers/net/enetc/enetc_logs.h | 3 +- drivers/net/enetfec/enet_pmd_logs.h | 3 +- drivers/net/igc/igc_logs.h | 5 +- drivers/net/mana/mana.h | 3 +- drivers/net/mvpp2/mrvl_ethdev.c | 7 +- drivers/net/nfb/nfb.h | 5 + drivers/net/nfb/nfb_ethdev.c | 24 +- drivers/net/nfb/nfb_rx.c | 9 +- drivers/net/nfb/nfb_rx.h | 2 +- drivers/net/nfb/nfb_tx.c | 9 +- drivers/net/nfb/nfb_tx.h | 2 +- drivers/net/octeon_ep/otx_ep_common.h | 2 + drivers/net/octeon_ep/otx_ep_rxtx.c | 2 +- drivers/net/octeontx/octeontx_logs.h | 3 +- drivers/net/pfe/pfe_logs.h | 3 +- drivers/net/qede/qede_logs.h | 5 +- drivers/net/virtio/virtio_logs.h | 5 +- drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +- drivers/net/vmxnet3/vmxnet3_logs.h | 7 +- drivers/raw/cnxk_bphy/cnxk_bphy.c | 3 +- drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c | 2 +- drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c | 31 +- drivers/raw/cnxk_bphy/rte_pmd_bphy.h | 6 + drivers/raw/cnxk_gpio/cnxk_gpio.c | 21 +- drivers/raw/cnxk_gpio/cnxk_gpio.h | 5 + drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c | 17 +- drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h | 3 +- .../raw/ifpga/base/osdep_rte/osdep_generic.h | 5 +- drivers/vdpa/ifc/base/ifcvf.c | 10 +- drivers/vdpa/ifc/base/ifcvf_osdep.h | 7 +- examples/fips_validation/fips_dev_self_test.c | 44 +-- lib/log/log.c | 1 - lib/log/rte_log.h | 2 +- 79 files changed, 420 insertions(+), 381 deletions(-)
Comments
On Fri, Dec 22, 2023 at 6:18 PM Stephen Hemminger <stephen@networkplumber.org> wrote: > > The generic RTE_LOGTYPE_PMD is a leftover and should be removed. > This replaces all uses in current tree. It leaves PMD logtype > as deprecated because there maybe other uses in external projects > leftover. > > This version does not use Depends-on: because CI system can't > handle that and want to make sure no PMD left behind > > v6 - add a couple of more places > remove PMD logtype in last patch This series mixes unrelated changes, like adding missing \n or removing some of them. I identified a couple of places where it introduces issues by doing so. Please focus on changing the logtype / log macros and not silently "fix" other log issues. We can fix the latter, later. Details of what I spotted: - there is the "funny" case of event/dlb2 where the DLB2_LOG_DBG macro does not add a \n, while _INFO and _ERR do, - there is also the case of some _DP log macros in some drivers. For the drivers below, the _DP macro won't add a \n, while their non _DP macro equivalent do add one... $ git grep 'RTE_LOG_DP(.*fmt' drivers/ | grep -v '\\n' | cut -d : -f 1 | xargs grep -B1 -w RTE_LOG_DP drivers/baseband/la12xx/bbdev_la12xx_pmd_logs.h-#define rte_bbdev_dp_log(level, fmt, args...) \ drivers/baseband/la12xx/bbdev_la12xx_pmd_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args) -- drivers/bus/cdx/cdx_logs.h-#define CDX_BUS_DP_LOG(level, fmt, args...) \ drivers/bus/cdx/cdx_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args) -- drivers/bus/fslmc/fslmc_logs.h-#define DPAA2_BUS_DP_LOG(level, fmt, args...) \ drivers/bus/fslmc/fslmc_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args) -- drivers/common/dpaax/dpaax_logs.h-#define DPAAX_DP_LOG(level, fmt, args...) \ drivers/common/dpaax/dpaax_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args) -- drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h-#define DPAA2_SEC_DP_LOG(level, fmt, args...) \ drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args) -- drivers/crypto/dpaa_sec/dpaa_sec_log.h-#define DPAA_SEC_DP_LOG(level, fmt, args...) \ drivers/crypto/dpaa_sec/dpaa_sec_log.h: RTE_LOG_DP(level, PMD, fmt, ## args) -- drivers/event/dlb2/dlb2_log.h-#define DLB2_LOG_DBG(fmt, args...) \ drivers/event/dlb2/dlb2_log.h: RTE_LOG_DP(DEBUG, PMD, fmt, ## args) -- drivers/event/dpaa2/dpaa2_eventdev_logs.h-#define DPAA2_EVENTDEV_DP_LOG(level, fmt, args...) \ drivers/event/dpaa2/dpaa2_eventdev_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args) -- drivers/event/dsw/dsw_evdev.h-#define DSW_LOG_DP(level, fmt, args...) \ drivers/event/dsw/dsw_evdev.h: RTE_LOG_DP(level, EVENTDEV, "[%s] %s() line %u: " fmt, \ -- drivers/mempool/dpaa/dpaa_mempool.h-#define DPAA_MEMPOOL_DPDEBUG(fmt, args...) \ drivers/mempool/dpaa/dpaa_mempool.h: RTE_LOG_DP(DEBUG, PMD, fmt, ## args) -- drivers/mempool/dpaa2/dpaa2_hw_mempool_logs.h-#define DPAA2_MEMPOOL_DP_LOG(level, fmt, args...) \ drivers/mempool/dpaa2/dpaa2_hw_mempool_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args) -- drivers/net/dpaa/dpaa_ethdev.h-#define DPAA_DP_LOG(level, fmt, args...) \ drivers/net/dpaa/dpaa_ethdev.h: RTE_LOG_DP(level, PMD, fmt, ## args) -- drivers/net/dpaa2/dpaa2_pmd_logs.h-#define DPAA2_PMD_DP_LOG(level, fmt, args...) \ drivers/net/dpaa2/dpaa2_pmd_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args) -- drivers/net/enetc/enetc_logs.h-#define ENETC_PMD_DP_LOG(level, fmt, args...) \ drivers/net/enetc/enetc_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args) -- drivers/net/enetfec/enet_pmd_logs.h-#define ENETFEC_DP_LOG(level, fmt, args...) \ drivers/net/enetfec/enet_pmd_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args) -- drivers/net/pfe/pfe_logs.h-#define PFE_DP_LOG(level, fmt, args...) \ drivers/net/pfe/pfe_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args)
On Fri, 19 Jan 2024 14:59:58 +0100 David Marchand <david.marchand@redhat.com> wrote: > This series mixes unrelated changes, like adding missing \n or > removing some of them. > I identified a couple of places where it introduces issues by doing so. > > Please focus on changing the logtype / log macros and not silently > "fix" other log issues. > We can fix the latter, later. > > > Details of what I spotted: > > - there is the "funny" case of event/dlb2 where the DLB2_LOG_DBG macro > does not add a \n, while _INFO and _ERR do, > > - there is also the case of some _DP log macros in some drivers. > For the drivers below, the _DP macro won't add a \n, while their non > _DP macro equivalent do add one... I wonder should _DP macros behave same as non _DP versions around newline. It makes sense to me that it should always be the same. If so, let me split that as step 1 in these cases.
On Fri, 19 Jan 2024 14:59:58 +0100 David Marchand <david.marchand@redhat.com> wrote: > $ git grep 'RTE_LOG_DP(.*fmt' drivers/ | grep -v '\\n' | cut -d : -f 1 > | xargs grep -B1 -w RTE_LOG_DP > drivers/baseband/la12xx/bbdev_la12xx_pmd_logs.h-#define > rte_bbdev_dp_log(level, fmt, args...) \ > drivers/baseband/la12xx/bbdev_la12xx_pmd_logs.h: RTE_LOG_DP(level, > PMD, fmt, ## args) > -- > drivers/bus/cdx/cdx_logs.h-#define CDX_BUS_DP_LOG(level, fmt, args...) \ > drivers/bus/cdx/cdx_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args) > -- > drivers/bus/fslmc/fslmc_logs.h-#define DPAA2_BUS_DP_LOG(level, fmt, args...) \ > drivers/bus/fslmc/fslmc_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args) > -- > drivers/common/dpaax/dpaax_logs.h-#define DPAAX_DP_LOG(level, fmt, args...) \ > drivers/common/dpaax/dpaax_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args) > -- > drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h-#define > DPAA2_SEC_DP_LOG(level, fmt, args...) \ > drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h: RTE_LOG_DP(level, PMD, > fmt, ## args) > -- > drivers/crypto/dpaa_sec/dpaa_sec_log.h-#define DPAA_SEC_DP_LOG(level, > fmt, args...) \ > drivers/crypto/dpaa_sec/dpaa_sec_log.h: RTE_LOG_DP(level, PMD, fmt, ## args) > -- > drivers/event/dlb2/dlb2_log.h-#define DLB2_LOG_DBG(fmt, args...) \ > drivers/event/dlb2/dlb2_log.h: RTE_LOG_DP(DEBUG, PMD, fmt, ## args) > -- > drivers/event/dpaa2/dpaa2_eventdev_logs.h-#define > DPAA2_EVENTDEV_DP_LOG(level, fmt, args...) \ > drivers/event/dpaa2/dpaa2_eventdev_logs.h: RTE_LOG_DP(level, PMD, > fmt, ## args) > -- > drivers/event/dsw/dsw_evdev.h-#define DSW_LOG_DP(level, fmt, args...) > \ > drivers/event/dsw/dsw_evdev.h: RTE_LOG_DP(level, EVENTDEV, "[%s] > %s() line %u: " fmt, \ > -- > drivers/mempool/dpaa/dpaa_mempool.h-#define DPAA_MEMPOOL_DPDEBUG(fmt, args...) \ > drivers/mempool/dpaa/dpaa_mempool.h: RTE_LOG_DP(DEBUG, PMD, fmt, ## args) > -- > drivers/mempool/dpaa2/dpaa2_hw_mempool_logs.h-#define > DPAA2_MEMPOOL_DP_LOG(level, fmt, args...) \ > drivers/mempool/dpaa2/dpaa2_hw_mempool_logs.h: RTE_LOG_DP(level, > PMD, fmt, ## args) > -- > drivers/net/dpaa/dpaa_ethdev.h-#define DPAA_DP_LOG(level, fmt, args...) \ > drivers/net/dpaa/dpaa_ethdev.h: RTE_LOG_DP(level, PMD, fmt, ## args) > -- > drivers/net/dpaa2/dpaa2_pmd_logs.h-#define DPAA2_PMD_DP_LOG(level, > fmt, args...) \ > drivers/net/dpaa2/dpaa2_pmd_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args) > -- > drivers/net/enetc/enetc_logs.h-#define ENETC_PMD_DP_LOG(level, fmt, args...) \ > drivers/net/enetc/enetc_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args) > -- > drivers/net/enetfec/enet_pmd_logs.h-#define ENETFEC_DP_LOG(level, fmt, > args...) \ > drivers/net/enetfec/enet_pmd_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args) > -- > drivers/net/pfe/pfe_logs.h-#define PFE_DP_LOG(level, fmt, args...) \ > drivers/net/pfe/pfe_logs.h: RTE_LOG_DP(level, PMD, fmt, ## args) Most of these are from the first patch (yours). Shall I fix those as well?