Message ID | 1703006864-27378-1-git-send-email-roretzla@linux.microsoft.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0E99943747; Tue, 19 Dec 2023 18:27:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CF0CA42E11; Tue, 19 Dec 2023 18:27:48 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 5A38242DED for <dev@dpdk.org>; Tue, 19 Dec 2023 18:27:47 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id A9A0420B3CC1; Tue, 19 Dec 2023 09:27:46 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A9A0420B3CC1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1703006866; bh=BXvKRThD2+wVukai5kwgpXl3PHm0QwOlogy3s5S+knc=; h=From:To:Cc:Subject:Date:From; b=ix1iq/1EKeMT+fFOQgGTXZ0SU60IDj1bWugwBe8TpPLI79sDnj+O6kAzCnQZ0qTIR Zm6+jxmUIpaBnrkJzezZtf02vXMJAm3WXrALjGkiEP6azSrdm3dxg5eksj3tPOjEaL ETdpYuE1pogjZhlstWBoepOYfjpzPS6LHxHTQlfQ= From: Tyler Retzlaff <roretzla@linux.microsoft.com> To: dev@dpdk.org Cc: Tyler Retzlaff <roretzla@linux.microsoft.com> Subject: [PATCH 0/2] remove __typeof__ from expansion of per lcore macros Date: Tue, 19 Dec 2023 09:27:42 -0800 Message-Id: <1703006864-27378-1-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
remove __typeof__ from expansion of per lcore macros
|
|
Message
Tyler Retzlaff
Dec. 19, 2023, 5:27 p.m. UTC
The design of the macros requires a type to be provided to the macro. By expanding the type parameter inside of typeof it also inadvertently allows an expression to be used which appears not to have been intended after evaluating the parameter name and existing macro use. Technically this is an API break but only for applications that were using these macros outside of the original design intent. Tyler Retzlaff (2): eal: provide type instead of expression to per lcore macro eal: remove typeof from per lcore macros lib/eal/common/eal_common_errno.c | 2 +- lib/eal/include/rte_per_lcore.h | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-)
Comments
On Tue, Dec 19, 2023 at 09:27:42AM -0800, Tyler Retzlaff wrote: > The design of the macros requires a type to be provided to the macro. > > By expanding the type parameter inside of typeof it also inadvertently > allows an expression to be used which appears not to have been intended > after evaluating the parameter name and existing macro use. > > Technically this is an API break but only for applications that were > using these macros outside of the original design intent. > > Tyler Retzlaff (2): > eal: provide type instead of expression to per lcore macro > eal: remove typeof from per lcore macros > Series-acked-by: Bruce Richardson <bruce.richardson@intel.com>
On Tue, Dec 19, 2023 at 6:28 PM Tyler Retzlaff <roretzla@linux.microsoft.com> wrote: > > The design of the macros requires a type to be provided to the macro. > > By expanding the type parameter inside of typeof it also inadvertently > allows an expression to be used which appears not to have been intended > after evaluating the parameter name and existing macro use. > > Technically this is an API break but only for applications that were > using these macros outside of the original design intent. Please add a release note on this topic (I am fine with just a reply to this mail, I can fold this change when applying). The rest lgtm.